Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1617894

Summary: Auth plugins leave passwords in the access log and audit log using REST
Product: Red Hat Enterprise Linux 7 Reporter: Amol K <akahat>
Component: pki-coreAssignee: Dinesh Prasanth <dmoluguw>
Status: CLOSED ERRATA QA Contact: Asha Akkiangady <aakkiang>
Severity: high Docs Contact: Marc Muehlfeld <mmuehlfe>
Priority: high    
Version: 7.6CC: ascheel, cfu, cpelland, dmoluguw, edewata, jmagne, mharmsen, msauton, nkinder
Target Milestone: rcKeywords: TestCaseProvided, ZStream
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: pki-core-10.5.16-2.el7 Doc Type: Bug Fix
Doc Text:
.The Certificate System REST API no longer stores clear text passwords in log files Previously, the Certificate System REST API did not filter out plain password values. As a consequence, passwords were visible in clear text in log files. With this update, the server replaces password attribute values with "(sensitive)". As a result, clear text passwords are no longer visible in logs.
 Story Points: ---
Clone Of:
: 1645263 (view as bug list) Environment:
Last Closed: 2019-08-06 13:07:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1645263    
Attachments:
Description Flags
Auth plugin add using python none

Description Amol K 2018-08-16 05:58:22 UTC 
Description of problem:
Auth plugins leave passwords in the access log and audit logs while accessing them using REST API.

Version-Release number of selected component (if applicable):
10.5.9-4.el7

How reproducible:
Always

Steps to Reproduce:
1. Create ca authentication plugin using the REST API.
2. curl --capath "/tmp/ca_cert.pem" --basic --dump-header  /tmp/header_out.txt --user "caadmin:SECret.123" -d "OP_TYPE=OP_ADD&OP_SCOPE=instance&RS_ID=plug502&implName=UidPwdDirAuth&RULENAME=plug502&ldap.ldapconn.host=pki1.example.com&dnpattern=uid=test,ou=people,o=topology-02-CA&ldapStringAttributes=mail&ldap.ldapconn.version=3&ldap.ldapconn.port=3389&ldap.maxConns=10&ldap.basedn=dc=example,dc=org&ldap.minConns=3&ldap.ldapconn.secureConn=false&ldapByteAttributes=uid&ldap.password=SECret.123&ldap.ldapauth.authtype=BasicAuth&ldap.ldapauth.bindDN=cn=directory manager&" -k https://pki1.example.com:20443/ca/auths
3.

Actual results:
It leaves passwords in the audit logs and localhost_access_log.*.txt file.

```
# grep -ir "SECret.123" /var/log/pki/topology-02-CA/
/var/log/pki/topology-02-CA/ca/signedAudit/ca_audit:0.http-bio-20080-exec-1 - [16/Aug/2018:01:42:46 EDT] [14] [6] [AuditEvent=CONFIG_AUTH][SubjectID=caadmin][Outcome=Success][ParamNameValPairs=Scope;;instance+Operation;;OP_ADD+Resource;;plug502+implName;;UidPwdDirAuth+ldap.ldapconn.host;;localhost+dnpattern;;UID=test,OU=people,O=topology-02-CA-CA+ldapStringAttributes;;mail+ldap.ldapconn.version;;3+ldap.ldapconn.port;;3389+ldap.maxConns;;10+ldap.basedn;;dc=example,dc=org+ldap.password;;SECret.123+ldap.minConns;;3+ldap.ldapconn.secureConn;;false+ldapByteAttributes;;uid] authentication configuration parameter(s) change
/var/log/pki/topology-02-CA/ca/signedAudit/ca_audit:0.http-bio-20080-exec-3 - [16/Aug/2018:01:42:48 EDT] [14] [6] [AuditEvent=CONFIG_AUTH][SubjectID=caadmin][Outcome=Success][ParamNameValPairs=Scope;;instance+Operation;;OP_MODIFY+Resource;;plug502+implName;;UidPwdDirAuth+ldap.ldapconn.host;;localhost+dnpattern;;UID=test,OU=people,O=topology-02-CA-CA+ldapStringAttributes;;mail+ldap.ldapconn.version;;3+ldap.ldapconn.port;;3389+ldap.maxConns;;10+ldap.basedn;;dc=example,dc=org+ldap.password;;SECret.123+ldap.minConns;;3+ldap.ldapconn.secureConn;;false+ldapByteAttributes;;uid] authentication configuration parameter(s) change
/var/log/pki/topology-02-CA/localhost_access_log.2018-08-16.txt:10.67.116.185 - - [16/Aug/2018:01:42:46 -0400] "POST /ca/auths?OP_TYPE=OP_ADD&OP_SCOPE=instance&RS_ID=plug502&implName=UidPwdDirAuth&RULENAME=plug502&ldap.ldapconn.host=localhost&dnpattern=UID%3Dtest%2COU%3Dpeople%2CO%3Dtopology-02-CA-CA&ldapStringAttributes=mail&ldap.ldapconn.version=3&ldap.ldapconn.port=3389&ldap.maxConns=10&ldap.basedn=dc%3Dexample%2Cdc%3Dorg&ldap.password=SECret.123&ldap.minConns=3&ldap.ldapconn.secureConn=false&ldapByteAttributes=uid HTTP/1.1" 200 26
/var/log/pki/topology-02-CA/localhost_access_log.2018-08-16.txt:10.67.116.185 - - [16/Aug/2018:01:42:48 -0400] "POST /ca/auths?OP_TYPE=OP_MODIFY&OP_SCOPE=instance&RS_ID=plug502&implName=UidPwdDirAuth&RULENAME=plug502&ldap.ldapconn.host=localhost&dnpattern=UID%3Dtest%2COU%3Dpeople%2CO%3Dtopology-02-CA-CA&ldapStringAttributes=mail&ldap.ldapconn.version=3&ldap.ldapconn.port=3389&ldap.maxConns=10&ldap.basedn=dc%3Dexample%2Cdc%3Dorg&ldap.password=SECret.123&ldap.minConns=3&ldap.ldapconn.secureConn=false&ldapByteAttributes=uid HTTP/1.1" 200 4
```

Expected results:
It should show (sensitive) for the passwords.


Additional info:
Automated test cases: https://github.com/dogtagpki/pki/blob/master/tests/dogtag/pytest-ansible/pytest/ca/auth_plugins/test_pki_ca_auth_plugins.py
Comment 2 Matthew Harmsen 2018-09-27 19:05:12 UTC 
Per PKI Team meeting, reassigning to dmoluguw (ascheel to help)
Comment 3 Dinesh Prasanth 2018-10-01 20:29:07 UTC 
Fixed in PR: https://github.com/dogtagpki/pki/pull/57

Steps to reproduce:
As mentioned by the OP

Fixed Output:
# grep -ir 'secret.123' /var/log/pki ; echo $?
1
# grep -ir '(sensitive)' /var/log/pki ; echo $?
/var/log/pki/pki-tomcat/ca/signedAudit/ca_audit:0.http-bio-8443-exec-1 - [01/Oct/2018:10:40:03 EDT] [14] [6] [AuditEvent=CONFIG_AUTH][SubjectID=caadmin][Outcome=Success][ParamNameValPairs=Scope;;instance+Operation;;OP_ADD+Resource;;plug502+implName;;UidPwdDirAuth+ldap.ldapconn.host;;localhost.localdomain+dnpattern;;uid=caadmin,ou=people+ldapStringAttributes;;mail+ldap.ldapconn.version;;3+ldap.ldapconn.port;;389+ldap.maxConns;;10+ldap.basedn;;dc=ca,dc=pki,dc=example,dc=com+ldap.minConns;;3+ldap.ldapconn.secureConn;;false+ldapByteAttributes;;uid+ldap.password;;(sensitive)+ldap.ldapauth.authtype;;BasicAuth+ldap.ldapauth.bindDN;;cn=Directory Manager] authentication configuration parameter(s) change
/var/log/pki/pki-tomcat/ca/signedAudit/ca_audit:0.http-bio-8443-exec-8 - [01/Oct/2018:10:42:14 EDT] [14] [6] [AuditEvent=CONFIG_AUTH][SubjectID=caadmin][Outcome=Failure][ParamNameValPairs=Scope;;instance+Operation;;OP_ADD+Resource;;plug502+implName;;UidPwdDirAuth+ldap.ldapconn.host;;localhost.localdomain+dnpattern;;uid=caadmin,ou=people+ldapStringAttributes;;mail+ldap.ldapconn.version;;3+ldap.ldapconn.port;;389+ldap.maxConns;;10+ldap.basedn;;dc=ca,dc=pki,dc=example,dc=com+ldap.minConns;;3+ldap.ldapconn.secureConn;;false+ldapByteAttributes;;uid+ldap.password;;(sensitive)+ldap.ldapauth.authtype;;BasicAuth+ldap.ldapauth.bindDN;;cn=Directory Manager] authentication configuration parameter(s) change
/var/log/pki/pki-tomcat/ca/debug:[01/Oct/2018:10:40:03][http-bio-8443-exec-1]: AdminServlet::service() param name='ldap.password' value='(sensitive)'
/var/log/pki/pki-tomcat/ca/debug:[01/Oct/2018:10:41:25][http-bio-8443-exec-3]: AdminServlet::service() param name='ldap.password' value='(sensitive)'
/var/log/pki/pki-tomcat/ca/debug:[01/Oct/2018:10:41:30][http-bio-8443-exec-6]: AdminServlet::service() param name='ldap.password' value='(sensitive)'
/var/log/pki/pki-tomcat/ca/debug:[01/Oct/2018:10:42:14][http-bio-8443-exec-8]: AdminServlet::service() param name='ldap.password' value='(sensitive)'
/var/log/pki/pki-tomcat/ca/debug:[01/Oct/2018:10:42:22][http-bio-8443-exec-10]: AdminServlet::service() param name='ldap.password' value='(sensitive)'
/var/log/pki/pki-tomcat/ca/debug:[01/Oct/2018:10:42:27][http-bio-8443-exec-18]: AdminServlet::service() param name='ldap.password' value='(sensitive)'
/var/log/pki/pki-tomcat/ca/debug:[01/Oct/2018:10:42:31][http-bio-8443-exec-20]: AdminServlet::service() param name='ldap.password' value='(sensitive)'
0
Comment 5 Matthew Harmsen 2018-12-05 18:39:47 UTC 
DOGTAG_10_5_BRANCH:

commit cc2b50fac7542476aef222ab5f1d49d86e38cba1
Author: Dinesh Prasanth M K <SilleBille.github.com>
Date:   Mon Oct 1 16:25:08 2018 -0400

    Fixes password leak of Auth plugins to Audit Logs (#57)
    
    * Auth plugin adds `(sensitive)` instead of plain passwords
    to AuditLogs
    * Added generic `isSensitive()` to identify Passwords before logging
    
    Signed-off-by: Dinesh Prasanth M K <dmoluguw>
Comment 7 Amol K 2019-06-11 15:58:11 UTC 
Created attachment 1579462 [details]
Auth plugin add using python
Comment 8 Amol K 2019-06-11 16:00:40 UTC 
Hi Dinesh,

I found some strange behaviour with curl and Python script.
 - If I use curl request, I didn't saw any passwords in the access logs.
 - If I use python script, I could see the passwords in the access logs.
Comment 10 Amol K 2019-06-20 15:32:47 UTC 
As per the suggestions from Alex, I'm not able to see the passwords in the access logs with post request. 


Build: 10.5.16-2.el7

Verifying this bugzilla.
Comment 13 errata-xmlrpc 2019-08-06 13:07:17 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2228