Bug 1617917 - [Infra] : Not able to see patches in "incoming reviews queue"
Summary: [Infra] : Not able to see patches in "incoming reviews queue"
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: project-infrastructure
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nigel Babu
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-08-16 07:15 UTC by Ashish Pandey
Modified: 2018-10-03 04:17 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-10-03 04:17:17 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)
dashboard screen shot (281.54 KB, image/png)
2018-08-16 07:37 UTC, Ashish Pandey
no flags Details
screen shot of review (266.30 KB, image/png)
2018-08-16 08:08 UTC, Ashish Pandey
no flags Details

Description Ashish Pandey 2018-08-16 07:15:20 UTC
Description of problem:
This patch is not listed in "incoming reviews queue"

https://review.gluster.org/#/c/glusterfs/+/20736/
Owner has added us as reviewer and even after providing comments , we are not able to see this patch in queue

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Nigel Babu 2018-08-16 07:30:14 UTC
Can I have a screenshot of your dashboard? If you're using New UI, please also attach a screenshot of the dashboard in the Old UI

Comment 2 Ashish Pandey 2018-08-16 07:37:03 UTC
Created attachment 1476367 [details]
dashboard screen shot

Comment 3 Ashish Pandey 2018-08-16 07:38:00 UTC
Ravi is also facing this issue so I thought it is generic issue and not only to my account.

Comment 4 Nigel Babu 2018-08-16 07:47:33 UTC
I'd also like a screenshot of the range of buttons on the review as well. New Gerrit has a few options to ignore and mark things as reviewed.

Comment 5 Ashish Pandey 2018-08-16 08:08:32 UTC
Created attachment 1476372 [details]
screen shot of review

Comment 6 Ashish Pandey 2018-08-16 08:10:37 UTC
It is showing "Mark unreviewed" and if I point curser on this it says mark it unreviewed to see it on dash borad.

I tried to toggle it Mark and unmark and refreshed dash borad but still can not see it on dash board.

Comment 7 Nigel Babu 2018-08-16 08:25:23 UTC
In the screen shot, it's says "Mark Unreviewed". This will not show on the dashboard. If you click it once (the button should say "Mark Reviewed"), it should show up on the dashboard.

Comment 8 Ashish Pandey 2018-08-16 09:02:56 UTC
(In reply to Nigel Babu from comment #7)
> In the screen shot, it's says "Mark Unreviewed". This will not show on the
> dashboard. If you click it once (the button should say "Mark Reviewed"), it
> should show up on the dashboard.

That's exactly I thought and tried but its not working. I again tried it back and forth but it was not showing for any option.

Comment 9 Nigel Babu 2018-08-16 09:20:56 UTC
Can you do it once and wait for a bit. There's a good chance there's a cache.

Comment 10 Ashish Pandey 2018-08-16 16:24:32 UTC
Hi Nigel, 

I am still not able to see the patches in my review queue.
It is only with the following patches - 
https://review.gluster.org/#/c/glusterfs/+/20736/
https://review.gluster.org/#/c/glusterfs/+/20685/ 

Strange observation is that both the patches were sent by Pranith.

Ravi sent following patch today and I can see it in my review queue - 

https://review.gluster.org/#/c/glusterfs/+/20748/

Not only me, even Ravi is not seeing Pranith's patches in his queue.

One reason, which I could think of, is that Pranith sometimes forget to add us as reviewer so we add ourselves or when we provide comment we would be added as reviewer. 

Can this be the reason behind it?

Comment 11 Ravishankar N 2018-08-17 04:21:38 UTC
I was not able to see it even though I was added as a reviewer. FWIW, I am seeing it in my queue now.

Comment 12 Ashish Pandey 2018-08-17 04:25:56 UTC

After giving +1 to this patch https://review.gluster.org/#/c/glusterfs/+/20736/
I am seeing this patch in my queue.
Not the other one on which I have not given +1

Comment 13 Nigel Babu 2018-08-17 04:49:06 UTC
Huh. I'm reasonably confident that you've run into a bug in this logic with Gerrit. At this point, I cannot guarantee any fixes. It would be useful if you can search for bugs filed against Gerrit for anything like this or filing a bug: https://bugs.chromium.org/p/gerrit/issues/list?can=2

Comment 14 Nigel Babu 2018-10-03 04:17:17 UTC
I'm going to close this bug. We traced issues like this down to using CC rather than adding you as reviewer.


Note You need to log in before you can comment on or make changes to this bug.