Bug 1618628 - Review Request: python-mplcursors - Interactive data selection cursors for Matplotlib
Summary: Review Request: python-mplcursors - Interactive data selection cursors for Ma...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: José Matos
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-08-17 07:10 UTC by Elliott Sales de Andrade
Modified: 2018-08-29 00:55 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-08-29 00:55:16 UTC
Type: ---
Embargoed:
jamatos: fedora-review+


Attachments (Terms of Use)

Description Elliott Sales de Andrade 2018-08-17 07:10:39 UTC
Spec URL: https://qulogic.fedorapeople.org//python-mplcursors.spec
SRPM URL: https://qulogic.fedorapeople.org//python-mplcursors-0.2-1.fc28.src.rpm

Description:
mplcursors – Interactive data selection cursors for Matplotlib

Comment 1 Elliott Sales de Andrade 2018-08-17 07:10:43 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=29133921

Comment 2 José Matos 2018-08-17 09:46:27 UTC
fedora-review outputs:

- Binary eggs must be removed in %prep
  Note: Binary egg files not removed in %prep:
  ./vendor/setuptools_scm-1.17.0.egg
  See:
  http://fedoraproject.org/wiki/Packaging:Python#Packaging_eggs_and_setuptools_concerns


The line in %prep that pretends to this is
rm -rf %{srcname}.egg-info

But there is no file to remove. And that file gets in the final rpm.


Other than that I have no issues with this package.

Comment 3 José Matos 2018-08-17 10:26:52 UTC
Actually a minor issue are the hidden files that the project has in the source file, You can see them in the github repo:

.coveragerc
.doc-requirements.txt
.readthedocs.yml
.travis.yml

I suppose that they are redundant and harmless and I suppose this is mostly an upstream issue. But it would be nice not to package them, it is your call. :-)

Comment 4 Elliott Sales de Andrade 2018-08-17 21:30:02 UTC
I removed the binary egg:

Spec URL: https://qulogic.fedorapeople.org/python-mplcursors.spec
SRPM URL: https://qulogic.fedorapeople.org/python-mplcursors-0.2-2.fc28.src.rpm

I think the hidden files are just the way setuptools-scm works. I don't think it's a big deal; the files don't appear in the resultant rpms.

Comment 5 José Matos 2018-08-17 22:34:44 UTC
(In reply to Elliott Sales de Andrade from comment #4)
> 
> I think the hidden files are just the way setuptools-scm works. I don't
> think it's a big deal; the files don't appear in the resultant rpms.

Right. :-)

The package is approved.

Comment 6 Gwyn Ciesla 2018-08-17 23:09:55 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-mplcursors

Comment 7 Fedora Update System 2018-08-18 01:32:15 UTC
python-mplcursors-0.2-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-4ec6edacfc

Comment 8 Fedora Update System 2018-08-19 03:26:19 UTC
python-mplcursors-0.2-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-4ec6edacfc

Comment 9 Fedora Update System 2018-08-29 00:55:16 UTC
python-mplcursors-0.2-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.