Spec URL: https://raw.githubusercontent.com/praiskup/rpm-python-inotify_simple/master/python-inotify-simple.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/praiskup/rpm-python-inotify_simple/epel-7-x86_64/00788668-python-inotify_simple/python-inotify_simple-1.1.8-1.el7.src.rpm Description: inotify_simple is a simple Python wrapper around inotify. No fancy bells and whistles, just a literal wrapper with ctypes. Only 122 lines of code! Fedora Account System Username: praiskup
Testing copr: https://copr.fedorainfracloud.org/coprs/praiskup/rpm-python-inotify_simple/
- Please rename your spec to match the name field. Package approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-inotify_simple , python3-inotify_simple [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /home/bob/packaging/review/python-inotify- simple/review-python-inotify_simple/srpm-unpacked/python-inotify- simple.spec See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python2-inotify_simple-1.1.8-1.fc29.noarch.rpm python3-inotify_simple-1.1.8-1.fc29.noarch.rpm python-inotify_simple-1.1.8-1.fc29.src.rpm python2-inotify_simple.noarch: W: spelling-error Summary(en_US) inotify -> notify, i notify, bogotify python2-inotify_simple.noarch: W: spelling-error %description -l en_US inotify -> notify, i notify, bogotify python2-inotify_simple.noarch: W: spelling-error %description -l en_US ctypes -> types, c types python2-inotify_simple.noarch: W: no-documentation python3-inotify_simple.noarch: W: spelling-error Summary(en_US) inotify -> notify, i notify, bogotify python3-inotify_simple.noarch: W: spelling-error %description -l en_US inotify -> notify, i notify, bogotify python3-inotify_simple.noarch: W: spelling-error %description -l en_US ctypes -> types, c types python3-inotify_simple.noarch: W: no-documentation python-inotify_simple.src: W: spelling-error Summary(en_US) inotify -> notify, i notify, bogotify python-inotify_simple.src: W: spelling-error %description -l en_US inotify -> notify, i notify, bogotify python-inotify_simple.src: W: spelling-error %description -l en_US ctypes -> types, c types python-inotify_simple.src: E: invalid-spec-name 3 packages and 0 specfiles checked; 1 errors, 11 warnings.
Thanks, renamed: https://raw.githubusercontent.com/praiskup/rpm-python-inotify_simple/master/python-inotify_simple.spec Repo requested: https://pagure.io/releng/fedora-scm-requests/issue/7694
FTR (search engine optimization), this package is needed for "textern" (Firefox extension).
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-inotify_simple
https://koji.fedoraproject.org/koji/taskinfo?taskID=29150994
Upstream release monitoring record: https://release-monitoring.org/project/17608/
python-inotify_simple-1.1.8-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-9162548458
python-inotify_simple-1.1.8-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-2e1c4a357c
python-inotify_simple-1.1.8-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-27109e14e2
python-inotify_simple-1.1.8-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-27109e14e2
python-inotify_simple-1.1.8-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-9162548458
python-inotify_simple-1.1.8-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-2e1c4a357c
python-inotify_simple-1.1.8-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
python-inotify_simple-1.1.8-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.
python-inotify_simple-1.1.8-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.