RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1619386 - subprocess32: Heap overflow in _PySequence_BytesToCharpArray
Summary: subprocess32: Heap overflow in _PySequence_BytesToCharpArray
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: python-subprocess32
Version: 7.6
Hardware: All
OS: Linux
unspecified
low
Target Milestone: rc
: ---
Assignee: Python Maintainers
QA Contact: Jan Kepler
URL:
Whiteboard:
Depends On:
Blocks: 1630906
TreeView+ depends on / blocked
 
Reported: 2018-08-20 16:47 UTC by Scott Gayou
Modified: 2019-08-06 12:34 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-08-06 12:34:21 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Backport of upstream patch (1.70 KB, patch)
2018-08-22 14:52 UTC, Marcel Plch
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2019:2036 0 None None None 2019-08-06 12:34:22 UTC

Description Scott Gayou 2018-08-20 16:47:50 UTC
Description of problem:
The _PySequence_BytesToCharpArray function in the C portion of the python module contains a triggerable integer wraparound which leads to a heap overflow. This is only appears to be triggerable via rather strange/contrived usage of the module, but should still be fixed in case another method is discovered that leads to triggering it.


Version-Release number of selected component (if applicable):
At least 3.2.6 - > 3.5.2. May be in earlier versions, I did not check.

How reproducible:
100%

Steps to Reproduce:
1. Boot a 32bit system.
2. import subprocess32 as subprocess
subprocess._posixsubprocess.fork_exec("a",'a'*0x3FFFFFFF,"a",set(),"a","a",1,1,1,1,1,1,1,3,1,1,"a")

Actual results:
*** glibc detected *** /usr/bin/python: double free or corruption (!prev): 0x09464b38 ***
Segmentation fault (core dumped)

Expected results:
Error message.

Additional info:
Upstream issue: https://github.com/google/python-subprocess32/issues/54
Upstream fix: https://github.com/google/python-subprocess32/pull/55

Comment 2 Marcel Plch 2018-08-22 14:52:47 UTC
Created attachment 1477908 [details]
Backport of upstream patch

I've created a backport of the upstream fix.

Comment 5 Victor Stinner 2018-10-10 08:43:36 UTC
> Upstream issue: https://github.com/google/python-subprocess32/issues/54
> Upstream fix: https://github.com/google/python-subprocess32/pull/55

The fix is now merged and subprocess32 version 3.5.3 has been released with the fix.

Comment 12 errata-xmlrpc 2019-08-06 12:34:21 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2036


Note You need to log in before you can comment on or make changes to this bug.