Bug 1619843 - Snapshot status fails with commit failure
Summary: Snapshot status fails with commit failure
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: snapshot
Version: mainline
Hardware: x86_64
OS: Linux
unspecified
urgent
Target Milestone: ---
Assignee: Sunny Kumar
QA Contact:
URL:
Whiteboard:
Depends On: 1619538
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-08-21 21:40 UTC by Sunny Kumar
Modified: 2018-10-23 15:17 UTC (History)
8 users (show)

Fixed In Version: glusterfs-5.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1619538
Environment:
Last Closed: 2018-10-23 15:17:29 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Sunny Kumar 2018-08-21 21:40:07 UTC
+++ This bug was initially created as a clone of Bug #1619538 +++

Description of problem:
=======================

Snapshot status fails with commit failure for activated snapshots.
This is the case for the activated snapshots which were present after OS update . Clones of these snapshots were also present along with other volumes (from which the snapshots were taken)


Version-Release number of selected component (if applicable):
=============================================================
mainline


How reproducible:
=================
2/2


Steps to Reproduce:
===================

1. On older OS version , Create snapshots of a volume and activate them
2. Create clones of these activated snapshots
3. Upgrade OS
4. Perform a " gluster snapshot status <snap-name> "command 

Actual results:
===============

Snapshot status failing with commit failure


Expected results:
=================

Status of the snapshots should be shown properly


Additional info:
================


The activated snapshots get deactivated and deleted successfully.
After deactivating, if the snapshot is activated again, the snapshot status result is the same as in the actual results.

Comment 1 Worker Ant 2018-08-21 22:53:39 UTC
REVIEW: https://review.gluster.org/20885 (snapshot : fix snapshot status failure due to symlink problem) posted (#1) for review on master by Sunny Kumar

Comment 2 Sunny Kumar 2018-08-22 04:02:50 UTC
Root Cause :  When OS upgrade is from RHEL6 to RHEL7 there is difference in
              symlink (/var/run)  between these two versions.
              Basically when (/var/run) is symlinked to /run, mount command
              resolves path and mounts it. But at the same time call to
              those functions fails who depends on absolute path.
              (like strcmp in glusterd_get_mnt_entry_info)

Comment 3 Worker Ant 2018-08-23 02:25:19 UTC
COMMIT: https://review.gluster.org/20885 committed in master by "Atin Mukherjee" <amukherj> with a commit message- snapshot : fix snapshot status failure due to symlink problem

Problems : 1. Snapshot status for individual snapshots were failing after OS
              upgrade from RHEL6 to RHEL7.
           2. Post upgrade snapshot creation of cloned volume was failing.

Root Cause :  When OS upgrade is from RHEL6 to RHEL7 there is difference in
              symlink (/var/run)  between these two versions.
              Basically when (/var/run) is symlinked to /run, mount command
              resolves path and mounts it. But at the same time call to
              those functions fails who depends on absolute path.
              (like strcmp in glusterd_get_mnt_entry_info)

Solution : Resolve the input path to absolute path before calling these
           functions.

Test : Tested on same setup where issue was reported. After this
       patch snapshot issues are completely resolved.

Change-Id: I5ba57998cea614c6072709f52f42a57562018844
fixes: bz#1619843
Signed-off-by: Sunny Kumar <sunkumar>

Comment 4 Shyamsundar 2018-10-23 15:17:29 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-5.0, please open a new bug report.

glusterfs-5.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2018-October/000115.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.