Cause: The fast forward upgrade process was trying to disable rhel-7-server-rhceph-2-osd-rpms from all nodes, without checking if the system was subscribed to it
Consequence: The process would stop failing on those nodes which were not subscribed to rhel-7-server-rhceph-2-osd-rpms
Fix: Continue with the upgrade process even if rhel-7-server-rhceph-2-osd-rpms can not be disabled
Result: The fast forward upgrade procedure disables rhel-7-server-rhceph-2-osd-rpms where found, without failing when it's not found
Description of problem:
FFU: openstack overcloud ffwd-upgrade run fails if overcloud nodes do not have the rhel-7-server-rhceph-2-osd-rpms repository enabled:
in /usr/share/openstack-tripleo-heat-templates/puppet/services/tripleo-packages.yaml:
FastForwardCustomRepoScriptContent:
default: |
#!/bin/bash
set -e
echo "If you use FastForwardRepoType 'custom-script' you have to provide the upgrade repo script content."
echo "It will be installed as /root/ffu_upgrade_repo.sh on the node"
echo "and passed the upstream name (ocata, pike, queens) of the release as first argument"
case $1 in
ocata)
subscription-manager repos --disable=rhel-7-server-openstack-10-rpms
subscription-manager repos --enable=rhel-7-server-openstack-11-rpms
;;
pike)
subscription-manager repos --disable=rhel-7-server-openstack-11-rpms
subscription-manager repos --enable=rhel-7-server-openstack-12-rpms
;;
queens)
subscription-manager repos --disable=rhel-7-server-openstack-12-rpms
subscription-manager repos --enable=rhel-7-server-openstack-13-rpms
subscription-manager repos --disable=rhel-7-server-rhceph-2-osd-rpms
subscription-manager repos --disable=rhel-7-server-rhceph-2-mon-rpms
subscription-manager repos --enable=rhel-7-server-rhceph-3-mon-rpms
subscription-manager repos --disable=rhel-7-server-rhceph-2-tools-rpms
subscription-manager repos --enable=rhel-7-server-rhceph-3-tools-rpms
;;
*)
echo "unknown release $1" >&2
exit 1
esac
type: string
Version-Release number of selected component (if applicable):
openstack-tripleo-heat-templates-8.0.4-20.el7ost.noarch
How reproducible:
100%
Steps to Reproduce:
1. Deploy OSP10 without Ceph OSD nodes
2. Upgrade to OSP13 via ffu procedure by using the default script provided by FastForwardCustomRepoScriptContent
Actual results:
subscription-manager repos --disable=rhel-7-server-rhceph-2-osd-rpms fails as the repo is not enabled
Expected results:
subscription-manager repos --disable=rhel-7-server-rhceph-2-osd-rpms runs only when the repo is enabled as it is a requirement only for nodes running ceph osds
Additional info:
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.
https://access.redhat.com/errata/RHBA-2018:3587
Description of problem: FFU: openstack overcloud ffwd-upgrade run fails if overcloud nodes do not have the rhel-7-server-rhceph-2-osd-rpms repository enabled: in /usr/share/openstack-tripleo-heat-templates/puppet/services/tripleo-packages.yaml: FastForwardCustomRepoScriptContent: default: | #!/bin/bash set -e echo "If you use FastForwardRepoType 'custom-script' you have to provide the upgrade repo script content." echo "It will be installed as /root/ffu_upgrade_repo.sh on the node" echo "and passed the upstream name (ocata, pike, queens) of the release as first argument" case $1 in ocata) subscription-manager repos --disable=rhel-7-server-openstack-10-rpms subscription-manager repos --enable=rhel-7-server-openstack-11-rpms ;; pike) subscription-manager repos --disable=rhel-7-server-openstack-11-rpms subscription-manager repos --enable=rhel-7-server-openstack-12-rpms ;; queens) subscription-manager repos --disable=rhel-7-server-openstack-12-rpms subscription-manager repos --enable=rhel-7-server-openstack-13-rpms subscription-manager repos --disable=rhel-7-server-rhceph-2-osd-rpms subscription-manager repos --disable=rhel-7-server-rhceph-2-mon-rpms subscription-manager repos --enable=rhel-7-server-rhceph-3-mon-rpms subscription-manager repos --disable=rhel-7-server-rhceph-2-tools-rpms subscription-manager repos --enable=rhel-7-server-rhceph-3-tools-rpms ;; *) echo "unknown release $1" >&2 exit 1 esac type: string Version-Release number of selected component (if applicable): openstack-tripleo-heat-templates-8.0.4-20.el7ost.noarch How reproducible: 100% Steps to Reproduce: 1. Deploy OSP10 without Ceph OSD nodes 2. Upgrade to OSP13 via ffu procedure by using the default script provided by FastForwardCustomRepoScriptContent Actual results: subscription-manager repos --disable=rhel-7-server-rhceph-2-osd-rpms fails as the repo is not enabled Expected results: subscription-manager repos --disable=rhel-7-server-rhceph-2-osd-rpms runs only when the repo is enabled as it is a requirement only for nodes running ceph osds Additional info: