Bug 1620568 - Review Request: High perf clear linux kernel for fedora - clear linux kernel packaged to mimic similar perf in fedora
Summary: Review Request: High perf clear linux kernel for fedora - clear linux kernel ...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-08-23 07:54 UTC by Manas Mangaonkar (Pac23)
Modified: 2018-09-09 18:56 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-09-09 17:36:03 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Manas Mangaonkar (Pac23) 2018-08-23 07:54:36 UTC
COPR url : https://copr.fedorainfracloud.org/coprs/pac23/High_Performance_Clear_LInux_kernel_for_Fedora/

Description: Intel's clear linux kernel has been packaged for fedora to mimic similar performance of the clear linux os by intel. 

Fedora Account System Username: Pac23

This is my first package and i wish to be a part of the package maintainers group so that i can contribute to even more packages that require to be sponsored member. 

Basically i need a sponsor.

Comment 1 Robert-André Mauchin 🐧 2018-08-23 15:31:07 UTC
You should post direct links to the SPEC and SRPM.

Comment 2 Robert-André Mauchin 🐧 2018-08-23 16:05:41 UTC
Also you need to give this package a proper name. The package name and the name of this review must be the same, "kernel" obviously won't work as it would conflict.

Comment 3 Manas Mangaonkar (Pac23) 2018-08-23 16:55:47 UTC
Hello , Than you for the feedback,will do and post asap.

Comment 4 Iñaki Ucar 2018-08-24 00:16:43 UTC
I don't think that submitting a kernel package is acceptable. The kernel is a core component, and it's a responsibility of the Fedora Engineering team. Specific versions of the kernel should be managed in separate repositories, as Linux vanilla kernels:
https://fedoraproject.org/wiki/Kernel_Vanilla_Repositories

Comment 5 clime 2018-08-27 07:21:34 UTC
In my opinion as an observer, the main think is to name the package differently, then there is going to be no conflict. By the way, you can get the links to srpm and spec from the build in Copr https://copr-be.cloud.fedoraproject.org/results/pac23/High_Performance_Clear_LInux_kernel_for_Fedora/fedora-rawhide-x86_64/00777716-kernel/

Comment 6 Iñaki Ucar 2018-08-27 08:25:09 UTC
(In reply to clime from comment #5)
> In my opinion as an observer, the main think is to name the package
> differently, then there is going to be no conflict.

There is a thread in fedora-devel where they were talking about this kernel, and about the possibility of porting some of the patches to Fedora: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/UXTL3INISMOIVYI4JOYVHCEOFLMFC7CO/

The conclusion was that many of these patches are Intel-specific, so it wouldn't be a good idea to port them to Fedora, because it would harm its aim. Someone proposed that the way to go was to maintain this in a Copr, and Manas volunteered.

Anyway, I don't know of any other kernel version accepted in the main repos with other name, and the packaging guidelines and policies talk about *the* kernel, as if there was just one. So at the very least, I think that someone from the kernel team should take a look at this ticket.

> By the way, you can get
> the links to srpm and spec from the build in Copr
> https://copr-be.cloud.fedoraproject.org/results/pac23/
> High_Performance_Clear_LInux_kernel_for_Fedora/fedora-rawhide-x86_64/
> 00777716-kernel/

Robert-André knows how to get the SPEC and the SRPM from a Copr repo, but that's not the procedure. There is even a template when you open a review request to link them, so that the reviewer can use the fedora-review tool just with the bug ID.

Comment 7 clime 2018-08-27 09:05:56 UTC
> Robert-André knows how to get the SPEC and the SRPM from a Copr repo, but that's not the procedure. There is even a template when you open a review request to link them, so that the reviewer can use the fedora-review tool just with the bug ID.

I was pointing that out to the review reporter, not to Robert but thanks for pointing out some additional resources.

Comment 8 Iñaki Ucar 2018-08-27 09:15:45 UTC
(In reply to clime from comment #7)
> I was pointing that out to the review reporter, not to Robert but thanks for
> pointing out some additional resources.

Ah, sorry, that makes more sense. :)

BTW, do you know who to ping about this? I asked in #fedora-kernel, but got no response.

Comment 9 Iñaki Ucar 2018-08-27 09:37:34 UTC
For the record, I asked the Fedora Packaging Committee: https://pagure.io/packaging-committee/issue/791

Comment 10 Manas Mangaonkar (Pac23) 2018-08-27 09:52:22 UTC
> Robert-André knows how to get the SPEC and the SRPM from a Copr repo, but
> that's not the procedure. There is even a template when you open a review
> request to link them, so that the reviewer can use the fedora-review tool
> just with the bug ID.

Hey,i am rebuilding it with some fixes,will file a new review request with the proper links. 

Imo this should stay as a copr repo/package rather than merging it in the main repo's unless the the kernel team thinks so.I dont really know what the procedure is.

Comment 11 Iñaki Ucar 2018-08-27 10:59:24 UTC
(In reply to Manas Mangaonkar from comment #10)
> Hey,i am rebuilding it with some fixes,will file a new review request with
> the proper links. 

Don't file a new review request. Just supply them here in a comment.

> Imo this should stay as a copr repo/package rather than merging it in the
> main repo's unless the the kernel team thinks so.I dont really know what the
> procedure is.

If the packaging committee says that this should stay as a Copr, then there's no further procedure needed. You can maintain any number of packages in your Copr repo autonomously, there's no need to file tickets here for that.

Comment 12 Iñaki Ucar 2018-08-27 14:12:39 UTC
(In reply to Iñaki Ucar from comment #9)
> For the record, I asked the Fedora Packaging Committee:
> https://pagure.io/packaging-committee/issue/791

This is not allowed according to the feedback above, so I'm closing this issue.

Comment 13 clime 2018-08-27 19:07:09 UTC
It was a bit premature to close this. I don't think there has been clear consesus on that in the thread (https://pagure.io/packaging-committee/issue/791) yet.

Comment 14 Iñaki Ucar 2018-08-27 19:19:26 UTC
Third comment by labbott:

> I thought this was documented somewhere on the kernel wiki (https://fedoraproject.org/wiki/Kernel) but I guess not. One kernel has been the policy for a very long time. If you're interested in changing this, I suggest working through the Fedora change process to review what needs to be done.

I got the same response from #fedora-kernel before that.

Now, we are mainly discussing where this should be documented.

Comment 15 clime 2018-08-29 07:30:05 UTC
(In reply to Iñaki Ucar from comment #14)
> Third comment by labbott:
> 
> > I thought this was documented somewhere on the kernel wiki (https://fedoraproject.org/wiki/Kernel) but I guess not. One kernel has been the policy for a very long time. If you're interested in changing this, I suggest working through the Fedora change process to review what needs to be done.
> 
> I got the same response from #fedora-kernel before that.
> 
> Now, we are mainly discussing where this should be documented.

Ok, thank you for taking care of this!

Comment 16 Manas Mangaonkar (Pac23) 2018-09-09 08:20:23 UTC
(In reply to Robert-André Mauchin from comment #1)
> You should post direct links to the SPEC and SRPM.

https://github.com/Pac23/Kernel-Clear-Fed/releases - link to the src.rpm
https://github.com/Pac23/Kernel-Clear-Fed/blob/master/kernel.spec - spec file link.

Comment 17 Manas Mangaonkar (Pac23) 2018-09-09 08:21:01 UTC
These are links to the latest build.

Comment 18 Iñaki Ucar 2018-09-09 17:36:03 UTC
Manas, as we discussed, this package is not allowed in the main repos, and that's why we closed this ticket. There's no point in posting the SPEC here or reopening it.

If you want feedback, you'll probably find people interested in this kernel flavour in the devel mailing list.

Comment 19 Manas Mangaonkar (Pac23) 2018-09-09 18:37:02 UTC
(In reply to Iñaki Ucar from comment #18)
> Manas, as we discussed, this package is not allowed in the main repos, and
> that's why we closed this ticket. There's no point in posting the SPEC here
> or reopening it.
> 
> If you want feedback, you'll probably find people interested in this kernel
> flavour in the devel mailing list.

Yes,
I did get feedback from those interested on the devel mailing list,i only filed this offical review request because i am seeking sponsorship as a packager/maintainer in fedora and this is a must.

Comment 20 Iñaki Ucar 2018-09-09 18:56:06 UTC
(In reply to Manas Mangaonkar from comment #19)
> I did get feedback from those interested on the devel mailing list,i only
> filed this offical review request because i am seeking sponsorship as a
> packager/maintainer in fedora and this is a must.

And to get sponsored with a new package, you need to submit one that *can* be accepted in the main repos. This one cannot. So, please, select another software not already packaged in Fedora, ensure it is suitable for the main repos, and file *another* review request.

Also, read other submissions and comment on them to show prospective sponsors that you understand the guidelines.


Note You need to log in before you can comment on or make changes to this bug.