Bug 1620595 - Update README files to use etc/ovirt-engine-metrics/config.yml.d/ to update variables
Summary: Update README files to use etc/ovirt-engine-metrics/config.yml.d/ to update v...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine-metrics
Classification: oVirt
Component: Generic
Version: unspecified
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.2.8
: ---
Assignee: Shirly Radco
QA Contact: Ivana Saranova
URL:
Whiteboard:
Depends On:
Blocks: 1654221
TreeView+ depends on / blocked
 
Reported: 2018-08-23 09:30 UTC by Lucie Leistnerova
Modified: 2019-02-05 12:45 UTC (History)
5 users (show)

Fixed In Version: ovirt-engine-metrics-1.1.8
Clone Of:
Environment:
Last Closed: 2019-01-22 10:23:07 UTC
oVirt Team: Metrics
Embargoed:
rule-engine: ovirt-4.2+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 93885 0 master MERGED Update READMEs update variables 2018-08-30 12:00:02 UTC
oVirt gerrit 94045 0 ovirt-engine-metrics-4.2 MERGED Update READMEs update variables 2018-08-30 12:20:41 UTC

Description Lucie Leistnerova 2018-08-23 09:30:55 UTC
Description of problem:
For d/s there is setting in /etc/ovirt-engine-metrics/config.yml.d/00-rhvm-defaults.yml. When I want to change it according to e.g.
/usr/share/ansible/roles/Virt.metrics/roles/oVirt.metrics-store-installation/README.md ,
setting in config.yml doesn't change it.  

Version-Release number of selected component (if applicable):
ovirt-engine-metrics-1.1.7-1.el7ev.noarch

How reproducible: always


Steps to Reproduce:
1. have engine machine and clean rhel
2. create metrics config on engine machine
cp /etc/ovirt-engine-metrics/config.yml.example /etc/ovirt-engine-metrics/config.yml
3. add to config.yml row:
openshift_distribution: origin
4. prepare ssh connection to rhel machine described in
https://www.ovirt.org/develop/release-management/features/metrics/metrics-store-installation/#configure-ssh-key-based-authentication-between-engine-and-metrics-store-machine
5. run on engine machine
/usr/share/ovirt-engine-metrics/setup/ansible/configure_ovirt_machines_for_metrics.sh --playbook=ovirt-metrics-store-installation.yml

Actual results: on rhel machine is copied ansible-inventory-ocp-39-aio inventory


Expected results: on rhel machine is copied ansible-inventory-origin-39-aio inventory

Comment 1 Shirly Radco 2018-08-23 10:16:15 UTC
You are right. I'll update the README.
The files in /etc/ovirt-engine-metrics/config.yml.d/ take precedence over the config.yml file.
This behavior should remain the same.

Comment 2 Lukas Svaty 2018-10-24 15:47:39 UTC
What's the fixed in version, did this get to 4.2.7 build?

Comment 3 Shirly Radco 2018-10-28 08:15:49 UTC
This did not make it to 4.2.7. Updated target milestone to 4.2.8.

Comment 4 Ivana Saranova 2018-12-20 10:57:19 UTC
Testing that /etc/ovirt-engine-metrics/config.yml.d/config.yml takes precedence over /etc/ovirt-engine-metrics/config.yml
Steps taken:
1. have engine machine and clean rhel
2. create metrics config on engine machine
cp /etc/ovirt-engine-metrics/config.yml.example /etc/ovirt-engine-metrics/config.yml
3. add to config.yml row:
openshift_distribution: origin
4. prepare ssh connection to rhel machine described in
https://www.ovirt.org/develop/release-management/features/metrics/metrics-store-installation/#configure-ssh-key-based-authentication-between-engine-and-metrics-store-machine
5. run on engine machine
/usr/share/ovirt-engine-metrics/setup/ansible/configure_ovirt_machines_for_metrics.sh --playbook=ovirt-metrics-store-installation.yml

Results: on rhel machine is copied ansible-inventory-ocp-311-aio inventory

Steps taken:
1. have engine machine and clean rhel
2. create metrics config on engine machine
cp /etc/ovirt-engine-metrics/config.yml.example /etc/ovirt-engine-metrics/config.yml
3. add to /etc/ovirt-engine-metrics/config.yml.d/config.yml row:
openshift_distribution: origin
4. prepare ssh connection to rhel machine described in
https://www.ovirt.org/develop/release-management/features/metrics/metrics-store-installation/#configure-ssh-key-based-authentication-between-engine-and-metrics-store-machine
5. run on engine machine
/usr/share/ovirt-engine-metrics/setup/ansible/configure_ovirt_machines_for_metrics.sh --playbook=ovirt-metrics-store-installation.yml

Results: on rhel machine is copied ansible-inventory-origin-311-aio inventory

Results are in accordance with expected behavior.
Verified in: ovirt-engine-metrics-1.1.8-1.el7ev.noarch, ovirt-engine-4.2.8-0.1.el7ev.noarch

Comment 5 Ivana Saranova 2018-12-20 10:59:15 UTC
The link to the documentation is broken, so I followed this one instead: https://www.ovirt.org/documentation/metrics-install-guide/Setting_Up_the_oVirt_Engine_and_Hosts.html

(In reply to Ivana Saranova from comment #4)
> Testing that /etc/ovirt-engine-metrics/config.yml.d/config.yml takes
> precedence over /etc/ovirt-engine-metrics/config.yml
> Steps taken:
> 1. have engine machine and clean rhel
> 2. create metrics config on engine machine
> cp /etc/ovirt-engine-metrics/config.yml.example
> /etc/ovirt-engine-metrics/config.yml
> 3. add to config.yml row:
> openshift_distribution: origin
> 4. prepare ssh connection to rhel machine described in
> https://www.ovirt.org/develop/release-management/features/metrics/metrics-
> store-installation/#configure-ssh-key-based-authentication-between-engine-
> and-metrics-store-machine
> 5. run on engine machine
> /usr/share/ovirt-engine-metrics/setup/ansible/
> configure_ovirt_machines_for_metrics.sh
> --playbook=ovirt-metrics-store-installation.yml
> 
> Results: on rhel machine is copied ansible-inventory-ocp-311-aio inventory
> 
> Steps taken:
> 1. have engine machine and clean rhel
> 2. create metrics config on engine machine
> cp /etc/ovirt-engine-metrics/config.yml.example
> /etc/ovirt-engine-metrics/config.yml
> 3. add to /etc/ovirt-engine-metrics/config.yml.d/config.yml row:
> openshift_distribution: origin
> 4. prepare ssh connection to rhel machine described in
> https://www.ovirt.org/develop/release-management/features/metrics/metrics-
> store-installation/#configure-ssh-key-based-authentication-between-engine-
> and-metrics-store-machine
> 5. run on engine machine
> /usr/share/ovirt-engine-metrics/setup/ansible/
> configure_ovirt_machines_for_metrics.sh
> --playbook=ovirt-metrics-store-installation.yml
> 
> Results: on rhel machine is copied ansible-inventory-origin-311-aio inventory
> 
> Results are in accordance with expected behavior.
> Verified in: ovirt-engine-metrics-1.1.8-1.el7ev.noarch,
> ovirt-engine-4.2.8-0.1.el7ev.noarch

Comment 7 Sandro Bonazzola 2019-01-22 10:23:07 UTC
This bugzilla is included in oVirt 4.2.8 release, published on January 22nd 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.2.8 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.

Comment 8 Ivana Saranova 2019-02-05 12:45:42 UTC
Since Sandro closed this bug as current release, I think we can focus on the new documentation for the metrics store.


Note You need to log in before you can comment on or make changes to this bug.