Bug 1620595
| Summary: | Update README files to use etc/ovirt-engine-metrics/config.yml.d/ to update variables | ||
|---|---|---|---|
| Product: | [oVirt] ovirt-engine-metrics | Reporter: | Lucie Leistnerova <lleistne> |
| Component: | Generic | Assignee: | Shirly Radco <sradco> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Ivana Saranova <isaranov> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | unspecified | CC: | bugs, dfediuck, isaranov, lsvaty, sradco |
| Target Milestone: | ovirt-4.2.8 | Flags: | rule-engine:
ovirt-4.2+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | ovirt-engine-metrics-1.1.8 | Doc Type: | Bug Fix |
| Doc Text: |
Cause:
Updating config.yml will not apply if same variable are set in /etc/ovirt-engine-metrics/config.yml.d/
Consequence:
Variables will not be according to what the user expected.
Fix:
Updated the README instructions. Variables should be set by adding a file to /etc/ovirt-engine-metrics/config.yml.d/. Files are applied by alphanumeric order and the last variable setting wins.
Result:
Updated the README instructions.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-01-22 10:23:07 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Metrics | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1654221 | ||
|
Description
Lucie Leistnerova
2018-08-23 09:30:55 UTC
You are right. I'll update the README. The files in /etc/ovirt-engine-metrics/config.yml.d/ take precedence over the config.yml file. This behavior should remain the same. What's the fixed in version, did this get to 4.2.7 build? This did not make it to 4.2.7. Updated target milestone to 4.2.8. Testing that /etc/ovirt-engine-metrics/config.yml.d/config.yml takes precedence over /etc/ovirt-engine-metrics/config.yml Steps taken: 1. have engine machine and clean rhel 2. create metrics config on engine machine cp /etc/ovirt-engine-metrics/config.yml.example /etc/ovirt-engine-metrics/config.yml 3. add to config.yml row: openshift_distribution: origin 4. prepare ssh connection to rhel machine described in https://www.ovirt.org/develop/release-management/features/metrics/metrics-store-installation/#configure-ssh-key-based-authentication-between-engine-and-metrics-store-machine 5. run on engine machine /usr/share/ovirt-engine-metrics/setup/ansible/configure_ovirt_machines_for_metrics.sh --playbook=ovirt-metrics-store-installation.yml Results: on rhel machine is copied ansible-inventory-ocp-311-aio inventory Steps taken: 1. have engine machine and clean rhel 2. create metrics config on engine machine cp /etc/ovirt-engine-metrics/config.yml.example /etc/ovirt-engine-metrics/config.yml 3. add to /etc/ovirt-engine-metrics/config.yml.d/config.yml row: openshift_distribution: origin 4. prepare ssh connection to rhel machine described in https://www.ovirt.org/develop/release-management/features/metrics/metrics-store-installation/#configure-ssh-key-based-authentication-between-engine-and-metrics-store-machine 5. run on engine machine /usr/share/ovirt-engine-metrics/setup/ansible/configure_ovirt_machines_for_metrics.sh --playbook=ovirt-metrics-store-installation.yml Results: on rhel machine is copied ansible-inventory-origin-311-aio inventory Results are in accordance with expected behavior. Verified in: ovirt-engine-metrics-1.1.8-1.el7ev.noarch, ovirt-engine-4.2.8-0.1.el7ev.noarch The link to the documentation is broken, so I followed this one instead: https://www.ovirt.org/documentation/metrics-install-guide/Setting_Up_the_oVirt_Engine_and_Hosts.html (In reply to Ivana Saranova from comment #4) > Testing that /etc/ovirt-engine-metrics/config.yml.d/config.yml takes > precedence over /etc/ovirt-engine-metrics/config.yml > Steps taken: > 1. have engine machine and clean rhel > 2. create metrics config on engine machine > cp /etc/ovirt-engine-metrics/config.yml.example > /etc/ovirt-engine-metrics/config.yml > 3. add to config.yml row: > openshift_distribution: origin > 4. prepare ssh connection to rhel machine described in > https://www.ovirt.org/develop/release-management/features/metrics/metrics- > store-installation/#configure-ssh-key-based-authentication-between-engine- > and-metrics-store-machine > 5. run on engine machine > /usr/share/ovirt-engine-metrics/setup/ansible/ > configure_ovirt_machines_for_metrics.sh > --playbook=ovirt-metrics-store-installation.yml > > Results: on rhel machine is copied ansible-inventory-ocp-311-aio inventory > > Steps taken: > 1. have engine machine and clean rhel > 2. create metrics config on engine machine > cp /etc/ovirt-engine-metrics/config.yml.example > /etc/ovirt-engine-metrics/config.yml > 3. add to /etc/ovirt-engine-metrics/config.yml.d/config.yml row: > openshift_distribution: origin > 4. prepare ssh connection to rhel machine described in > https://www.ovirt.org/develop/release-management/features/metrics/metrics- > store-installation/#configure-ssh-key-based-authentication-between-engine- > and-metrics-store-machine > 5. run on engine machine > /usr/share/ovirt-engine-metrics/setup/ansible/ > configure_ovirt_machines_for_metrics.sh > --playbook=ovirt-metrics-store-installation.yml > > Results: on rhel machine is copied ansible-inventory-origin-311-aio inventory > > Results are in accordance with expected behavior. > Verified in: ovirt-engine-metrics-1.1.8-1.el7ev.noarch, > ovirt-engine-4.2.8-0.1.el7ev.noarch This bugzilla is included in oVirt 4.2.8 release, published on January 22nd 2019. Since the problem described in this bug report should be resolved in oVirt 4.2.8 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. Since Sandro closed this bug as current release, I think we can focus on the new documentation for the metrics store. |