Bug 1621909
| Summary: | API endpoint, /version/openshift, missing with latest oc cluster up | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | John Matthews <jmatthew> |
| Component: | Service Broker | Assignee: | Jason Montleon <jmontleo> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Zhang Cheng <chezhang> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 3.11.0 | CC: | aos-bugs, deads, dzager, fabian, jiazha, jmatthew, jmontleo, jokerman, jvallejo, mmccomas, spahl, tsanders, xxia, zitang |
| Target Milestone: | --- | ||
| Target Release: | 3.11.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | No Doc Update | |
| Doc Text: |
undefined
|
Story Points: | --- |
| Clone Of: | 1621724 | Environment: | |
| Last Closed: | 2018-12-21 15:23:17 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1607913, 1624320 | ||
| Bug Blocks: | |||
|
Description
John Matthews
2018-08-23 20:41:50 UTC
Summary of the issue. A recent change was introduced to 3.11 that removes the endpoint '/version/openshift' from clusters brought up by 'oc cluster up'. Clusters brought up from openshift-ansible will continue to have /version/openshift. APBs are relying on, /version/openshift, to determine if the cluster is an openshift or k8s cluster. With this recent change APBs will be broken on oc cluster up with 3.11, this would also include minishift. Also worth noting, OCP 4.0 release will likely remove /version/openshift as well from openshift-ansible derived clusters, so long term looks best that APBs are updated to avoid relying on /version/openshift. For background info. APBs are currently relying on the below to determine different of openshift/k8s https://github.com/openshift/openshift-restclient-python/blob/master/openshift/dynamic/client.py#L64) We will update the APBs to leverage a different mechanism for determining openshift/k8s. Likely using https://github.com/ansible/ansible/blob/a8d4bf86421d151d8df7132e8e87d04b6662f45a/lib/ansible/plugins/lookup/k8s.py Automation Broker APB is still in progress: Broker APB: https://github.com/openshift/ansible-service-broker/pull/1059 MariaDB: https://github.com/ansibleplaybookbundle/mariadb-apb/pull/47 MySQL: https://github.com/ansibleplaybookbundle/mysql-apb/pull/46 PostgreSQL: https://github.com/ansibleplaybookbundle/postgresql-apb/pull/63 Mediawiki: https://github.com/ansibleplaybookbundle/mediawiki-apb/pull/41 The testing and bug verification will focus on two sides. 1. oc cluster up should work well with asb, and provision/deprovision/bind/undind/update a serviceinstance should succeed. 2. All updated(rebuild) APB images should work well in openshift ansible env, and no regression issue. I was trying to double check our changes in oc cluster up env. But "cannot setup a cluster while enalbe service-catalog and automation-service-broker by oc cluster up", refer to bug https://bugzilla.redhat.com/show_bug.cgi?id=1624320 John, Verification in oc cluster up env is blocking by another bug https://bugzilla.redhat.com/show_bug.cgi?id=1624320 (target release is 3.11.z), could we change the target release to 3.11.z either? Furthermore, regression test in openshift ansible env is on going. I will add comments for test result later. Jason, could you help to provide response for comment 6? Thanks. Q: Verification in oc cluster up env is blocking by another bug https://bugzilla.redhat.com/show_bug.cgi?id=1624320 (target release is 3.11.z), could we change the target release to 3.11.z either? Aligning to 3.11.z as oc cluster up env is currently broken and blocked by bug 1624320 which is blocked by bug 1607913 The root issue looks to be cert signing is broken with oc cluster up, tracked by bug 1607913 An upstream PR is being worked to address here: https://github.com/openshift/origin/pull/20760 I think this should be testable now. https://github.com/openshift/origin/pull/20868 was merged for 3.11 and appears to fix the cert problems. Relate code was merged in v3.11.0-0.29.0 in downstream. The latest puddle of downstream is v3.11.0-0.28.0 Waiting image ready for test. Double checked with latest oc, test Failed although https://github.com/openshift/origin/pull/20868 was merged in v3.11.0-0.29.0 and later, the original issue still exist. $ oc version oc v3.11.0-0.32.0 kubernetes v1.11.0+d4cacc0 features: Basic-Auth GSSAPI Kerberos SPNEGO Server https://127.0.0.1:8443 kubernetes v1.11.0+d4cacc0 Command: $ oc cluster up --enable='*,service-catalog,template-service-broker' --image='brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/openshift3/ose-${component}:${version}' Can you explain which original image still exist? This BZ was opened for the /version/openshift api going away and the APB's needing to be updated, but you pointed at a BZ for the cert signer operator. As mentioned in https://bugzilla.redhat.com/show_bug.cgi?id=1624320 we're not seeing problems with oc cluster up anymore. Can you review my two comments there and trying running oc cluster up again. If that or something else doesn't work can you please provide more detail? We are waiting for clarification from developer, and will double check later. Please refer to comment 7, comment 8, comment 9 and comment 10 in BZ https://bugzilla.redhat.com/show_bug.cgi?id=1624320 Moving status to VERIFIED since ASB/APBs work well both in oc cluster up and openshift ansible env. oc v3.11.0-0.32.0 Closing bugs that were verified and targeted for GA but for some reason were not picked up by errata. This bug fix should be present in current 3.11 release content. |