Package approved.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "*No copyright* CC by-sa (v3.0)", "Unknown or generated". 89
     files have unknown license. Detailed output of licensecheck in
     /home/bob/packaging/review/lxqt-themes/review-lxqt-
     themes/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/lxqt/themes/light
     /spacer-plugin(lxqt-common), /usr/share/lxqt/themes/ambiance/spacer-
     plugin(lxqt-common), /usr/share/lxqt/themes/dark(lxqt-common),
     /usr/share/lxqt/themes/light(lxqt-common),
     /usr/share/lxqt/themes/frost(lxqt-common), /usr/share/lxqt/themes/kde-
     plasma(lxqt-common), /usr/share/lxqt/themes/light/lxqt-runner(lxqt-
     common), /usr/share/lxqt/graphics(lxqt-common),
     /usr/share/lxqt/themes/ambiance(lxqt-common), /usr/share/lxqt/themes
     /kde-plasma/spacer-plugin(lxqt-common), /usr/share/lxqt/themes/frost
     /lxqt-runner(lxqt-common), /usr/share/lxqt/themes/dark/calendar-popup
     (lxqt-common), /usr/share/lxqt/themes/ambiance/lxqt-runner(lxqt-
     common), /usr/share/lxqt/themes/kde-plasma/lxqt-notificationd(lxqt-
     common), /usr/share/lxqt/themes/frost/volume-plugin(lxqt-common),
     /usr/share/lxqt/themes/dark/lxqt-notificationd(lxqt-common),
     /usr/share/lxqt/themes/frost/calendar-popup(lxqt-common),
     /usr/share/lxqt/themes/dark/lxqt-runner(lxqt-common),
     /usr/share/lxqt/themes/frost/spacer-plugin(lxqt-common),
     /usr/share/lxqt/themes/dark/spacer-plugin(lxqt-common),
     /usr/share/lxqt/themes/light/lxqt-lightdm-greeter(lxqt-common),
     /usr/share/lxqt/themes/system(lxqt-common),
     /usr/share/lxqt/themes/system/spacer-plugin(lxqt-common),
     /usr/share/lxqt/themes/ambiance/lxqt-notificationd(lxqt-common),
     /usr/share/lxqt/themes(lxqt-common), /usr/share/lxqt/themes/light
     /lxqt-panel(lxqt-common), /usr/share/lxqt/themes/kde-plasma/lxqt-
     runner(lxqt-common)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: lxqt-themes-0.13.0-3.fc30.noarch.rpm
          lxqt-themes-0.13.0-3.fc30.src.rpm
lxqt-themes.noarch: W: spelling-error %description -l en_US kde -> ode, deck
lxqt-themes.src: W: spelling-error %description -l en_US kde -> ode, deck
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/lxqt-themes

Why not use the new sources in lxqt-common? For reasons, see:
https://bugzilla.redhat.com/show_bug.cgi?id=1621317#c2
https://bugzilla.redhat.com/show_bug.cgi?id=1621317#c4

What to do if upstream decides to use new project names with another major version bump, again?

> The reviewer of the package MUST explicitly acknowledge this fact,
> and check the package for the proper Obsoletes and Provides (see the naming
> guidelines for more information.) They MUST document in the review request
> that they have done so.
https://fedoraproject.org/wiki/Package_Renaming_Process#Re-review_required

Please be aware that you would never be allowed to remove the following lines:
> # The themes were essential part of the previous lxqt-common package which
> # no longer exists. Therefore we obsolete and provide it here:
> Provides:       lxqt-common = %{version}-%{release}
> Obsoletes:      lxqt-common < 0.12.0
> # The old name for the theme subpackage was lxqt-theme
> Provides:       lxqt-theme = %{version}-%{release}
> Obsoletes:      lxqt-theme < 0.12.0

In other words, this request explicitly enforces me as the (previous) maintainer to retire lxqt-common. Maybe it would have been nice to ask me before approval.

OK, lxqt-common is now orphaned. At least for now, someone else could retire it when lxqt-themes is fully imported.

I didn't check lxqt-common, I assumed OP had retired it himself or was working to retire it.

You're both members of the LXQT SIG, aren't SIG supposed to discuss the changes they want to apply? Please resolve this before proposing Review Request.

(In reply to Robert-André Mauchin from comment #7)
> You're both members of the LXQT SIG, aren't SIG supposed to discuss the
> changes they want to apply? Please resolve this before proposing Review
> Request.

No. The problem started with an old maintainer leaving the SIG without any announcement, then I became the new maintainer of lxqt-common after an non-responsive request, after that another new maintainer for lxqt-theme was found.

It's the job of the reviewer to validate. You should have asked the SIG then if you think SIG is responsible for lxqt-common.

Anyways, lxqt-common is actually not my problem any more, feel free to complete the import of lxqt-theme and then correctly retire lxqt-common.

https://bugzilla.redhat.com/show_bug.cgi?id=1621317#c6

Hi both,

(In reply to Raphael Groner from comment #8)
> No. The problem started with an old maintainer leaving the SIG without any
> announcement, then I became the new maintainer of lxqt-common after an
> non-responsive request, after that another new maintainer for lxqt-theme was
> found.

Well I jumped in just because I need the newer libqtxdg, and then I realized lxqt* depends on it and seems haven't been updated for a long time, then I decide to also fix the lxqt* packages. I'm not aware of some of the background information, to be honest.

> Anyways, lxqt-common is actually not my problem any more, feel free to
> complete the import of lxqt-theme and then correctly retire lxqt-common.

As it's already orphaned, I will fix the comps first to make sure the spin generates as expected, and then check if there are more things to do with lxqt-common.

Meanwhile, this is built.