Created attachment 1478943 [details] Sample C program which call history API Description of problem: If requested start time and end time doesn't fall into first HTIME file, then history API fails even though continuous changelogs are avaiable for the requested range in other HTIME files. This is induced by changelog disable and enable which creates fresh HTIME index file. Version-Release number of selected component (if applicable): mainline How reproducible: Always Steps to Reproduce: 1. Setup gluster volume and let the I/O happen 2. Enable changelog 3. sleep for some time 4. Disable changelog 5. sleep for sometime 6. Enable changelog 7. Use the sample c program attached to query history API with start time after step 6 Actual results: History fails Expected results: History API should not fail if continuous changelogs are available even if it's second HTIME file. Additional info:
Created attachment 1478945 [details] Header file for the C program Steps to run the program. 1. Place both header file and C program attached in a directory 2. Compile gcc -o get-history get-history.c -lgfchangelog 3. Run get-history <start-time> <end-time>
REVIEW: https://review.gluster.org/21016 (libgfchangelog: Fix history changelog) posted (#1) for review on master by Kotresh HR
COMMIT: https://review.gluster.org/21016 committed in master by "Amar Tumballi" <amarts> with a commit message- libgfchangelog: Fix changelog history API Problem: If requested start time and end time doesn't fall into first HTIME file, then history API fails even though continuous changelogs are avaiable for the requested range in other HTIME files. This is induced by changelog disable and enable which creates fresh HTIME index file. Cause and Analysis: Each HTIME index file represents the availability of continuous changelogs. If changelog is disabled and enabled, a new HTIME index file is created represents non availability of continuous changelogs. So as long as the requested start and end falls into single HTIME index file and not across, history API should succeed. But History API checks for the changelogs only in first HTIME index file and errors out if not available. Fix: Check in all HTIME index files for availability of continuous changelogs for requested change. fixes: bz#1622549 Change-Id: I80eeceb5afbd1b89f86a9dc4c320e161907d3559 Signed-off-by: Kotresh HR <khiremat>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-5.0, please open a new bug report. glusterfs-5.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://lists.gluster.org/pipermail/announce/2018-October/000115.html [2] https://www.gluster.org/pipermail/gluster-users/