Description of problem: We have a daily job which analyzes the GlusterFS source code, and the results are posted @ https://build.gluster.org/job/clang-scan/437/clangScanBuildBugs/ Note that daily results are different, and hence, recommend looking at https://build.gluster.org/job/clang-scan/ & pick the latest from the jobs. (Above, 437 is the latest job number, and can change when you look at the bug). Goal is to keep it as close to 0, and as of now, we have 151 issues. Plan is to keep refreshing the list of known clang-scan issues in the spreadsheet below, every 15 days: https://docs.google.com/spreadsheets/d/1Wmx3C5IhZ89X_mITGQIbWZUtiXWN_taEZmRyI6WM5r0/edit?usp=sharing One can add their name in the Owner field and solve the issues, so that there is no duplicate efforts. Version-Release number of selected component (if applicable): master branch Actual results: 151 issues reported Expected results: 130 - 1st Sept ~50 - 1st Oct ~0 - 1st Nov
Update: The valid URL all the time is: https://build.gluster.org/job/clang-scan/lastCompletedBuild/clangScanBuildBugs/
REVIEW: https://review.gluster.org/21025 (clang-scan: fix multiple issues) posted (#1) for review on master by Amar Tumballi
COMMIT: https://review.gluster.org/21025 committed in master by "Amar Tumballi" <amarts> with a commit message- clang-scan: fix multiple issues * Buffer overflow issue in glusterfsd * Null argument passed to function expecting non-null (event-epoll) * Make sure the op_ret value is set in macro (posix) Updates: bz#1622665 Change-Id: I32b378fc40a5e3ee800c0dfbc13335d44c9db9ac Signed-off-by: Amar Tumballi <amarts>
REVIEW: https://review.gluster.org/21129 (Resolving the issue of Dereferencing a Null pointer) posted (#1) for review on master by
REVIEW: https://review.gluster.org/21134 (glusterd: NULL pointer dereferencing clang fix) posted (#5) for review on master by Sheetal Pamecha
REVIEW: https://review.gluster.org/21143 (glusterd: NULL pointer dereferencing clang fix) posted (#1) for review on master by Shwetha K Acharya
COMMIT: https://review.gluster.org/21134 committed in master by "Atin Mukherjee" <amukherj> with a commit message- glusterd: NULL pointer dereferencing clang fix Added ternary operator to avoid NULL pointer dereferencing Updates: bz#1622665 Change-Id: I4b970176b6b555c2eda1da2848c493e45b1e4217 Signed-off-by: Sheetal Pamecha <sheetal.pamecha08>
COMMIT: https://review.gluster.org/21129 committed in master by "Atin Mukherjee" <amukherj> with a commit message- glusterd: NULL pointer dereferencing clang fix problem: NULL point dereferencing solution: Adding a conditional statement before and then dereferencing it. Updates: bz#1622665 Change-Id: I562ca90aebf2a4882cfea10114a90364d9ef1996 Signed-off-by: Harpreet Lalwani <hlalwani>
REVIEW: https://review.gluster.org/21156 (glusterd: NULL pointer dereferencing clang Fix) posted (#1) for review on master by Harpreet Kaur Lalwani
COMMIT: https://review.gluster.org/21156 committed in master by "Atin Mukherjee" <amukherj> with a commit message- glusterd: NULL pointer dereferencing clang Fix Added ternary operator to avoid NULL pointer dereferencing Updates: bz#1622665 Change-Id: I855f6caf720b28af1564898d75c6c965bcc58c5c Signed-off-by: Harpreet Lalwani <hlalwani>
COMMIT: https://review.gluster.org/21143 committed in master by "Amar Tumballi" <amarts> with a commit message- protocol/server: NULL pointer dereferencing clang fix Problem: Access to field fop_length results in null pointer dereferencing. Solution: Added condition checks fix the issue. Change-Id: Id408e3ac62ea9574f0cd9aecce5434add09eb7d0 Updates: bz#1622665 Signed-off-by: Shwetha K Acharya <sacharya>
REVIEW: https://review.gluster.org/21199 (glusterd: NULL pointer dereferencing clang Fix) posted (#1) for review on master by Harpreet Kaur Lalwani
REVIEW: https://review.gluster.org/21204 (nfs3: NULL pointer dereferencing clang fix) posted (#1) for review on master by Shwetha K Acharya
REVIEW: https://review.gluster.org/21205 (inode: NULL pointer dereferencing clang fix) posted (#1) for review on master by Iraj Jamali
REVIEW: https://review.gluster.org/21207 (ctr: NULL pointer dereferencing clang fix) posted (#1) for review on master by Sheetal Pamecha
COMMIT: https://review.gluster.org/21205 committed in master by "Niels de Vos" <ndevos> with a commit message- libglusterfs: NULL pointer dereferencing clang fix Problem: trav could be NULL. Solution: Adding a check to avoid clang error. Updates: bz#1622665 Change-Id: If26be82edea5e33c2356cea3769496f1cbd3774c Signed-off-by: Iraj Jamali <ijamali>
COMMIT: https://review.gluster.org/21199 committed in master by "Amar Tumballi" <amarts> with a commit message- Quota: NULL pointer dereferencing clang Fix Added ternary operator to avoid NULL pointer dereferencing Updates: bz#1622665 Change-Id: I903ec1973fd4bb6473d16e2680bd86ac3a20e093 Signed-off-by: Harpreet Lalwani <hlalwani>
COMMIT: https://review.gluster.org/21204 committed in master by "Amar Tumballi" <amarts> with a commit message- nfs/server: NULL pointer dereferencing clang fix Added some condition checks in nfs3.c and nlm4.c Updates: bz#1622665 Change-Id: Ia10b8fff14f651df1360c9bb79d4476b282f54b5 Signed-off-by: Shwetha Acharya <sacharya>
COMMIT: https://review.gluster.org/21207 committed in master by "Amar Tumballi" <amarts> with a commit message- ctr: NULL pointer dereferencing clang fix Replaced this->name with "ctr" Updates: bz#1622665 Change-Id: I49af42a5d77c98ffb34224c8800757b8986012ea Signed-off-by: Sheetal Pamecha <sheetal.pamecha08>
REVIEW: https://review.gluster.org/21255 (mgmt/glusterd: NULL pointer dereferencing clang fix) posted (#1) for review on master by Shwetha K Acharya
REVIEW: https://review.gluster.org/21257 (features/locks: NULL pointer deferencing clang fix) posted (#1) for review on master by Iraj Jamali
REVIEW: https://review.gluster.org/21258 (features/compress: NULL pointer dereferencing clang fix) posted (#1) for review on master by Harpreet Kaur Lalwani
REVIEW: https://review.gluster.org/21260 (cluster/ec: variable-length array (VLA) declaration clang fix) posted (#1) for review on master by Sheetal Pamecha
REVIEW: https://review.gluster.org/21261 (mgmt/glusterd: NULL pointer dereferencing clang fix) posted (#1) for review on master by Iraj Jamali
REVIEW: https://review.gluster.org/21273 (dht: Coverity fixes) posted (#1) for review on master by Harpreet Kaur Lalwani
REVIEW: https://review.gluster.org/21275 (cluster/ec: NULL pointer deferencing clang fix) posted (#1) for review on master by Sheetal Pamecha
REVIEW: https://review.gluster.org/21274 (mgmt/glusterd: NULL pointer deferencing clang fix) posted (#3) for review on master by Iraj Jamali
COMMIT: https://review.gluster.org/21255 committed in master by "Atin Mukherjee" <amukherj> with a commit message- mgmt/glusterd: NULL pointer dereferencing clang fix Added a condition check to resolve the issue Change-Id: I1954e91f7487c052caf5cf98c954d204242f0af9 Updates: bz#1622665 Signed-off-by: Shwetha Acharya <sacharya>
COMMIT: https://review.gluster.org/21257 committed in master by "Amar Tumballi" <amarts> with a commit message- features/locks: NULL pointer deferencing clang fix Added checks to avoid NULL pointer dereferencing Updates: bz#1622665 Change-Id: I8e441c2931f406a6012e418127550bdf454a599a Signed-off-by: Iraj Jamali <ijamali>
COMMIT: https://review.gluster.org/21260 committed in master by "Amar Tumballi" <amarts> with a commit message- cluster/ec: variable-length array (VLA) declaration clang fix Problem: variable-length array size becomes zero Modified array size to size+1 while declaring Updates: bz#1622665 Change-Id: I98ee8447c87f37c36c49f50058292e8c1757a1f9 Signed-off-by: Sheetal Pamecha <sheetal.pamecha08>
REVIEW: https://review.gluster.org/21291 (cluster/ec: NULL pointer deferencing clang fix) posted (#1) for review on master by Sheetal Pamecha
REVIEW: https://review.gluster.org/21293 (nfs/server: NULL pointer dereferencing clang fix) posted (#1) for review on master by Iraj Jamali
REVIEW: https://review.gluster.org/21310 (features/bit-rot: NULL pointer deferencing clang fix) posted (#1) for review on master by Sheetal Pamecha
REVIEW: https://review.gluster.org/21311 (mgmt/glusterd: NULL pointer dereferencing clang fix) posted (#1) for review on master by Shwetha K Acharya
COMMIT: https://review.gluster.org/21274 committed in master by "Atin Mukherjee" <amukherj> with a commit message- mgmt/glusterd: NULL pointer deferencing clang fix Changed this->name to "glusterd" Updates: bz#1622665 Change-Id: Ic8ce428cefd6a5cecf5547769d8b13f530065c56 Signed-off-by: Iraj Jamali <ijamali>
REVIEW: https://review.gluster.org/21261 (mgmt/glusterd: NULL pointer dereferencing clang fix) posted (#4) for review on master by Atin Mukherjee
REVIEW: https://review.gluster.org/21342 (libglusterfs: NULL pointer dereferencing clang fix) posted (#1) for review on master by Iraj Jamali
REVIEW: https://review.gluster.org/21344 (cluster/dht: NULL pointer dereferencing clang fix) posted (#1) for review on master by Harpreet Kaur Lalwani
REVIEW: https://review.gluster.org/21258 (features/compress: NULL pointer dereferencing clang fix) posted (#6) for review on master by Amar Tumballi
COMMIT: https://review.gluster.org/21310 committed in master by "Kotresh HR" <khiremat> with a commit message- features/bit-rot: NULL pointer deferencing clang fix Problem: local could be NULL Added condition checks to address this issue Updates: bz#1622665 Change-Id: I7be7dacc5386a77441385240b43f22d85074b69d Signed-off-by: Sheetal Pamecha <sheetal.pamecha08>
REVIEW: https://review.gluster.org/21365 (rpc/rpc-lib: Uninitialized argument value of a function) posted (#1) for review on master by Harpreet Kaur Lalwani
REVIEW: https://review.gluster.org/21369 (Argument with 'nonnull' attribute passed null) posted (#1) for review on master by Iraj Jamali
REVIEW: https://review.gluster.org/21381 (mgmt/glusterd: clang fix) posted (#1) for review on master by Iraj Jamali
COMMIT: https://review.gluster.org/21342 committed in master by "Niels de Vos" <ndevos> with a commit message- libglusterfs: NULL pointer dereferencing clang fix Avoided NULL pointer dereferencing by doing GF_VALIDATE_OR_GOTO for rvec Updates: bz#1622665 Change-Id: I650e0203796dd705d79060f9506fc6c559b30f56 Signed-off-by: Iraj Jamali <ijamali>
REVIEW: https://review.gluster.org/21393 (performance/write-behind: NULL pointer passed to a nonnull parameter) posted (#1) for review on master by Shwetha K Acharya
REVIEW: https://review.gluster.org/21395 (libglusterfs: fix log message in options.c) posted (#1) for review on master by Sheetal Pamecha
COMMIT: https://review.gluster.org/21393 committed in master by "Shwetha K Acharya" <shwetha174> with a commit message- performance/write-behind: NULL pointer passed to a nonnull parameter Problem: wb_directory_inode->lock can be null. Solution: added a condition, if(!wb_directory_inode->lock.spinlock) to address the issue (checked one of the attributes of union lock to ensure that union is not null). Updates: bz#1622665 Change-Id: I0749ee16aa2c23f51d4b4c7b0979d494bcd4d90e Signed-off-by: Shwetha Acharya <sacharya>
COMMIT: https://review.gluster.org/21311 committed in master by "Atin Mukherjee" <amukherj> with a commit message- mgmt/glusterd: NULL pointer dereferencing clang fix Problem: dereferencing of this->name; volinfo and xl can be null. Solution: Replaced this->name with apropriate names in few places, added a null check to avoid dereferencing of volinfo, and introduced a goto out statement, such that null pointer value is not passed to the function volgen_xlator_link when xl becomes NULL. Updates: bz#1622665 Change-Id: I77616bd23f58328cb6dbe681914a028991d49abb Signed-off-by: Shwetha Acharya <sacharya>
COMMIT: https://review.gluster.org/21381 committed in master by "Atin Mukherjee" <amukherj> with a commit message- mgmt/glusterd: clang fix Argument with 'nonnull' attribute passed null. Added checks to avoid the issues. Updates: bz#1622665 Change-Id: I0dba1185cee5baba3c124d687560a06fe182381e Signed-off-by: Iraj Jamali <ijamali>
REVISION POSTED: https://review.gluster.org/21395 (libglusterfs: fix log message in options.c) posted (#3) for review on master by Sheetal Pamecha
COMMIT: https://review.gluster.org/21369 committed in master by "Amar Tumballi" <amarts> with a commit message- performance/nl-cache: clang fix Argument with 'nonnull' attribute passed null. Adding a check to avoid the issue. Updates: bz#1622665 Change-Id: I1d3a166e154a51da59bebb93a49f5174e593c98e Signed-off-by: Iraj Jamali <ijamali>
COMMIT: https://review.gluster.org/21275 committed in master by "Xavi Hernandez" <xhernandez> with a commit message- cluster/ec: NULL pointer deferencing clang fix Removing VALIDATE_OR_GOTO check on "this" Updates: bz#1622665 Change-Id: Ic7cffbb697da814f835d0ad46e25256da6afb406 Signed-off-by: Sheetal Pamecha <sheetal.pamecha08>
COMMIT: https://review.gluster.org/21365 committed in master by "Raghavendra G" <rgowdapp> with a commit message- rpc/rpc-lib: Uninitialized argument value of a function trav->saved_at.tv_sec is not initialized. Calling "list_empty" function before initializing "trav". Updates: bz#1622665 Change-Id: Ib5c2703a07a9c56ccd115001aca500f7a23c4a2e Signed-off-by: Harpreet Lalwani <hlalwani>
REVIEW: https://review.gluster.org/21466 (posix: Null pointer dereferencing clang fix) posted (#1) for review on master by Harpreet Kaur Lalwani
REVIEW: https://review.gluster.org/21467 (glusterfsd: NULL pointer dereferencing clang fix) posted (#1) for review on master by Iraj Jamali
REVIEW: https://review.gluster.org/21468 (rpc-transport/socket: NULL pointer dereferencing clang fix) posted (#1) for review on master by Shwetha K Acharya
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-5.0, please open a new bug report. glusterfs-5.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://lists.gluster.org/pipermail/announce/2018-October/000115.html [2] https://www.gluster.org/pipermail/gluster-users/
COMMIT: https://review.gluster.org/21469 committed in master by "Amar Tumballi" <amarts> with a commit message- features/namespace: NULL pointer deferencing clang fix Removed VALIDATE_OR_GOTO check on "this" Updates: bz#1622665 Change-Id: Ie0d74525901ebf9daa1a5e788a035db6dc5d8c06 Signed-off-by: Sheetal Pamecha <sheetal.pamecha08>
REVIEW: https://review.gluster.org/21493 (statedump: fix clang null dereference error) posted (#1) for review on master by Amar Tumballi
COMMIT: https://review.gluster.org/21493 committed in master by "Amar Tumballi" <amarts> with a commit message- statedump: fix clang null dereference error ctx->active can be null, and is checked elsewhere in the same function. In another case, where 'ctx->active' gets dereferenced, it needs to be validated before the loop is hit. Updates: bz#1622665 Change-Id: I4ec917e96c0756586fc7a74c76848bb9589a0293 Signed-off-by: Amar Tumballi <amarts>
COMMIT: https://review.gluster.org/21466 committed in master by "Amar Tumballi" <amarts> with a commit message- posix: Null pointer dereferencing clang fix Added a check for "top" Updates: bz#1622665 Change-Id: I354fdc7150b2f1eb452702ddb653e2d6ed609c10 Signed-off-by: Harpreet Lalwani <hlalwani>
REVIEW: https://review.gluster.org/21468 (rpc-transport/socket: NULL pointer dereferencing clang fix) posted (#2) for review on master by Amar Tumballi
REVIEW: https://review.gluster.org/21344 (cluster/dht: NULL pointer dereferencing clang fix) posted (#8) for review on master by N Balachandran
REVIEW: https://review.gluster.org/21467 (glusterfsd: NULL pointer dereferencing clang fix) posted (#2) for review on master by Amar Tumballi
REVIEW: https://review.gluster.org/21755 (clang: Fix clang warnings in snapview-server.c) posted (#1) for review on master by Shyamsundar Ranganathan
REVIEW: https://review.gluster.org/21769 (rpc-transport/socket: NULL pointer dereferencing clang fix) posted (#1) for review on master by Sheetal Pamecha
REVIEW: https://review.gluster.org/21770 (clang: Fix io-stats.c NULL pointer issue reported by clang) posted (#1) for review on master by Shyamsundar Ranganathan
REVIEW: https://review.gluster.org/21770 (clang: Fix io-stats.c NULL pointer issue reported by clang) posted (#2) for review on master by Amar Tumballi
REVIEW: https://review.gluster.org/21795 (libglusterfs: fix 32-bit-build-smoke warnings) posted (#1) for review on master by Iraj Jamali
REVIEW: https://review.gluster.org/21769 (rpc-transport/socket: NULL pointer dereferencing clang fix) posted (#4) for review on master by Amar Tumballi
REVIEW: https://review.gluster.org/21842 (core: fix null pointer dereference of 'refcount') posted (#1) for review on master by Rinku Kothiya
REVIEW: https://review.gluster.org/21840 (cli: variable-length array declaration clang fix) posted (#1) for review on master by Sheetal Pamecha
REVIEW: https://review.gluster.org/21851 (clang: Fix various missing checks for empty list) posted (#1) for review on master by Shyamsundar Ranganathan
REVIEW: https://review.gluster.org/21853 (cluster/ec: NULL pointer deferencing clang fix) posted (#1) for review on master by Sheetal Pamecha
REVIEW: https://review.gluster.org/21851 (clang: Fix various missing checks for empty list) posted (#2) for review on master by Amar Tumballi
REVIEW: https://review.gluster.org/21853 (cluster/ec: NULL pointer deferencing clang fix) posted (#2) for review on master by Amar Tumballi
REVIEW: https://review.gluster.org/21840 (cli: variable-length array declaration clang fix) posted (#7) for review on master by Amar Tumballi
REVIEW: https://review.gluster.org/21869 (dht: Fix clang warnings in dht-common.c) posted (#1) for review on master by Shyamsundar Ranganathan
REVIEW: https://review.gluster.org/21869 (dht: Fix clang warnings in dht-common.c) posted (#2) for review on master by Amar Tumballi
REVIEW: https://review.gluster.org/21880 (rdma: fix possible buffer overflow) posted (#1) for review on master by Rinku Kothiya
REVIEW: https://review.gluster.org/21880 (rdma: fix possible buffer overflow) posted (#3) for review on master by mohammed rafi kc
REVIEW: https://review.gluster.org/21918 (fix python-lint warnings) posted (#1) for review on master by Sheetal Pamecha
REVIEW: https://review.gluster.org/21919 (mgmt/glusterd: fix clang warning) posted (#1) for review on master by Sheetal Pamecha
REVIEW: https://review.gluster.org/21953 (glusterd: NULL pointer dereferencing clang fix) posted (#1) for review on master by Sheetal Pamecha
REVIEW: https://review.gluster.org/21954 (multiple-files: clang-scan fixes) posted (#1) for review on master by Amar Tumballi
REVIEW: https://review.gluster.org/21919 (mgmt/glusterd: fix clang warning) posted (#3) for review on master by Amar Tumballi
REVIEW: https://review.gluster.org/21953 (glusterd: NULL pointer dereferencing clang fix) posted (#2) for review on master by Amar Tumballi
REVIEW: https://review.gluster.org/21954 (multiple-files: clang-scan fixes) posted (#3) for review on master by Amar Tumballi
REVIEW: https://review.gluster.org/21795 (fix 32-bit-build-smoke warnings) posted (#9) for review on master by Amar Tumballi
REVIEW: https://review.gluster.org/22775 (across: clang-scan: fix NULL dereferencing warnings) posted (#1) for review on master by Amar Tumballi
REVIEW: https://review.gluster.org/22775 (across: clang-scan: fix NULL dereferencing warnings) merged (#3) on master by Amar Tumballi
REVIEW: https://review.gluster.org/22863 (clang-scan: resolve warning) merged (#2) on master by Amar Tumballi
REVIEW: https://review.gluster.org/22959 (glusterd: fix clang scan defects) posted (#1) for review on master by Atin Mukherjee
REVIEW: https://review.gluster.org/22959 (glusterd: fix clang scan defects) merged (#2) on master by Amar Tumballi
This bug is moved to https://github.com/gluster/glusterfs/issues/1096, and will be tracked there from now on. Visit GitHub issues URL for further details