Bug 1622957 - [geo-rep]: gfid-conflict-resolution config option is accepting any value instead of only boolean
Summary: [geo-rep]: gfid-conflict-resolution config option is accepting any value inst...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Gluster Storage
Classification: Red Hat Storage
Component: geo-replication
Version: rhgs-3.4
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
: RHGS 3.5.0
Assignee: Kotresh HR
QA Contact: Rahul Hinduja
URL:
Whiteboard:
Depends On:
Blocks: 1696807
TreeView+ depends on / blocked
 
Reported: 2018-08-28 09:05 UTC by Rahul Hinduja
Modified: 2019-10-30 12:20 UTC (History)
6 users (show)

Fixed In Version: glusterfs-6.0-1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-10-30 12:20:13 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2019:3249 0 None None None 2019-10-30 12:20:36 UTC

Description Rahul Hinduja 2018-08-28 09:05:12 UTC
Description of problem:
=======================

Bug 1622029 has introduced gfid-conflict-resolution option to handle gfid conflicts gracefully. This option is boolean and should accept only "1/0" , "enable/disable", "True/False", "On/Off". 

However, the option is accepting any values, for example: 

[root@rhsauto032 scripts]# gluster volume geo-replication Master rhsauto022::Slave config gfid-conflict-resolution
kadjkahkhfhf
[root@rhsauto032 scripts]# gluster volume geo-replication Master rhsauto022::Slave config gfid-conflict-resolution rahul
geo-replication config updated successfully
[root@rhsauto032 scripts]# gluster volume geo-replication Master rhsauto022::Slave config gfid-conflict-resolution
rahul
[root@rhsauto032 scripts]# gluster volume geo-replication Master rhsauto022::Slave config \!gfid-conflict-resolution
geo-replication config updated successfully
[root@rhsauto032 scripts]# gluster volume geo-replication Master rhsauto022::Slave config gfid-conflict-resolution
[root@rhsauto032 scripts]# 


In comparison to other config options, it is working differently. For example use_meta_volume config options bails out with wrong entries.

[root@rhsauto032 scripts]# gluster volume geo-replication Master rhsauto022::Slave config use_meta_volume 
true
[root@rhsauto032 scripts]# gluster volume geo-replication Master rhsauto022::Slave config use_meta_volume akhdkhfdakhf
Invalid value(akhdkhfdakhf) for option use_meta_volume
geo-replication command failed
[root@rhsauto032 scripts]# gluster volume geo-replication Master rhsauto022::Slave config use_meta_volume rahul
Invalid value(rahul) for option use_meta_volume
geo-replication command failed
[root@rhsauto032 scripts]# gluster volume geo-replication Master rhsauto022::Slave config use_meta_volume 
true
[root@rhsauto032 scripts]#


Version-Release number of selected component (if applicable):
=============================================================

glusterfs-geo-replication-3.12.2-18.el7rhgs.x86_64


How reproducible:
=================

Always


Steps to Reproduce:
===================
1. gluster volume geo-replication Master rhsauto022::Slave config gfid-conflict-resolution rahul


Actual results:
===============

Config is successful


Expected results:
=================

Config should fail to set

Comment 2 Aravinda VK 2018-11-19 06:56:17 UTC
Fix available upstream https://review.gluster.org/#/c/glusterfs/+/18257/

Comment 10 errata-xmlrpc 2019-10-30 12:20:13 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2019:3249


Note You need to log in before you can comment on or make changes to this bug.