Bug 1622972

I think it's caused by some optimizations in cdn-sync and certain attributes are not updated by default in the DB when changed. Also there is an --force-all-errata attribute that should fix all dates.

Actually this looks more like an issue with creating Sat 6 content ISOs.

If I download RHEL7 server updateinfo.xml from CDN today I can see
e.g. RHBA-2015:0738, RHSA-2015:0726 and RHBA-2015:0734 with '2015-03-26 00:00:00' timestamp (both in updateinfo and satellite db).



Anyway I've changed the code to update erratum if update date has changed.

Fix in spacewalk git 
commit 57cb53f70e2c9aaa5ffab06e4270c9068c854050
    1622972 - sync errata if update date has changed

Satellite fix

commit 383b0c9284028943fef44718cd5de483a25f08ff
    1622972 - sync errata if update date has changed

Syncing using the cdn-sync from the CDN works, and the "update_date" and "last_modified" fields are properly updated. 

There is a problem when using satellite-sync to import channel from content ISOs. I'm not quite sure if this is really connected to the current BZ. Only thing that points this way is the mention of 'last_modified' in the error messsage:

# satellite-sync -m .  -c rhel-x86_64-client-7
06:07:44 Red Hat Satellite - file-system synchronization
06:07:44    mp:  /root/dumps/extracted
06:07:44    db:  rhnuser/<password>@rhnschema
06:07:44 
06:07:44 Retrieving / parsing channel-families data
06:07:44 channel-families data complete
06:07:44 
06:07:44 Retrieving / parsing product names data
06:07:45 
06:07:45 Retrieving / parsing arches data
06:07:45 arches data complete
06:07:45 
06:07:45 Retrieving / parsing additional arches data
06:07:45 additional arches data complete
06:07:45 
06:07:45 Retrieving / parsing channel data
06:07:47    p = previously imported/synced channel
06:07:47    . = channel not yet imported/synced
06:07:47    base-channels:
06:07:47       p rhel-x86_64-client-7                     16179       full import from Fri Apr 20 11:52:11 2018
06:07:47 
06:07:47 Channel data complete
06:07:47 
06:07:47 Retrieving short package metadata (used for indexing)
06:07:47    Retrieving / parsing short package metadata: rhel-x86_64-client-7 (16179)
06:07:56 Diffing package metadata (what's missing locally?): rhel-x86_64-client-7
            ________________________________________
Diffing:    ######################################## - complete
06:08:18 
06:08:18 Downloading package metadata
+++ sending log as an email +++

SYNC ERROR: unhandled exception occurred:

(Check logs/email for potentially more detail)

TypeError("'NoneType' object is unsubscriptable",)
'NoneType' object is unsubscriptable

Exception reported from ibm-x3250m4-02.rhts.eng.bos.redhat.com
Time: Wed Oct 10 06:08:33 2018
Exception type <type 'exceptions.TypeError'>

Exception Handler Information
Traceback (most recent call last):
  File "/usr/bin/satellite-sync", line 138, in main
    return satsync.Runner().main()
  File "/usr/lib/python2.6/site-packages/spacewalk/satellite_tools/satsync.py", line 245, in main
    ret = method()
  File "/usr/lib/python2.6/site-packages/spacewalk/satellite_tools/satsync.py", line 351, in _step_download_packages
    return self.syncer.download_package_metadata()
  File "/usr/lib/python2.6/site-packages/spacewalk/satellite_tools/satsync.py", line 1163, in download_package_metadata
    missing_packages = self._missing_not_cached_packages()
  File "/usr/lib/python2.6/site-packages/spacewalk/satellite_tools/satsync.py", line 1153, in _missing_not_cached_packages
    or package_collection.get_package(pid)['last_modified']
TypeError: 'NoneType' object is unsubscriptable

Michal, should this error be considered a part of the current bug, or is it a new standalone bug?

Ok, I am unable to re-reproduce the issue in the c#5 now. After an off-line discussion with Michal we have decided to leave this as is, as the problem appeared in satellite-sync and not in the cdn-sync (which is the tool fixed in this BZ). Other than this, the last_modified date gets updated correctly on a CDN sync.

Fixed oracle failure in spacewalk git by
commit ca0553392f78a7842f167f79420e60497eb94d91
    1622972 - convert datetime in python
    otherwise postgresql and oracle need different selects/casts

backported to SATELLITE-5.8 as
commit ee12f9357b52c023976e0c628d7563157d416fd5
    1622972 - convert datetime in python

Re-verified on spacewalk-backend-2.5.3-172. Repo sync works on Oracle now.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3756