Bug 1623110 - g_strdup_printf warns on invalid format specifier with G_GUINT64_FORMAT on Win32
Summary: g_strdup_printf warns on invalid format specifier with G_GUINT64_FORMAT on Win32
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: mingw-glib2
Version: 29
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kalev Lember
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-08-28 13:33 UTC by Daniel Berrangé
Modified: 2019-01-22 17:41 UTC (History)
7 users (show)

Fixed In Version: mingw-glib2-2.58.2-1.fc29
Clone Of:
Environment:
Last Closed: 2019-01-22 17:41:58 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Daniel Berrangé 2018-08-28 13:33:08 UTC
Description of problem:
GLib2 2.57.0 introduced a regression in the printf functions causing compiler  warnings for any app that has  -Wformat enabled.

This is because the format annotation for g_strdup_printf() (and related functions) was changed from "printf" to "gnu_printf", but the G_GUINT64_FORMAT macro was left with the Microsoft format, instead of the GNU format.

This has been reported upstream and already fixed:

  https://gitlab.gnome.org/GNOME/glib/issues/1497

This request is just to ensure the patches get into rawhide and FEdora 29 mingw-glib2.

Possibly this will happen automatically next time you pull a pre-release snapshot of 2.57.x series

Note in the upstream bug, the maintainer recommended that we switch to using Meson instead of autotools for building glib, since meson is what upstream is actually testing and didn't suffer from this bug.

Version-Release number of selected component (if applicable):
mingw-glib2-2.57.2-1.fc29

Comment 1 Elliott Sales de Andrade 2018-09-19 19:26:04 UTC
According to koschei, this will break mingw-json-glib builds [1], but not yet since there's not been a new release.

[1] https://apps.fedoraproject.org/koschei/package/mingw-json-glib

Comment 2 Elliott Sales de Andrade 2019-01-08 05:07:10 UTC
This is okay in Rawhide now that it's bumped to 2.58.1, but still wrong in Fedora 29.

Comment 3 Kalev Lember 2019-01-08 09:09:51 UTC
Sorry, I missed this bug earlier. Let me do a 2.58.2 build for Fedora 29 now that it's out.

Comment 4 Fedora Update System 2019-01-08 09:11:12 UTC
mingw-glib2-2.58.2-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-a93c2b64d6

Comment 5 Fedora Update System 2019-01-10 22:14:41 UTC
mingw-glib2-2.58.2-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-a93c2b64d6

Comment 6 Fedora Update System 2019-01-22 17:41:58 UTC
mingw-glib2-2.58.2-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.