Bug 1623249 - chafa FTBFS with new ImageMagick update (6.9.10)
Summary: chafa FTBFS with new ImageMagick update (6.9.10)
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: chafa
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Miro Hrončok
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-08-28 20:17 UTC by Michael Cronenworth
Modified: 2018-12-25 10:10 UTC (History)
2 users (show)

Fixed In Version: chafa-1.0.1-1.fc30
Clone Of:
Environment:
Last Closed: 2018-12-25 10:10:25 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Michael Cronenworth 2018-08-28 20:17:16 UTC
Description of problem:
https://koji.fedoraproject.org/koji/taskinfo?taskID=29353804

Comment 1 Miro Hrončok 2018-08-28 21:26:28 UTC
chafa.c: In function 'process_image':
chafa.c:969:3: warning: #warning No valid MagickResizeImage detected. Trying four arguments. [-Wcpp]
 # warning No valid MagickResizeImage detected. Trying four arguments.
   ^~~~~~~
chafa.c:970:13: error: too few arguments to function 'MagickResizeImage'
             MagickResizeImage (wand, src_width, src_height, LanczosFilter);
             ^~~~~~~~~~~~~~~~~
In file included from /usr/include/ImageMagick-6/wand/MagickWand.h:91,
                 from chafa.c:30:
/usr/include/ImageMagick-6/wand/magick-image.h:275:3: note: declared here
   MagickResizeImage(MagickWand *,const size_t,const size_t,const FilterTypes,
   ^~~~~~~~~~~~~~~~~
chafa.c: In function 'auto_orient_image':
chafa.c:841:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
             MagickRotateImage (image, pwand, 180.0);
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chafa.c:842:9: note: here
         case BottomLeftOrientation:
         ^~~~
make[2]: *** [Makefile:688: chafa-chafa.o] Error 1



Do you know how to fix this or should I investigate?

Comment 2 Michael Cronenworth 2018-08-28 21:33:06 UTC
ImageMagick API has changed in 6.9.10. Looks like chafa needs to be updated to work with the new API.

Comment 3 Miro Hrončok 2018-08-28 22:36:12 UTC
That's clear. I was asking whether you know how to fix it (e.g. if you are familiar with the new API).

Comment 4 Michael Cronenworth 2018-08-29 01:47:15 UTC
Unfortunately I cannot find any API documentation on the change. The ChangeLog is not comprehensive.

Code repo: https://github.com/ImageMagick/ImageMagick6
IM6 website: https://legacy.imagemagick.org/script/index.php

I took a quick look at the code snippet you posted. The function call has not changed in IM6, but the configure tests in chafa are failing.

checking for 5-arg MagickResizeImage... no
checking for MagickAutoOrientImage... no

Previous builds had these passing:

checking for 5-arg MagickResizeImage... yes
checking for MagickAutoOrientImage... yes

If the configure tests are fixed the build should work.

Comment 5 Hans Petter Jansson 2018-12-24 23:38:45 UTC
Have you tried with Chafa version 1.0.1? It has several build fixes (specifically fixes for ImageMagick detection) relative to 0.9.0, which seems to be the failing version.

Comment 6 Miro Hrončok 2018-12-25 09:49:21 UTC
Thanks. It works.


Note You need to log in before you can comment on or make changes to this bug.