Bug 1623290 - Review Request: R-fontBitstreamVera - Fonts with 'Bitstream Vera Fonts' License
Summary: Review Request: R-fontBitstreamVera - Fonts with 'Bitstream Vera Fonts' License
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Iñaki Ucar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-08-28 23:34 UTC by Elliott Sales de Andrade
Modified: 2020-03-22 05:09 UTC (History)
2 users (show)

Fixed In Version: R-fontBitstreamVera-0.1.1-2.fc27
Clone Of:
Environment:
Last Closed: 2020-03-22 05:09:30 UTC
Type: ---
Embargoed:
i.ucar86: fedora-review+


Attachments (Terms of Use)

Description Elliott Sales de Andrade 2018-08-28 23:34:15 UTC
Spec URL: https://qulogic.fedorapeople.org//R-fontBitstreamVera.spec
SRPM URL: https://qulogic.fedorapeople.org//R-fontBitstreamVera-0.1.1-1.fc28.src.rpm

Description:
Provides fonts licensed under the 'Bitstream Vera Fonts' license for the
'fontquiver' package.

Comment 1 Elliott Sales de Andrade 2018-08-28 23:34:18 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=29356834

Comment 2 Iñaki Ucar 2018-08-30 08:50:17 UTC
Issues:
=======
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file COPYRIGHT.TXT is not marked as %license

This is under inst/fonts/bitstream-vera-fonts. And there are a couple of .TXT more there. I would remove them, as they serve no purpose.

Comment 3 Iñaki Ucar 2018-08-30 09:13:58 UTC
Also, I would remove the Makefile and the bitstream-vera-VERSION files under inst/fonts/.

Comment 4 Elliott Sales de Andrade 2018-08-30 22:56:01 UTC
Removed the extra files. I dropped COPYRIGHT.TXT because it is the same as LICENCE.

Spec URL: https://qulogic.fedorapeople.org/R-fontBitstreamVera.spec
SRPM URL: https://qulogic.fedorapeople.org/R-fontBitstreamVera-0.1.1-2.fc28.src.rpm

Comment 5 Iñaki Ucar 2018-08-31 08:24:11 UTC
Thanks, package approved.

- No relevant rpmlint errors or warnings.
- Requires, BuildRequires ok.
- Compatible license, license included.
- Files/dirs ok.
- Fonts unbundled, linking to system fonts.

Comment 6 Gwyn Ciesla 2018-08-31 13:02:35 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/R-fontBitstreamVera

Comment 7 Elliott Sales de Andrade 2020-03-22 05:09:30 UTC
This was built some time ago.


Note You need to log in before you can comment on or make changes to this bug.