Bug 1623295 - Review Request: R-fontLiberation - Liberation Fonts
Summary: Review Request: R-fontLiberation - Liberation Fonts
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Iñaki Ucar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-08-29 00:16 UTC by Elliott Sales de Andrade
Modified: 2020-03-22 05:09 UTC (History)
2 users (show)

Fixed In Version: R-fontLiberation-0.1.0-2.fc27
Clone Of:
Environment:
Last Closed: 2020-03-22 05:09:54 UTC
Type: ---
Embargoed:
i.ucar86: fedora-review+


Attachments (Terms of Use)

Description Elliott Sales de Andrade 2018-08-29 00:16:01 UTC
Spec URL: https://qulogic.fedorapeople.org//R-fontLiberation.spec
SRPM URL: https://qulogic.fedorapeople.org//R-fontLiberation-0.1.0-1.fc28.src.rpm

Description:
A placeholder for the Liberation fontset intended for the `fontquiver` package.
This fontset covers the 12 combinations of families (sans, serif, mono) and
faces (plain, bold, italic, bold italic) supported in R graphics devices.

Comment 1 Elliott Sales de Andrade 2018-08-29 00:22:18 UTC
koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=29357025

Comment 2 Iñaki Ucar 2018-08-30 09:11:21 UTC
The fedora-review tool is not complaining, but I would clean up several text files shipped under inst that serve no purpose:

- inst/fonts/Makefile
- inst/fonts/liberation-VERSION
- inst/fonts/liberation-fonts/AUTHORS
- inst/fonts/liberation-fonts/ChangeLog
- inst/fonts/liberation-fonts/LICENSE
- inst/fonts/liberation-fonts/README
- inst/fonts/liberation-fonts/TODO

The first two are used by the upstream maintainer to repackage the fonts.

Comment 3 Elliott Sales de Andrade 2018-08-31 08:44:25 UTC
OK, I removed some of the redundant files, but not all of them. Since this package is bundling the font, I left the documentation files but marked them as %doc.

Spec URL: https://qulogic.fedorapeople.org/R-fontLiberation.spec
SRPM URL: https://qulogic.fedorapeople.org/R-fontLiberation-0.1.0-2.fc28.src.rpm

Comment 4 Iñaki Ucar 2018-08-31 08:56:59 UTC
Ok, package approved.

- No relevant rpmlint errors or warnings.
- Requires, BuildRequires ok.
- Compatible license, license included.
- Files/dirs ok.
- Fonts cannot be unbundled (version not present in Fedora), Provides ok.

Comment 5 Gwyn Ciesla 2018-08-31 13:07:18 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/R-fontLiberation

Comment 6 Elliott Sales de Andrade 2020-03-22 05:09:54 UTC
This was built some time ago.


Note You need to log in before you can comment on or make changes to this bug.