Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1623447

Summary:	[downstream clone - 4.2.6] Pending change IO thread disable is not applied on shutdown
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	RHV bug bot <rhv-bugzilla-bot>
Component:	ovirt-engine	Assignee:	Arik <ahadas>
Status:	CLOSED ERRATA	QA Contact:	Liran Rotenberg <lrotenbe>
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	4.2.5	CC:	eheftman, lsurette, mavital, michal.skrivanek, mtessun, Rhev-m-bugs, sgratch, srevivo, tburke
Target Milestone:	ovirt-4.2.6	Keywords:	ZStream
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Previously, when the IO threads setting was disabled on a running virtual machine, after restarting the machine the setting was ignored and IO threads were enabled. In this release, the IO threads setting is now properly saved into a next-run configuration, and once disabled, it remains disabled after restarting the machine.	Story Points:	---
Clone Of:	1619474	Environment:
Last Closed:	2018-09-04 13:41:47 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1619474
Bug Blocks:

Description RHV bug bot 2018-08-29 11:56:25 UTC

+++ This bug is a downstream clone. The original bug is: +++
+++   bug 1619474 +++
======================================================================

Description of problem:

The VM is up and the user disables IO Threads and accepts this will be applied on next restart. But on next restart the old setting is still there.

Version-Release number of selected component (if applicable):
ovirt-engine-4.2.5.3-1.el7.noarch

How reproducible:
100%

Steps to Reproduce:
1. Power up the VM with IO threads enabled
2. Disable IO Threads, confirm Setting will be applied later (OK)
3. Shutdown the VM
4. Start the VM

Note: at item 2, if you click on edit again, the IO Thread setting is checked.

Actual results:
ovirt-engine-4.2.5.3-1.el7.noarch

Expected results:
IO Threads Disabled

Additional information:
The other way around (enabling IO threads) seem to work.

It seems to only update Rng(?) and Graphics(?) on shutdown.

2018-08-21 10:40:09,668+10 INFO  [org.ovirt.engine.core.bll.ProcessDownVmCommand] (EE-ManagedThreadFactory-engine-Thread-1632) [6e6432c9] Running command: ProcessDownVmCommand internal: true.
2018-08-21 10:40:09,893+10 INFO  [org.ovirt.engine.core.bll.UpdateVmCommand] (EE-ManagedThreadFactory-engine-Thread-1632) [53f4758c] Running command: UpdateVmCommand internal: true. Entities affected :  ID: 42100647-bc71-4633-bad9-8723449a8e24 Type: VMAction group EDIT_VM_PROPERTIES with role type USER
2018-08-21 10:40:09,927+10 INFO  [org.ovirt.engine.core.bll.UpdateRngDeviceCommand] (EE-ManagedThreadFactory-engine-Thread-1632) [2bbb4346] Running command: UpdateRngDeviceCommand internal: true. Entities affected :  ID: 42100647-bc71-4633-bad9-8723449a8e24 Type: VMAction group EDIT_VM_PROPERTIES with role type USER
2018-08-21 10:40:09,947+10 INFO  [org.ovirt.engine.core.bll.UpdateGraphicsDeviceCommand] (EE-ManagedThreadFactory-engine-Thread-1632) [1ce39d29] Running command: UpdateGraphicsDeviceCommand internal: true. Entities affected :  ID: 42100647-bc71-4633-bad9-8723449a8e24 Type: VMAction group EDIT_VM_PROPERTIES with role type USER
2018-08-21 10:40:09,976+10 INFO  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (EE-ManagedThreadFactory-engine-Thread-1632) [1ce39d29] EVENT_ID: SYSTEM_UPDATE_VM(253), VM CentOS configuration was updated by system.

(Originally by Germano Veit Michel)

Comment 1 RHV bug bot 2018-08-29 11:56:33 UTC

Sharon?

(Originally by michal.skrivanek)

Comment 3 RHV bug bot 2018-08-29 11:56:38 UTC

(In reply to Michal Skrivanek from comment #1)
> Sharon?

This is a regression in 4.2.5 due to patch [1]  which enabled IO threads as default for Server VM type.
The reason is that in case IO threads is disabled, it is not written/read by OvfReader.java and vmBase default value is used.
Up till 4.2.5 the default value was 0 and in mentioned patch [1] it was changed to 1.

[1] https://gerrit.ovirt.org/#/c/92776/

(Originally by Sharon Gratch)

Comment 5 RHV bug bot 2018-08-29 11:56:48 UTC

Verified on:
ovirt-engine-4.2.6.4-0.0.master.20180823141941.gitb3a5b18.el7.noarch

Steps of verification:
1. Create a new VM with IO-Threads enabled.
2. Start the VM.
3. Disable IO-Threads (confirm that the change require VM restart).
4. Restart the VM.
5. Check the VM IO-Threads.

Results:
The VM IO-Threads was changed and disabled.

(Originally by Liran Rotenberg)

Comment 6 RHV bug bot 2018-08-29 11:56:53 UTC

WARN: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[Found non-acked flags: '{'rhevm-4.2.z': '?'}', ]

For more info please contact: rhv-devops: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[Found non-acked flags: '{'rhevm-4.2.z': '?'}', ]

For more info please contact: rhv-devops

(Originally by rhv-bugzilla-bot)

Comment 7 Liran Rotenberg 2018-08-29 14:00:31 UTC

This patch already merged on the last 4.2.6 d/s build.

Verified on:
ovirt-engine-4.2.6.4-0.1.el7ev.noarch

Same steps as in comment #5

Comment 9 errata-xmlrpc 2018-09-04 13:41:47 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2623