Spec URL: https://sgallagh.fedorapeople.org/packagereview/python-click-man/python-click-man.spec SRPM URL: https://sgallagh.fedorapeople.org/packagereview/python-click-man/python-click-man-0.2.2-1.fc29.src.rpm Description: Automatically produces UNIX-style manual pages for Python applications that use Click for option handling. Fedora Account System Username: sgallagh
COPR build: https://copr.fedorainfracloud.org/coprs/sgallagh/mmdzanata/package/python-click-man/
I see URL can be defined here either as https://github.com/click-contrib/click-man or https://pypi.org/project/click-man/
(In reply to Parag Nemade from comment #2) > I see URL can be defined here either as > https://github.com/click-contrib/click-man > or > https://pypi.org/project/click-man/ Oops, I didn't notice that was missing. Fixing.
Now the standalone SPEC file doesn't match the one in the archive ;)
Stephen, You should enable the dependency generator for this package instead of manually tracking it. Just put the following at the top of your spec and Requires will be generated automatically based on setuptools data: %{?python_enable_dependency_generator}
(In reply to Neal Gompa from comment #5) > Stephen, > > You should enable the dependency generator for this package instead of > manually tracking it. > > Just put the following at the top of your spec and Requires will be > generated automatically based on setuptools data: > > %{?python_enable_dependency_generator} Thanks for the tip! I didn't know about that one. I generated this specfile originally with pyp2rpm (https://github.com/fedora-python/pyp2rpm) so maybe you could suggest using that as an enhancement?
Spec URL: https://sgallagh.fedorapeople.org/packagereview/python-click-man/python-click-man.spec SRPM URL: https://sgallagh.fedorapeople.org/packagereview/python-click-man/python-click-man-0.2.2-2.fc29.src.rpm I forgot to update the links.
Err, that last set didn't have the dep generator change yet. I'll get that done sometime today, but it shouldn't be a blocker to review, I don't think.
Spec URL: https://sgallagh.fedorapeople.org/packagereview/python-click-man/python-click-man.spec SRPM URL: https://sgallagh.fedorapeople.org/packagereview/python-click-man/python-click-man-0.2.2-3.fc29.src.rpm COPR Build: https://copr.fedorainfracloud.org/coprs/sgallagh/mmdzanata/build/792626/
* The same problem with %{description} as in mmdzanata. * It's also funny this one doesn't provide a manpage but given it's not your package... :) * mmdzanata BRs python?dist(setuptools) while this one python?-setuptools. It doesn't matter but I'm just commenting on the inconsistency in packaging. Just fix the description and we're good to go.
Spec URL: https://sgallagh.fedorapeople.org/packagereview/python-click-man/python-click-man.spec SRPM URL: https://sgallagh.fedorapeople.org/packagereview/python-click-man/python-click-man-0.2.2-4.fc29.src.rpm COPR Build: https://copr.fedorainfracloud.org/coprs/sgallagh/mmdzanata/build/793113/ Description is fixed and I made the setuptools BR consistent.
Ack. Approving.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-click-man
This package was approved and imported in repositories, but this review ticket was never closed. I'm closing it now.