Bug 1623616 - Review Request: fedora-messaging - Tools and APIs to make working with AMQP in Fedora easier
Summary: Review Request: fedora-messaging - Tools and APIs to make working with AMQP i...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-08-29 18:12 UTC by Jeremy Cline
Modified: 2019-08-20 10:01 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-08-20 10:01:55 UTC
Type: Bug
Embargoed:
ngompa13: fedora-review+

Attachments (Terms of Use)

Description Jeremy Cline 2018-08-29 18:12:47 UTC 
SRPM URL: https://jcline.fedorapeople.org/fedora-messaging-1.0.0-0.1.b1.fc28.src.rpm
Spec URL: https://jcline.fedorapeople.org/fedora-messaging.spec

FAS: jcline
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=29369233
Comment 1 Neal Gompa 2018-08-29 20:12:36 UTC 
Taking this review.
Comment 2 Jeremy Cline 2018-09-05 14:50:13 UTC 
Hi Neal, are you still planning on doing the review?
Comment 3 Neal Gompa 2018-09-05 15:09:49 UTC 
Yes, I am. Expect some comments shortly.
Comment 4 Neal Gompa 2018-09-05 23:27:27 UTC 
A couple of notes:

> Requires:       python3-%{pkgname} = %{version}

Please make this stricter. That is, use %version-%release instead of just %version.

> %{?python_enable_dependency_generator}

Please put this at the top of the spec to avoid potential quirkiness.
Comment 5 Neal Gompa 2018-09-06 00:09:19 UTC 
> %package     -n python3-%{pkgname}

The %python_provide boilerplate is missing for this subpackage.
Comment 6 Jeremy Cline 2018-09-07 18:30:10 UTC 
SRPM URL: https://jcline.fedorapeople.org/fedora-messaging-1.0.0-0.2.b1.fc28.src.rpm
Spec URL: https://jcline.fedorapeople.org/fedora-messaging.spec

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=29540459

All comments have been addressed.
Comment 7 Neal Gompa 2018-09-07 23:25:54 UTC 
Review notes:

* Package builds and installs correctly
* Package correctly identifies license and installs license file
* Package follows Fedora Packaging Guidelines
* Package follows Python packaging guidelines

PACKAGE APPROVED.
Comment 8 Igor Raits 2018-09-08 08:25:00 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/fedora-messaging
Note You need to log in before you can comment on or make changes to this bug.