Bug 162369 - undefined code
undefined code
Status: CLOSED UPSTREAM
Product: Fedora
Classification: Fedora
Component: libdv (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Warren Togami
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2005-07-03 08:00 EDT by David Binderman
Modified: 2007-11-30 17:11 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2005-07-03 22:52:26 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description David Binderman 2005-07-03 08:00:10 EDT
Description of problem:

I just tried to compile package libdv-0.103-4 from Redhat
Fedora Core development tree with the gcc 4.0.0 compiler and
the compiler flag -Wall.

The compiler said

encode.c:1754: warning: operation on 'i' may be undefined

The source code is

	dv_enc->img_y[i] = CLAMP(dv_enc->img_y[i++], -224, 214)

I agree with the compiler. Suggest rework code to avoid reading from
variable "i" at the same time as incrementing it.

Maybe 

	(dv_enc->img_y[i] = CLAMP( dv_enc->img_y[i], -224, 214)), ++i

is better code.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Warren Togami 2005-07-03 22:52:26 EDT
Could you please submit this to the upstream project?  It is not worth the
effort to fix trivial issues like this that seemingly have no security or even
functional impact.
Comment 2 David Binderman 2005-07-04 06:53:04 EDT
>Could you please submit this to the upstream project?  

Would like to be able to, but sorry I am unable.

Suggest either we forget about this trivial bug, or we can 
leave it hanging for someone else to pick up.
 

Note You need to log in before you can comment on or make changes to this bug.