Bug 1623737 - ceph-iscsi: clear internal lock state when path is revalidated
Summary: ceph-iscsi: clear internal lock state when path is revalidated
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Ceph Storage
Classification: Red Hat Storage
Component: iSCSI
Version: 3.1
Hardware: Unspecified
OS: Unspecified
unspecified
urgent
Target Milestone: rc
: 3.1
Assignee: Mike Christie
QA Contact: Madhavi Kasturi
URL:
Whiteboard:
: 1627613 (view as bug list)
Depends On:
Blocks: 1624093
TreeView+ depends on / blocked
 
Reported: 2018-08-30 05:06 UTC by Mike Christie
Modified: 2021-12-10 17:20 UTC (History)
8 users (show)

Fixed In Version: tcmu-runner-1.4.0-0.3.el7cp
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-09-26 18:24:01 UTC
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github open-iscsi tcmu-runner pull 471 0 None closed runner/rbd: misc implicit failover fixes 2020-07-09 18:36:08 UTC
Red Hat Issue Tracker RHCEPH-2691 0 None None None 2021-12-10 17:20:10 UTC
Red Hat Product Errata RHBA-2018:2819 0 None None None 2018-09-26 18:24:50 UTC

Description Mike Christie 2018-08-30 05:06:34 UTC 
Description of problem:

When switching to explicit failover this patch got dropped:

commit ac88f5d2c4e556c076e3cc3793715b4fce28cb88
Author: Mike Christie <mchristi>
Date:   Fri Dec 8 19:34:50 2017 -0600

    runner/rbd: update lock state on RTPG/INQUIRY

and:

commit ccb2ee675ad4ae6bd19717dfbf73ce495b2d96e5
Author: Mike Christie <mchristi>
Date:   Thu May 3 20:11:45 2018 -0500

    runner: get/set remote alua group info

replaced it.

The problem is that it only gets called for explicit failover, so for implicit we can end up thinking we still have the lock and if our blacklist entry has been dropped then IO could execute without holding the exclusive lock.

This is fixed in upstream patch

https://github.com/open-iscsi/tcmu-runner/pull/471


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 18 Mike Christie 2018-09-12 15:29:09 UTC 
*** Bug 1627613 has been marked as a duplicate of this bug. ***
Comment 20 errata-xmlrpc 2018-09-26 18:24:01 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2819
Note You need to log in before you can comment on or make changes to this bug.