Spec URL: https://copr-dist-git.fedorainfracloud.org/cgit/praiskup/libpq/libecpg.git/plain/libecpg.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/praiskup/libpq/fedora-rawhide-x86_64/00792501-libecpg/libecpg-10.5-1.fc30.src.rpm Description: An embedded SQL program consists of code written in an ordinary programming language, in this case C, mixed with SQL commands in specially marked sections. To build the program, the source code (*.pgc) is first passed through the embedded SQL preprocessor, which converts it to an ordinary C program (*.c), and afterwards it can be processed by a C compiler. Fedora Account System Username:
fix: Fedora Account System Username: praiskup
File ownership and conflicts will be fixed after postgresql changes, so LGTM. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL", "PostgreSQL", "GPL (v3 or later)", "Unknown or generated", "MIT/X11 (BSD like)", "BSD (unspecified)", "*No copyright* Public domain", "ISC", "BSD (3 clause)", "BSD (2 clause)", "FSF All Permissive". 6657 files have unknown license. Detailed output of licensecheck in /home/pkubat/Workdir/tmp/review/review- libecpg/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/include/pgsql/informix (postgresql-devel), /usr/include/pgsql/informix/esql(postgresql-devel) Note: Should be ok after postgresql changes. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [!]: Package does not generate any conflict. Note: Expected failure as it conflicts with postgresql for now. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libpgtypes , libecpg-debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.4.11 starting (python version = 3.6.6)... Start: init plugins INFO: selinux disabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled HW Info plugin Mock Version: 1.4.11 INFO: Mock Version: 1.4.11 Finish: chroot init INFO: installing package(s): /home/pkubat/Workdir/tmp/review/review-libecpg/results/libecpg-debuginfo-10.5-1.fc26.x86_64.rpm /home/pkubat/Workdir/tmp/review/review-libecpg/results/libpgtypes-10.5-1.fc26.x86_64.rpm /home/pkubat/Workdir/tmp/review/review-libecpg/results/libecpg-10.5-1.fc26.x86_64.rpm /home/pkubat/Workdir/tmp/review/review-libecpg/results/libecpg-devel-10.5-1.fc26.x86_64.rpm ERROR: Command failed: # /usr/bin/dnf --installroot /var/lib/mock/fedora-26-x86_64/root/ --releasever 26 --disableplugin=local --setopt=deltarpm=False install /home/pkubat/Workdir/tmp/review/review-libecpg/results/libecpg-debuginfo-10.5-1.fc26.x86_64.rpm /home/pkubat/Workdir/tmp/review/review-libecpg/results/libpgtypes-10.5-1.fc26.x86_64.rpm /home/pkubat/Workdir/tmp/review/review-libecpg/results/libecpg-10.5-1.fc26.x86_64.rpm /home/pkubat/Workdir/tmp/review/review-libecpg/results/libecpg-devel-10.5-1.fc26.x86_64.rpm Note: Not sure why this failed, manual run works ok. Rpmlint ------- Checking: libecpg-10.5-1.fc26.x86_64.rpm libecpg-devel-10.5-1.fc26.x86_64.rpm libpgtypes-10.5-1.fc26.x86_64.rpm libecpg-debuginfo-10.5-1.fc26.x86_64.rpm libecpg-10.5-1.fc26.src.rpm libecpg.x86_64: W: spelling-error %description -l en_US pgc -> pg, pic, pg c libecpg.x86_64: W: no-documentation libecpg-devel.x86_64: W: no-documentation libecpg-devel.x86_64: W: no-manual-page-for-binary ecpg libpgtypes.x86_64: W: spelling-error %description -l en_US pgtypes -> pg types, pg-types, typeset libpgtypes.x86_64: W: no-documentation libecpg.src: W: spelling-error %description -l en_US pgc -> pg, pic, pg c 5 packages and 0 specfiles checked; 0 errors, 7 warnings. Requires -------- libecpg-debuginfo (rpmlib, GLIBC filtered): libecpg (rpmlib, GLIBC filtered): libc.so.6()(64bit) libpgtypes.so.3()(64bit) libpq.so.5()(64bit) libpq.so.5(RHPG_9.6)(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) libecpg-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libc.so.6()(64bit) libecpg(x86-64) libecpg.so.6()(64bit) libpgtypes(x86-64) libpgtypes.so.3()(64bit) libpthread.so.0()(64bit) pkgconfig(libpgtypes) pkgconfig(libpq) rtld(GNU_HASH) libpgtypes (rpmlib, GLIBC filtered): libc.so.6()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) Provides -------- libecpg-debuginfo: libecpg-debuginfo libecpg-debuginfo(x86-64) libecpg: libecpg libecpg(x86-64) libecpg.so.6()(64bit) libecpg-devel: libecpg-devel libecpg-devel(x86-64) pkgconfig(libecpg) pkgconfig(libpgtypes) libpgtypes: libpgtypes libpgtypes(x86-64) libpgtypes.so.3()(64bit) Source checksums ---------------- https://ftp.postgresql.org/pub/source/v10.5/postgresql-10.5.tar.bz2 : CHECKSUM(SHA256) this package : 6c8e616c91a45142b85c0aeb1f29ebba4a361309e86469e0fb4617b6a73c4011 CHECKSUM(SHA256) upstream package : 6c8e616c91a45142b85c0aeb1f29ebba4a361309e86469e0fb4617b6a73c4011 https://ftp.postgresql.org/pub/source/v10.5/postgresql-10.5.tar.bz2.sha256 : CHECKSUM(SHA256) this package : f3f4636d988fee270da174c15e266d19280705363cb09aa11726410f66314e75 CHECKSUM(SHA256) upstream package : f3f4636d988fee270da174c15e266d19280705363cb09aa11726410f66314e75 Generated by fedora-review 0.6.4 (f322a32) last change: 2018-07-21 Command line :/usr/bin/fedora-review -n libecpg Buildroot used: fedora-26-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, BATCH, DISTTAG, EPEL5, EPEL7, EPEL6
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libecpg