Bug 1624823 - Review Request: python-trimesh - Import, export, process, analyze and view triangular meshes
Summary: Review Request: python-trimesh - Import, export, process, analyze and view tr...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-09-03 11:39 UTC by Miro Hrončok
Modified: 2018-11-19 02:20 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-11-19 01:52:10 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Miro Hrončok 2018-09-03 11:39:16 UTC
Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-trimesh.spec
SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-trimesh-2.33.11-1.fc29.src.rpm

Description: Trimesh is a pure Python library for loading and using triangular meshes with an emphasis on watertight meshes. The goal of the library is to provide a fully featured and well tested Trimesh object which allows for easy manipulation and analysis, in the style of the Polygon object in the Shapely library.

Fedora Account System Username: churchyard

Comment 1 Robert-André Mauchin 🐧 2018-09-03 15:08:20 UTC
 - Please use something like:

# https://github.com/mikedh/trimesh/issues/212
%global commit b9b139e89bbd9cdc86c837cb84ce261bf4a77b9f
Source0:        https://github.com/mikedh/trimesh/archive/%{commit}/%{pypi_name}-%{version}.tar.gz

 - python-fcl is not packaged:

DEBUG util.py:492:  Last metadata expiration check: 0:00:00 ago on lun. 03 sept. 2018 16:58:40 CEST.
DEBUG util.py:490:  BUILDSTDERR: Error: 
DEBUG util.py:490:  BUILDSTDERR:  Problem: conflicting requests
DEBUG util.py:490:  BUILDSTDERR:   - nothing provides python3dist(python-fcl) needed by python3-trimesh-all-2.33.11-1.fc30.noarch
DEBUG util.py:634:  Child return code was: 1




Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT/X11 (BSD like)", "BSD (3 clause)", "Unknown or generated",
     "zlib/libpng". 300 files have unknown license. Detailed output of
     licensecheck in /home/bob/packaging/review/python-trimesh/review-
     python-trimesh/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-trimesh , python3-trimesh-easy , python3-trimesh-all
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[x]: Spec file according to URL is the same as in SRPM.


Installation errors
-------------------
INFO: mock.py version 1.4.13 starting (python version = 3.6.6)...
Start: init plugins
INFO: selinux disabled
Finish: init plugins
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled dnf cache
Start: cleaning dnf metadata
Finish: cleaning dnf metadata
INFO: enabled ccache
INFO: enabled HW Info plugin
Mock Version: 1.4.13
INFO: Mock Version: 1.4.13
Finish: chroot init
INFO: installing package(s): /home/bob/packaging/review/python-trimesh/review-python-trimesh/results/python3-trimesh-2.33.11-1.fc30.noarch.rpm /home/bob/packaging/review/python-trimesh/review-python-trimesh/results/python3-trimesh-all-2.33.11-1.fc30.noarch.rpm /home/bob/packaging/review/python-trimesh/review-python-trimesh/results/python3-trimesh-easy-2.33.11-1.fc30.noarch.rpm
ERROR: Command failed: 
 # /usr/bin/dnf --installroot /var/lib/mock/f30-candidate-x86_64/root/ --disableplugin=local --setopt=deltarpm=False install /home/bob/packaging/review/python-trimesh/review-python-trimesh/results/python3-trimesh-2.33.11-1.fc30.noarch.rpm /home/bob/packaging/review/python-trimesh/review-python-trimesh/results/python3-trimesh-all-2.33.11-1.fc30.noarch.rpm /home/bob/packaging/review/python-trimesh/review-python-trimesh/results/python3-trimesh-easy-2.33.11-1.fc30.noarch.rpm



Rpmlint
-------
Checking: python3-trimesh-2.33.11-1.fc30.noarch.rpm
          python3-trimesh-easy-2.33.11-1.fc30.noarch.rpm
          python3-trimesh-all-2.33.11-1.fc30.noarch.rpm
          python-trimesh-2.33.11-1.fc30.src.rpm
python3-trimesh-easy.noarch: W: no-documentation
python3-trimesh-all.noarch: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 2 warnings.

Comment 2 Miro Hrončok 2018-09-03 15:47:41 UTC
Updated source URL and made python-fcl a soft dependency.

Comment 3 Miro Hrončok 2018-09-03 15:55:51 UTC
I also changed it in a way that -all requires -easy.

Comment 4 Robert-André Mauchin 🐧 2018-09-03 15:57:48 UTC
All right, package approved.

Comment 5 Miro Hrončok 2018-09-03 16:18:06 UTC
Thank You!

Comment 6 Igor Raits 2018-09-03 18:09:21 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-trimesh

Comment 7 Ankur Sinha (FranciscoD) 2018-11-09 19:26:07 UTC
Miro, are you planning to build this one for F28 and F29? fsleyes uses trimesh, so I need it (https://pagure.io/neuro-sig/NeuroFedora/issue/3). 

I'm happy to co-maintain it if that's OK with you? Please give neuro-sig commit access and we'll maintain it along with the rest of the software.

Cheers,
Ankur

Comment 8 Miro Hrončok 2018-11-09 20:15:45 UTC
Running scratchbuilds to see if it builds on f28 and f29.

I'd happy to review and merge any PR if you'll ever need that, and give ACLs based on previous happy cooperation, if that works for you. Or do you really need push access for neuro-sig right away?

Comment 9 Miro Hrončok 2018-11-09 20:27:31 UTC
Branches requested.

Would updating to 2.35.24 break any of your dependent software?

Comment 10 Ankur Sinha (FranciscoD) 2018-11-09 20:45:43 UTC
(In reply to Miro Hrončok from comment #8)
> Running scratchbuilds to see if it builds on f28 and f29.
> 
> I'd happy to review and merge any PR if you'll ever need that, and give ACLs
> based on previous happy cooperation, if that works for you. Or do you really
> need push access for neuro-sig right away?

Yeh, that works. I'll open PRs if they ever come up. I just thought I could help with the builds. :)

(In reply to Miro Hrončok from comment #9)
> Branches requested.
> 
> Would updating to 2.35.24 break any of your dependent software?

No, it says "trimesh>=2.22.28,<3", so that'll work.

Thanks very much for doing this.
Ankur

Comment 11 Fedora Update System 2018-11-10 00:06:16 UTC
python-trimesh-2.35.24-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-5b5bcf99a6

Comment 12 Fedora Update System 2018-11-10 00:07:53 UTC
python-trimesh-2.35.24-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-2e134c8112

Comment 13 Fedora Update System 2018-11-11 04:58:10 UTC
python-trimesh-2.35.24-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-2e134c8112

Comment 14 Fedora Update System 2018-11-11 05:33:33 UTC
python-trimesh-2.35.24-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-5b5bcf99a6

Comment 15 Fedora Update System 2018-11-19 01:52:10 UTC
python-trimesh-2.35.24-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2018-11-19 02:20:08 UTC
python-trimesh-2.35.24-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.