Spec URL: https://jjames.fedorapeople.org/clblast/clblast.spec SRPM URL: https://jjames.fedorapeople.org/clblast/clblast-1.4.1-1.fc30.src.rpm Fedora Account System Username: jjames Description: CLBlast is a modern, lightweight, performant and tunable OpenCL BLAS library written in C++11. It is designed to leverage the full performance potential of a wide variety of OpenCL devices from different vendors, including desktop and laptop GPUs, embedded GPUs, and other accelerators. CLBlast implements BLAS routines: basic linear algebra subprograms operating on vectors and matrices. See the CLBlast website for performance reports on various devices as well as the latest CLBlast news. The library is not tuned for all possible OpenCL devices: if out-of-the-box performance is poor, please run the tuners first. Reviewers: note that the test suite takes awhile to run, because it uses the CPU-only implementation (pocl). We cannot guarantee that koji builders have a GPU at all, much less a supported one.
Package approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "*No copyright* Apache", "Unknown or generated", "*No copyright* Apache (v2.0)". 551 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/clblast/review-clblast/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 307200 bytes in 13 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in clblast- debuginfo , clblast-debugsource [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: clblast-1.4.1-1.fc30.x86_64.rpm clblast-devel-1.4.1-1.fc30.x86_64.rpm clblast-tuners-1.4.1-1.fc30.x86_64.rpm clblast-debuginfo-1.4.1-1.fc30.x86_64.rpm clblast-debugsource-1.4.1-1.fc30.x86_64.rpm clblast-1.4.1-1.fc30.src.rpm clblast.x86_64: W: spelling-error %description -l en_US performant -> perform ant, perform-ant, performance clblast.x86_64: W: spelling-error %description -l en_US tunable -> unable, tenable, t unable clblast-tuners.x86_64: W: no-documentation clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xamax clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xasum clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xaxpy clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xaxpybatched clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xcopy clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xdot clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xdotc clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xdotu clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xgbmv clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xgemm clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xgemmbatched clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xgemmstridedbatched clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xgemv clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xger clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xgerc clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xgeru clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xhad clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xhbmv clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xhemm clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xhemv clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xher clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xher2 clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xher2k clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xherk clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xhpmv clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xhpr clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xhpr2 clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xim2col clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xnrm2 clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xomatcopy clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xsbmv clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xscal clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xspmv clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xspr clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xspr2 clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xswap clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xsymm clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xsymv clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xsyr clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xsyr2 clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xsyr2k clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xsyrk clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xtbmv clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xtpmv clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xtrmm clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xtrmv clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xtrsm clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_test_xtrsv clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_tuner_copy_fast clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_tuner_copy_pad clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_tuner_invert clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_tuner_routine_xgemm clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_tuner_routine_xtrsv clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_tuner_transpose_fast clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_tuner_transpose_pad clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_tuner_xaxpy clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_tuner_xdot clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_tuner_xgemm clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_tuner_xgemm_direct clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_tuner_xgemv clblast-tuners.x86_64: W: no-manual-page-for-binary clblast_tuner_xger clblast.src: W: spelling-error %description -l en_US performant -> perform ant, perform-ant, performance clblast.src: W: spelling-error %description -l en_US tunable -> unable, tenable, t unable 6 packages and 0 specfiles checked; 0 errors, 66 warnings.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/clblast
Thank you for the review. Sadly, I did not realize that pocl is not available on all architectures. It's a CPU implementation, so it should be, one would think. I will have to make the test suite be run on only those architectures where pocl is available.
clblast-1.4.1-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-4da8824a6f
clblast-1.4.1-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-4da8824a6f
clblast-1.4.1-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.