Bug 1625201 (sgmanager) - Review Request: sgmanager - OpenStack Security Groups Management Tool
Summary: Review Request: sgmanager - OpenStack Security Groups Management Tool
Keywords:
Status: CLOSED RAWHIDE
Alias: sgmanager
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-09-04 11:21 UTC by Igor Raits
Modified: 2018-09-07 10:14 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-09-07 10:14:37 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+

Attachments (Terms of Use)

Description Igor Raits 2018-09-04 11:21:16 UTC 
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/sgmanager.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/sgmanager-2.0.0~git+116.a420e38-1.fc30.src.rpm
Description:
OpenStack Security Groups Management Tool.
Fedora Account System Username: ignatenkobrain
Comment 1 Neal Gompa 2018-09-04 12:54:36 UTC 
Taking this review.
Comment 2 Neal Gompa 2018-09-05 23:21:52 UTC 
A couple of issues:

> Version:        2.0.0~git+%{revnum}.%{shortcommit}

This versioning scheme is not permitted currently. Please change to the current scheme or package a current release.

> BuildRequires:  /usr/bin/flit

I'd prefer if it was "%{_bindir}/flit" instead.
Comment 3 Neal Gompa 2018-09-06 00:08:30 UTC 
> %{?python_enable_dependency_generator}

Please move this to the top of the spec to avoid any potential weirdness.
Comment 4 Igor Raits 2018-09-06 05:40:56 UTC 
New Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/sgmanager.spec
New SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/sgmanager-2.0.0-0+20180906git+116.a420e38.fc30.src.rpm
Comment 5 Neal Gompa 2018-09-06 10:38:24 UTC 
Review notes:

- Package is named appropriately
- Package builds and installs
- Follows Fedora packaging guidelines
- Follows Python packaging guidelines
- Licensing is correct, license file is installed correctly

PACKAGE APPROVED.
Comment 6 Gwyn Ciesla 2018-09-06 13:17:22 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/sgmanager
Note You need to log in before you can comment on or make changes to this bug.