Bug 1625239 - Qt5 dependencies, private api usage
Summary: Qt5 dependencies, private api usage
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: hedgewars
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-09-04 13:07 UTC by Rex Dieter
Modified: 2019-03-07 18:23 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-03-07 18:23:21 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Rex Dieter 2018-09-04 13:07:41 UTC
It has come to my attention that hedgewars uses Qt5 private apis, and was hit was broken dependencies due to a recent update,
https://bodhi.fedoraproject.org/updates/FEDORA-2018-bea1e0b465

So, 2 things:

1.  Due to private api usage, please add these to hedgewars.spec to help track it and avoid issues in the future:

BuildRequires: qt5-qtbase-private-devel
%{?_qt5:Requires: %{_qt5}%{?_isa} = %{_qt5_version}}

2.  BuildRequires: qt5-devel
That is a metapackage for end-users only.  KDE-SIG strongly recommends (as strongly as is possible) to not use this metapackage in official packaging.  Please remove that and use modular dependencies instead as appropriate, ie, something like:
BuildRequires: qt5-qtbase-devel
BuildRequires: qt5-qtdeclarative-devel
...


I'll work on creating a pull request to implement both of these changes.

Comment 1 Rex Dieter 2018-09-04 13:34:15 UTC
https://src.fedoraproject.org/rpms/hedgewars/pull-request/2

Once this is merged, I can do a special build to include in the aforementioned bodhi update.  Thanks.

Comment 2 Richard Shaw 2018-09-04 14:06:41 UTC
Thanks Rex, I'll commit it as soon as I can.

Comment 3 Rex Dieter 2018-09-04 14:30:30 UTC
Thanks for the merge, I'm submitting builds now, and will take care of submitting the update.

Comment 4 Richard Shaw 2019-03-07 18:23:21 UTC
Looks like everything has been done for some time. Closing.


Note You need to log in before you can comment on or make changes to this bug.