Bug 1625850 - tests: fixes to bug-1015990-rep.t
Summary: tests: fixes to bug-1015990-rep.t
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: tests
Version: mainline
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
Assignee: Ravishankar N
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-09-06 05:28 UTC by Ravishankar N
Modified: 2019-03-25 16:30 UTC (History)
1 user (show)

Fixed In Version: glusterfs-6.0
Clone Of:
Environment:
Last Closed: 2019-03-25 16:30:33 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Ravishankar N 2018-09-06 05:28:57 UTC
Description of problem:
The test failed @ https://build.gluster.org//job/centos7-regression/2799/ :

22:16:28 ./tests/bugs/replicate/bug-1015990-rep.t: line 51: 0-: syntax error: operand expected (error token is "-")
22:16:28 not ok 12 Got "" instead of "0", LINENUM:53
22:16:28 FAILED COMMAND: 0 echo
22:16:28 not ok 13 Got "47" instead of "0", LINENUM:60
22:16:28 FAILED COMMAND: 0 echo 47


22:16:28 Test Summary Report
22:16:28 -------------------
22:16:28 ./tests/bugs/replicate/bug-1015990-rep.t (Wstat: 0 Tests: 17 Failed: 2)
22:16:28   Failed tests:  12-13

So basically, when statistics command was run, it did not get the desired output from the bricks that were up.

I am not sure if the failure was due to a problem with the patch itself, but on looking at the .t, I do see places for improvement in general regarding checking for brick up/down status, removing sleep statements etc. Sending a patch to fixing them to avoid possible future spurious failures.

Comment 1 Worker Ant 2018-09-06 05:31:39 UTC
REVIEW: https://review.gluster.org/21104 (tests: fixes to bug-1015990-rep.t) posted (#1) for review on master by Ravishankar N

Comment 2 Worker Ant 2018-09-18 05:21:40 UTC
COMMIT: https://review.gluster.org/21104 committed in master by "Pranith Kumar Karampuri" <pkarampu> with a commit message- tests: fixes to bug-1015990-rep.t

- check that the shd is connected to brick before running statistics command
- remove sleep statements
- remove unneeded ($count-$value==0) test when it is known that both values will
  be same

Fixes: bz#1625850
Change-Id: Ifcd4887f0238031e5bca803cd9bfdb75a6e6c01b
Signed-off-by: Ravishankar N <ravishankar>

Comment 3 Shyamsundar 2019-03-25 16:30:33 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-6.0, please open a new bug report.

glusterfs-6.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2019-March/000120.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.