Bug 1626199 - [Containers Provider Dashboard] UI Design Not Matching Implementation
Summary: [Containers Provider Dashboard] UI Design Not Matching Implementation
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.10.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.10.0
Assignee: Harpreet Kataria
QA Contact: Jad Haj Yahya
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-09-06 17:39 UTC by juwatts
Modified: 2019-02-12 16:49 UTC (History)
7 users (show)

Fixed In Version: 5.10.0.16
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-02-12 16:49:50 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:
juwatts: needinfo+


Attachments (Terms of Use)
Container Overview Page in 5.10.14 (32.62 KB, image/png)
2018-09-06 17:39 UTC, juwatts
no flags Details

Description juwatts 2018-09-06 17:39:43 UTC
Created attachment 1481387 [details]
Container Overview Page in 5.10.14

Description of problem:
Basing the UI on changes seen here: https://github.com/ManageIQ/manageiq-ui-classic/pull/2499

The Container Provider Dashboard in 5.10.0.14 does not match


Version-Release number of selected component (if applicable):
5.10.0.14

How reproducible:
100%


Steps to Reproduce:
1. Navigate to Compute->Containers->Overview

Following differ from what I see in the Github PR screenshot:
- Missing breadcrumb at the top "Containers Providers > OpenShift (Dashboard)"
- The providers status box shows "1 Providers" with an OpenShift symbol to the left of the text rather than just the OpenShift symbol.
- There is no "Play" button under the OpenShift symbol. 
- Alerts has a green check mark under it, but alerts is not a configured endpoint for this provider
- All status boxes of OpenShift objects have a red "x" next to them


Actual results:


Expected results:


Additional info:
Screenshot has been attched

Comment 2 Dave Johnson 2018-09-06 17:44:32 UTC
Please assess the impact of this issue and update the severity accordingly.  Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition.

If it's something like a tracker bug where it doesn't matter, please set the severity to Low.

Comment 3 juwatts 2018-09-06 19:22:49 UTC
Couple other notes:
- The card with the OpenShift symbol and the play button under it, what does that mean? As a user I am not sure what a "play" button means. 

- In the browser console, I am seeing the following error when navigating to the page:
application-3390dac1f8c8e52b87f2f8f5e8ba126da17e01b16b1621b619e3026c558f754d.js:200 TypeError: Cannot read property 'layout' of undefined
    at trendsChartController.e.updateAll (application-3390dac1f8c8e52b87f2f8f5e8ba126da17e01b16b1621b619e3026c558f754d.js:3)
    at trendsChartController.e.$onChanges (application-3390dac1f8c8e52b87f2f8f5e8ba126da17e01b16b1621b619e3026c558f754d.js:3)
    at application-3390dac1f8c8e52b87f2f8f5e8ba126da17e01b16b1621b619e3026c558f754d.js:199
    at r (application-3390dac1f8c8e52b87f2f8f5e8ba126da17e01b16b1621b619e3026c558f754d.js:198)
    at p (application-3390dac1f8c8e52b87f2f8f5e8ba126da17e01b16b1621b619e3026c558f754d.js:199)
    at application-3390dac1f8c8e52b87f2f8f5e8ba126da17e01b16b1621b619e3026c558f754d.js:199
    at l (application-3390dac1f8c8e52b87f2f8f5e8ba126da17e01b16b1621b619e3026c558f754d.js:200)
    at application-3390dac1f8c8e52b87f2f8f5e8ba126da17e01b16b1621b619e3026c558f754d.js:200
    at p.$digest (application-3390dac1f8c8e52b87f2f8f5e8ba126da17e01b16b1621b619e3026c558f754d.js:200)
    at p.$apply (application-3390dac1f8c8e52b87f2f8f5e8ba126da17e01b16b1621b619e3026c558f754d.js:200)

Comment 5 CFME Bot 2018-09-18 09:53:04 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/b765b9b43d2a9bf0736c544f3bb1b10118288246
commit b765b9b43d2a9bf0736c544f3bb1b10118288246
Author:     Harpreet Kataria <hkataria>
AuthorDate: Thu Sep 13 13:09:25 2018 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Thu Sep 13 13:09:25 2018 -0400

    Fixed some inconsistencies on provider dashboards.

    - Red crosses were added as part of https://github.com/ManageIQ/manageiq-ui-classic/pull/4453 that caused them to show up on all aggregate status cards on all provider dashboards, fixed the condition and removed setting of redundant notification hash for providers when it is not needed.
    - Show status icon under Alerts in aggregate card if Alerts are configured for a container provider, otherwise show "No data available" empty pf card.
    - On Containers Overview dashboard, Fixed to not show provider icon in Provider status aggregate card, it should only show count of providers with a link to list view to Container Providers show list.
    - Added a title on Container Overview dashboard screen, since that's the only screen on that subtab there are no breadcrumbs on the screen.

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1626199
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1626427

 app/assets/javascripts/controllers/ems_container_dashboard/aggregate_status_card_controller.js | 5 +-
 app/controllers/container_dashboard_controller.rb | 1 +
 app/services/container_dashboard_service.rb | 2 +
 app/services/ems_dashboard_service.rb | 4 -
 app/views/container_dashboard/show.html.haml | 2 +
 app/views/static/pf_charts/aggregate-status-card.html.haml | 3 +-
 6 files changed, 8 insertions(+), 9 deletions(-)

Comment 6 juwatts 2018-10-24 19:54:58 UTC
Verified in 5.10.0.19.20181009184346_1c8bf5d


Note You need to log in before you can comment on or make changes to this bug.