Bug 1626473
| Summary: | rpmbuild doesn't honor "new file mode 100755" when applying patches | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Jaroslav Škarvada <jskarvad> |
| Component: | patch | Assignee: | Than Ngo <than> |
| Status: | CLOSED ERRATA | QA Contact: | Jan Houska <jhouska> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 7.6 | CC: | djez, jhouska, jskarvad, pmatilai |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | 2.7.1-11 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-08-06 12:33:37 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jaroslav Škarvada
2018-09-07 12:25:23 UTC
rpm-build doesn't apply patches, patch does. Or git, or one of the other %autosetup backends, and your results will depend on that. Depending on which one you use, this bug belongs to that component. If it's plain old %patch you're using, then that component is "patch". Yep, it seems it's patch, reproducer: $ patch -p1 < ./test.patch Non working version: patch-2.7.1-10.el7_4.x86_64 Working version: patch-2.7.6-4.fc28.x86_64 Reassigning to patch. i will have a look at this. Thank for the report VERIFIED: NEW PASS: patch-2.7.1-11.el7 :::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::: :: Test :::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::: :: [ 10:38:32 ] :: [ BEGIN ] :: Running 'patch -p1 < test.patch' patching file a.txt :: [ 10:38:32 ] :: [ PASS ] :: Command 'patch -p1 < test.patch' (Expected 0, got 0) :: [ 10:38:32 ] :: [ BEGIN ] :: Running 'stat -c '%a %n' ./a.txt > a.txt.mode' :: [ 10:38:32 ] :: [ PASS ] :: Command 'stat -c '%a %n' ./a.txt > a.txt.mode' (Expected 0, got 0) :: [ 10:38:32 ] :: [ PASS ] :: File 'a.txt.mode' should contain '755 ./a.txt' :: [ 10:38:32 ] :: [ PASS ] :: File 'a.txt.mode' should not contain '644 ./a.txt' --cat a.txt.mode-------------------- 755 ./a.txt --/cat a.txt.mode------------------- :::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::: :: Duration: 0s :: Assertions: 4 good, 0 bad :: RESULT: PASS (Test) OLD FAIL: patch-2.7.1-10.el7_5 :::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::: :: Test :::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::: :: [ 10:38:29 ] :: [ BEGIN ] :: Running 'patch -p1 < test.patch' patching file a.txt :: [ 10:38:29 ] :: [ PASS ] :: Command 'patch -p1 < test.patch' (Expected 0, got 0) :: [ 10:38:29 ] :: [ BEGIN ] :: Running 'stat -c '%a %n' ./a.txt > a.txt.mode' :: [ 10:38:29 ] :: [ PASS ] :: Command 'stat -c '%a %n' ./a.txt > a.txt.mode' (Expected 0, got 0) :: [ 10:38:29 ] :: [ FAIL ] :: File 'a.txt.mode' should contain '755 ./a.txt' :: [ 10:38:29 ] :: [ FAIL ] :: File 'a.txt.mode' should not contain '644 ./a.txt' --cat a.txt.mode-------------------- 644 ./a.txt --/cat a.txt.mode------------------- :::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::: :: Duration: 0s :: Assertions: 2 good, 2 bad :: RESULT: FAIL Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2019:2033 |