Bug 1626513 - gdeploy should create XFS filesystem with JBOD disktype without diskcount
Summary: gdeploy should create XFS filesystem with JBOD disktype without diskcount
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Gluster Storage
Classification: Red Hat Storage
Component: gdeploy
Version: rhhiv-1.5
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
: RHGS 3.4.z Batch Update 1
Assignee: Sachidananda Urs
QA Contact: Manisha Saini
URL:
Whiteboard:
Depends On:
Blocks: 1626518
TreeView+ depends on / blocked
 
Reported: 2018-09-07 14:08 UTC by SATHEESARAN
Modified: 2018-10-31 08:42 UTC (History)
12 users (show)

Fixed In Version: gdeploy-2.0.2-29
Doc Type: Bug Fix
Doc Text:
Earlier, on selecting disktype as JBOD, gdeploy treated it as RAID disk type and requested for the diskcount which finally stopped gdeploy to execute further. With this fix, if the disktype is JBOD, the disk setup continues setting up bricks without asking for the diskcount.
Clone Of:
: 1626518 (view as bug list)
Environment:
Last Closed: 2018-10-31 08:42:22 UTC
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:3430 0 None None None 2018-10-31 08:42:38 UTC

Description SATHEESARAN 2018-09-07 14:08:49 UTC 
Description of problem:
------------------------
If the 'disktype' is chosen as 'jbod' gdeploy should execute without 'diskcount' & 'stripesize'

Version-Release number of selected component (if applicable):
--------------------------------------------------------------
gdeploy-2.0.2-27.el7rhgs

How reproducible:
-------------------
Always

Steps to Reproduce:
--------------------
1. Create a config file with 'disktype' as 'jbod' without 'diskcount' & 'stripesize'
2. Execute the config file with gdeploy

Actual results:
----------------
gdeploy fails and requires 'diskcount'

Expected results:
------------------
gdeploy should execute without 'diskcount' mentioned
Comment 1 SATHEESARAN 2018-09-07 14:11:20 UTC 
The problem here is while creating the filesystem gdeploy tries to do this:
mkfs.xfs -d <su,sw> /dev/mapper/vg-lv

So 'su' is the stripe-size (unit) and 'sw' is the stripe-width.

RHGS Admin guide - 21.2 point 2, clearly states for JBOD su, sw should be ignored. Gdeploy should follow that
Comment 2 SATHEESARAN 2018-09-07 14:12:03 UTC 
#gdeploy configuration generated by cockpit-gluster plugin
[hosts]
host1

[disktype]
jbod

[pv1]
action=create
devices=vdb
ignore_pv_errors=no

[vg1]
action=create
vgname=gluster_vg_vdb
pvname=vdb
ignore_vg_errors=no

[lv4]
action=create
lvname=gluster_lv_vmstore
ignore_lv_errors=no
vgname=gluster_vg_vdb
mount=/gluster_bricks/vmstore
size=10GB
lvtype=thick
Comment 3 Sahina Bose 2018-09-10 07:28:36 UTC 
Sachi, can you ack this if it's possible to take it for batch update 1?
Comment 4 Sachidananda Urs 2018-09-11 08:11:19 UTC 
PR: https://github.com/gluster/gdeploy/pull/516
Comment 11 Jilju Joy 2018-10-04 08:40:33 UTC 
The below configuration is also showing the same error:

[hosts]
host1

[disktype]
jbod

[backend-setup]
devices=/dev/sdb
vgs=vgrp1
pools=pool01
lvs=lvol1

-------------------------------------------
Version:
gdeploy-2.0.2-28.el7rhgs.noarch
-------------------------------------------
The configuration given in Comment 2 is working fine.
-------------------------------------------
Comment 12 Sachidananda Urs 2018-10-04 08:58:26 UTC 
(In reply to Jilju Joy from comment #11)
> The below configuration is also showing the same error:
> 
> [hosts]
> host1
> 
> [disktype]
> jbod
> 
> [backend-setup]
> devices=/dev/sdb
> vgs=vgrp1
> pools=pool01
> lvs=lvol1
> 

Jilju, please FailQA this bug. It is my mistake, I fixed it in lv feature but didn't in [backend-setup] feature. This is good case, thanks. 

Please reopen the bug. I will fix it.
Comment 13 Sachidananda Urs 2018-10-04 09:34:45 UTC 
PR: https://github.com/gluster/gdeploy/pull/517 fixes the issue.
Comment 15 Jilju Joy 2018-10-04 14:36:41 UTC 
Verified using gdeploy-2.0.2-29.el7rhgs.noarch. No error was observed.
Moving this bug to verified.
Comment 16 Sachidananda Urs 2018-10-12 11:59:17 UTC 
Looks good to me. Thanks.
Comment 18 errata-xmlrpc 2018-10-31 08:42:22 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3430
Note You need to log in before you can comment on or make changes to this bug.