Bug 1627150 - Retire greenwave in Fedora 30+ (or switch it to Python 3)
Summary: Retire greenwave in Fedora 30+ (or switch it to Python 3)
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: greenwave
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ralph Bean
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PY2REMOVAL
TreeView+ depends on / blocked
 
Reported: 2018-09-10 13:55 UTC by Miro Hrončok
Modified: 2018-09-20 03:17 UTC (History)
10 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-09-20 03:17:53 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Miro Hrončok 2018-09-10 13:55:52 UTC
In line with the Mass Python 2 Package Removal [0], all (sub)packages of greenwave were marked for removal:

 * greenwave

According to our query, those packages only provide a Python 2 importable module. If this is not true, please tell us why, so we can fix our query.

Please retire your package in Rawhide (Fedora 30).

If there is no objection in a week, we will retire the package for you.

We hope this doesn't come to you as a surprise. If you want to know our motivation for this, please read the change document [0].

[0] https://fedoraproject.org/wiki/Changes/Mass_Python_2_Package_Removal

Comment 1 Dan Callaghan 2018-09-16 03:08:45 UTC
Greenwave is an important part of Fedora infra and was ported to Python 3 in (I think) Fedora 28 timeframe. So this one seems like it must be a mistake in the script?

Comment 2 Miro Hrončok 2018-09-16 08:22:06 UTC
This is all Python 2:

https://src.fedoraproject.org/rpms/greenwave/blob/master/f/greenwave.spec

Also, this looks like a Python importable module and nothing more:

%files
%license COPYING
%doc README.md conf
%if 0%{?fedora}
%doc docs/_build/html docs/_build/text
%endif
%{python2_sitelib}/%{name}
%{python2_sitelib}/%{name}*.egg-info
%{_sysconfdir}/fedmsg.d/*

What depends on greenwave on Fedora infra and how is our script able to find that out?

Comment 3 Miro Hrončok 2018-09-16 08:29:09 UTC
Here is an upstream commit Switch to Python 3 form 3 months ago:

https://pagure.io/greenwave/c/6d877ef089ff5d094f4bb13cd0126308a04f3ff0

This project apparently has a specfile upstream. Please propagate the change into Fedora. Thank You.

Comment 4 Zbigniew Jędrzejewski-Szmek 2018-09-19 07:40:17 UTC
This one provides:
/etc/fedmsg.d/resultsdb.py
/etc/fedmsg.d/waiverdb.py

There's a bunch of other packages like that:
$ dnf repoquery --disablerepo=* --enablerepo=fedora --releasever=rawhide --qf '%{name}' -f /etc/fedmsg.d/\*

autocloud-common
bodhi-server
bugyou                  <------ hmm, I think this one got retired the other day
darkserver-importer
datanommer-config
fedmsg-base
freshmaker
greenwave
module-build-service
odcs
python2-fedimg
python2-fedmsg-genacls
statscache-common
taskotron-trigger

Comment 5 Miro Hrončok 2018-09-19 07:54:55 UTC
I've explicitly asked on #fedora-admin and was informed that Python files in /etc/fedmsg.d/ are configuration.

I removed the check in:

https://github.com/fedora-python/portingdb/commit/b78d0cda2994dd9703784845017e5cd025e14e35

Comment 7 Ralph Bean 2018-09-20 03:17:53 UTC
I think this is all done.  Let me know if not!


Note You need to log in before you can comment on or make changes to this bug.