Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1627734

Summary:	Don't attempt unnecessary cleanups in vhostmd hook
Product:	[oVirt] vdsm	Reporter:	Milan Zamazal <mzamazal>
Component:	General	Assignee:	Milan Zamazal <mzamazal>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Polina <pagranat>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.30.0	CC:	bugs
Target Milestone:	ovirt-4.2.7	Flags:	rule-engine: ovirt-4.2+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	v4.20.40	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-11-02 14:35:43 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1600507

Description Milan Zamazal 2018-09-11 11:10:03 UTC

Description of problem:

after_vm_destroy in vhostmd hook tries to perform vhostmd cleanup on each invocation, i.e. whenever any VM is destroyed. That can cause performance problems when multiple VMs are shut down concurrently, due to locks taken on VM shutdown and limited number of worker threads for API calls. The API calls performed in vhostmd hook may get stuck waiting for available worker threads for too long, resulting in timeouts.

vhostmd hook should attempt to perform after_vm_destroy checks and actions only when run on VMs having sap_agent custom property. They are unnecessary, and potentially harmful, otherwise.

Additional info:

See https://bugzilla.redhat.com/1600507 for more details.

Comment 1 Polina 2018-10-09 08:43:13 UTC

verified on version 
ovirt-release42-snapshot-4.2.7-0.2.rc2.20181007015214.gitfb30674.el7.noarch
vdsm-4.20.42-1.el7.x86_64

test1. start VM1 with no custom properties and VM2 with custom property 'sap_agent'.
Shutdown the VMs. For the VM2 I see in vdsm.log the 'RPC call Host.getVMFullList'
For the VM2 there are no calls as expected.
test2. the same two VMs are tested for migration. no calls Host.getVMFullList in vdsm.log for VM1 destruction.

Comment 2 Sandro Bonazzola 2018-11-02 14:35:43 UTC

This bugzilla is included in oVirt 4.2.7 release, published on November 2nd 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.7 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.