Created attachment 1482367 [details]
Description of problem:
Running "foreman-maintain upgrade run --target-version 6.4 -y"
If "Upgrade Step: Running installer..." step fails it continues with "Upgrade Step: remove_legacy_mongo..." which resulted in breaking mongo and running "satellite-installer --upgrade" failing.
When a step fails we should exit straight away
Version-Release number of selected component (if applicable):
6.3.3 -> 6.4.beta upgrade.
This step actually are not defined in the foreman-maintain, but rather in the installer hooks, most of them are defined in a way, that they are not run unless installer succeeds, but this change https://github.com/Katello/katello-installer/commit/b70dde1807e6b96c92d5f893d67e1172fd8a9722 (done as part of bz 1583233) actually made it run always.
Putting needinfo on Eric, as the original author of this changes.
I've updated the subject, as it was misleading, since this issue is not connected to foreman-maintain behaviour.
Can you help clarify what installation step actually failed? The full installer log may help with that.
Sure, We had setup SSO using --foreman-ipa-authentication=true without IPA (we are using different krb5 infra)
Looks to be due to https://github.com/theforeman/puppet-foreman/commit/b0f88ed52539ca74cf58017d97bbb8327b083e1f#diff-0ac866172efd29d0ddc2aa75ae6f182dR74
But I don't think the reason for the failure is of much relevance for the scope of this BZ.
Could we get the installer log for the failure?
PR not merged yet
Moving this bug to POST for triage into Satellite 6 since the upstream issue https://projects.theforeman.org/issues/24966 has been resolved.
Satellite 6.4 snap 25
Upgrade step 'remove_legacy_mongo' not run if installer failed. (see attachment)
Created attachment 1489938 [details]
upgrade installer output
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.