Contribute to logging role to linux-system-roles https://github.com/linux-system-roles/logging, so it will be the base for deploying fluentd and rsyslog to collect oVirt logs. Rsyslog and fluentd should collect engine.log and vdsm.log. The ovirt-engine-metrics playbook will include this role and provide the necessary vars for it.
What are the verification steps here? From title and description, it seems like code change.
Basic functionality needs to be tested. That metrics and logs are sent to Elasticsearch. Logs records are parsed correctly and dashboards are working as before. Fields should remain like in 4.2.z. Missing functionality that we know of is saving to file , sending to an Elasticsearch not on OpenShift , sending to remote rsyslog. They will be added in the future. Sending to a remote Fluentd is deprecated.
Hello Shirly, 1. Please add some verification steps. They are completely missing. 2. You write: "The ovirt-engine-metrics playbook will include this role". Which playbook? There are several playbooks in that package.
When installing the ovirt-metrics-engine rpm There should be the role /usr/share/ansible/roles/oVirt.metrics/roles/oVirt.linux-system-roles-logging That was added automatically to the rpm using CI automation.
Steps: 1) Have engine with 4.3 RHV 2) Check if /usr/share/ansible/roles/oVirt.metrics/roles/ contains the oVirt.linux-system-roles-logging role Result: The package ovirt-engine-metrics contains the role for linux system roles logging Verified in: ovirt-engine-4.3.2-0.1.el7.noarch, ovirt-engine-metrics-1.2.1-0.0.master.20190306114408.el7.noarch
This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019. Since the problem described in this bug report should be resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report.