Hide Forgot
Spec URL: https://copr-be.cloud.fedoraproject.org/results/nim/mock-install/fedora-rawhide-x86_64/00798349-mock-install/mock-install.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/nim/mock-install/fedora-rawhide-x86_64/00798349-mock-install/mock-install-1.0-1.fc30.src.rpm Copr Build: https://copr.fedorainfracloud.org/coprs/nim/mock-install/build/798349/ Description: A small utility to request package installation within a mock build root when using the pm_request plugin. It will be used by the next generation of Fedora Go (golang) packaging macros. However the utility is totally language agnostic and could be used pretty much in any spec file (it *is* written in Go). It does make spec files mock-specific but mock *is* the official Fedora Build system. Writing such an utility was suggested in: https://github.com/rpm-software-management/mock/issues/160 Hopefully https://github.com/rpm-software-management/rpm/issues/104 will make it obsolete someday… Fedora Account System Username: nim
Taking this review.
So it will be an 1.1, I had forgotten to check what happened when the command was called with no arguments
Could you please post updated Spec URL and SRPM URL links for fedora-review to process?
Here: https://copr-be.cloud.fedoraproject.org/results/nim/mock-install/fedora-rawhide-x86_64/00812372-mock-install/mock-install.spec https://copr-be.cloud.fedoraproject.org/results/nim/mock-install/fedora-rawhide-x86_64/00812372-mock-install/mock-install-1.1-1.0.fc30.bz1629371.src.rpm it's about the same as before, I just added a missing %license line
Neal, please review this. The packaging is trivial, so I don't think there's anything to wait for here.
Review notes: [x] Package builds and installs [x] Package complies with packaging guidelines [!] Package is missing changelog and has "bad" release value - Please fix on import PACKAGE APPROVED.
Thanks for the review !
Package never imported, resetting ticket status. Nicolas, are you still interested in this?
This package is no longer needed since mock can now do this itself when using %generate_buildrequires.
Let's close this then. Nicolas, please reopen if appropriate.