Bug 1629371 - Review Request: mock-install - A small utility to request package installation within a mock buildroot
Summary: Review Request: mock-install - A small utility to request package installati...
Keywords:
Status: POST
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://copr.fedorainfracloud.org/cop...
Whiteboard:
Depends On: 1641191 1641187
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-09-15 12:43 UTC by Nicolas Mailhot
Modified: 2018-11-06 17:05 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Nicolas Mailhot 2018-09-15 12:43:11 UTC
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/nim/mock-install/fedora-rawhide-x86_64/00798349-mock-install/mock-install.spec

SRPM URL: 
https://copr-be.cloud.fedoraproject.org/results/nim/mock-install/fedora-rawhide-x86_64/00798349-mock-install/mock-install-1.0-1.fc30.src.rpm

Copr Build:
https://copr.fedorainfracloud.org/coprs/nim/mock-install/build/798349/

Description: 
A small utility to request package installation within a mock build root when
using the pm_request plugin.

It will be used by the next generation of Fedora Go (golang) packaging macros. However the utility is totally language agnostic and could be used pretty much in any spec file (it *is* written in Go).

It does make spec files mock-specific but mock *is* the official Fedora Build system. Writing such an utility was suggested in:
https://github.com/rpm-software-management/mock/issues/160

Hopefully https://github.com/rpm-software-management/rpm/issues/104 will make it obsolete someday…

Fedora Account System Username: nim

Comment 1 Neal Gompa 2018-09-15 13:02:59 UTC
Taking this review.

Comment 2 Nicolas Mailhot 2018-09-15 14:31:07 UTC
So it will be an 1.1, I had forgotten to check what happened when the command was called with no arguments

Comment 3 Neal Gompa 2018-10-19 20:32:08 UTC
Could you please post updated Spec URL and SRPM URL links for fedora-review to process?

Comment 5 Zbigniew Jędrzejewski-Szmek 2018-11-05 13:10:20 UTC
Neal, please review this. The packaging is trivial, so I don't think there's anything to wait for here.

Comment 6 Neal Gompa 2018-11-06 14:45:52 UTC
Review notes:

[x] Package builds and installs
[x] Package complies with packaging guidelines
[!] Package is missing changelog and has "bad" release value
    - Please fix on import

PACKAGE APPROVED.

Comment 7 Nicolas Mailhot 2018-11-06 17:05:35 UTC
Thanks for the review !


Note You need to log in before you can comment on or make changes to this bug.