Bug 1630027 - fetch-crl-boot service config should include RemainAfterExit=yes
Summary: fetch-crl-boot service config should include RemainAfterExit=yes
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: fetch-crl3
Version: epel7
Hardware: Unspecified
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Steve Traylen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-09-17 20:00 UTC by jouvin
Modified: 2019-11-30 00:29 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-11-30 00:29:10 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description jouvin 2018-09-17 20:00:53 UTC
Description of problem:

Hi,

fetch-crl-boot service can take some time to complete and with the current configuration of the systemd unit (EL7), every time `systemctl start fetch-crl-boot` is entered, the service is run again (as opposed to `systemctl restart`). This is due to the fact that the unit configuration doesn't include 'RemainAfterExit=yes'.

IMO, this is an unexpected behaviour. After the boot, the service should remained in the so called 'active (exited)' state and the sysadmin should use the restart command to reexecute it if needed.

This problem has a minor impact, as long as you don't use a management system (Quattor in our case) that redo the start command for every service declared (intentionally) to be on in the configuration. With every service, except fetch-crl-boot, this has the effect of doing nothing if the service already runs.

Version-Release number of selected component (if applicable):
3.0.19-1

How reproducible:
Always

Steps to Reproduce:
1. Boot your system and check that fetch-crl-boot ran successfully (systemd status fetch-crl-boot)
2. systemctl start fetch-crl-boot
3. 

Actual results:
systemctl status fetch-crl-boot shows that the service ran again

Expected results:
No new run of the service that has already run at boot time with the 'start' command (as opposed to 'restart')

Additional info:
Adding RemainAfterExit in the service unit configuration fixes the problem.

Comment 1 Steve Traylen 2019-11-14 11:08:56 UTC
Hi Michel,

It's debatable but makes sense for the reasons you outline.

For info the epel8 package just has a fetch-crl.service and fetch-crl.timer with the previous -boot and -cron units removed.

In other words you should almost certainly mange the .timer one and forget about the service. 
A remain-after-exit true would be very wrong so this is a 7 only fix.

Steve.

Comment 2 Steve Traylen 2019-11-14 11:14:32 UTC
I wonder why we don't have the same problem - https://github.com/voxpupuli/puppet-fetchcrl/blob/master/manifests/service.pp#L15  , we must check status is a different way...

Comment 3 Fedora Update System 2019-11-14 11:15:54 UTC
FEDORA-EPEL-2019-91801d0de3 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-91801d0de3

Comment 4 Fedora Update System 2019-11-15 04:07:46 UTC
fetch-crl-3.0.19-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-91801d0de3

Comment 5 Fedora Update System 2019-11-30 00:29:10 UTC
fetch-crl-3.0.19-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.