Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1630170

Summary: jboss-cli-commands.txt is not finished successfully when applying the patch
Product: [JBoss] JBoss Operations Network Reporter: Filip Brychta <fbrychta>
Component: Launch Scripts, UpgradeAssignee: Josejulio Martínez <jmartine>
Status: CLOSED CURRENTRELEASE QA Contact: Filip Brychta <fbrychta>
Severity: high Docs Contact:
Priority: urgent    
Version: JON 3.3.11CC: jmartine, spinder
Target Milestone: CR02Keywords: Triaged
Target Release: JON 3.3.11   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-10-24 07:22:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
full update log none

Description Filip Brychta 2018-09-18 06:24:54 UTC
Created attachment 1484251 [details]
full update log

Description of problem:
jboss-cli-commands.txt file contains commands which should be executed by jboss-cli while applying JON cumulative patch but it's failing.

Version-Release number of selected component (if applicable):
JON 3.3.11.ER01

How reproducible:
Always

Steps to Reproduce:
1. install and stop jon3.3.0.GA
2. apply CP11: jon-server-3.3.0.GA-update-11/apply-updates.sh jon-server-3.3.0.GA


Actual results:
Content of jboss-cli-commands.txt should be applied but it's not
Following error is visible in update log (jon-server-3.3.0.GA/.patched/3.3.0.GA-update-11_09-17-18_02-58-09/update.log):
Failed to get the list of the operation properties: "JBAS013493: System boot is in process; execution of remote management operations is not currently available"

Expected results:
Content of jboss-cli-commands.txt should be applied

Additional info:
Full update log is attached.
There are more problems which should be resolved in this area:
1) User is incorrectly informed that patch was applied successfully on stdout:
Starting JBoss CLI and applying patches...
        Stopping the JON Server...

        You have successfully extracted patch contents into (JON server) and/or (JON agent) installation folder(s).

which is not true because cli commands were not applied successfully.
User should be notified about failures without need to look in jon-server-3.3.0.GA/.patched/3.3.0.GA-update-11_09-17-18_02-58-09/update.log

2) When applying the patch before JON server installation (applying it immediately after unzipping jon server) the patch is not even trying to execute jboss-cli-commands.txt

This is not a regression, it's visible in JON 3.3.10 too. Luckily there are no commands to execute in jboss-cli-commands.txt in JON 3.3.10 and older (checked only CP05 -- CP10)

Comment 2 Josejulio Martínez 2018-09-21 15:48:45 UTC
1) I'll look that issue.

2) The installer takes care of setting the system, jboss-cli-commands.txt is only needed when doing an update from a previous installed version.

Comment 9 Josejulio Martínez 2018-10-04 14:27:42 UTC
commit 7de24664373ed825a76f8164a566d03691f8161a (HEAD -> master, upstream/master)
Author:     Josejulio Martínez <finwemartinez>
AuthorDate: Thu Oct 4 06:17:55 2018 -0500
Commit:     Michael Burman <yak>
CommitDate: Thu Oct 4 14:17:55 2018 +0300

    Bug 1630170 - Set the same properties as jboss-cli-commands.txt (#355)
    
    - Allows the installer to write jboss.tx.node.id even if not set at install time
     - Sets jackson.deserialization.whitelist.packages