Bug 1630281 - dnfdaemon: Remove (sub)packages from Fedora 30+: python2-dnfdaemon
Summary: dnfdaemon: Remove (sub)packages from Fedora 30+: python2-dnfdaemon
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: dnfdaemon
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Miro Hrončok
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PY2REMOVAL
TreeView+ depends on / blocked
 
Reported: 2018-09-18 10:05 UTC by Miro Hrončok
Modified: 2019-01-14 16:17 UTC (History)
8 users (show)

Fixed In Version: dnfdaemon-0.3.19-5.fc30
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-01-14 16:17:14 UTC


Attachments (Terms of Use)

Description Miro Hrončok 2018-09-18 10:05:38 UTC
In line with the Mass Python 2 Package Removal [0], the following (sub)packages of dnfdaemon were marked for removal:

 * python2-dnfdaemon

According to our query, those (sub)packages only provide a Python 2 importable module. If this is not true, please tell us why, so we can fix our query.

Please remove them from your package.

As said in the change document, if there is no objection in a week, we will remove the package(s) as soon as we get to it. This change might not match your packaging style, so we'd prefer if you did the change. If you need more time, please let us know here.

We hope this doesn't come to you as a surprise. If you want to know our motivation for this, please read the change document [0].

[0] https://fedoraproject.org/wiki/Changes/Mass_Python_2_Package_Removal

Comment 1 Miro Hrončok 2019-01-14 14:47:06 UTC
Trivial removal results in:

BUILDSTDERR: error: Installed (but unpackaged) file(s) found:
BUILDSTDERR:    /lib/python/site-packages/dnfdaemon/__init__.py
BUILDSTDERR:    /lib/python/site-packages/dnfdaemon/client/__init__.py
RPM build errors:
BUILDSTDERR:     Installed (but unpackaged) file(s) found:
BUILDSTDERR:    /lib/python/site-packages/dnfdaemon/__init__.py
BUILDSTDERR:    /lib/python/site-packages/dnfdaemon/client/__init__.py

Maybe bad prefix? Any idea what's wrong?

Comment 2 Neal Gompa 2019-01-14 15:02:40 UTC
The Makefile doesn't yet know how to not install Python 2 bindings. I haven't been able to get around to it, but if you want to propose a patch upstream for disabling the Python 2 bindings, I'd be happy to take that upstream and pull it in.

Comment 3 Miro Hrončok 2019-01-14 15:57:27 UTC
So the /lib/python/site-packages is just some default guess when it couldn't ask python2 where to put those files? In that case we can just delete them after %install and call it a temporary workaround.

Comment 4 Neal Gompa 2019-01-14 16:09:29 UTC
Pretty much, yes.


Note You need to log in before you can comment on or make changes to this bug.