Bug 1631002 - gnome-control-center stuck and starts consume memory abnormally if I try to change the background or lock screen image.
Summary: gnome-control-center stuck and starts consume memory abnormally if I try to c...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-control-center
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Pete Walter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: RejectedBlocker AcceptedFreezeException
Depends On:
Blocks: F29FinalFreezeException
TreeView+ depends on / blocked
 
Reported: 2018-09-19 16:56 UTC by Mikhail
Modified: 2018-10-10 17:41 UTC (History)
9 users (show)

Fixed In Version: gnome-control-center-3.30.1-3.fc29
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-10-10 17:41:15 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
screenshot (674.44 KB, image/png)
2018-09-19 16:56 UTC, Mikhail
no flags Details
screenshot (1.27 MB, image/png)
2018-10-03 15:42 UTC, Mikhail
no flags Details


Links
System ID Private Priority Status Summary Last Updated
GNOME Gitlab GNOME/gnome-control-center/issues/191 0 None None None 2018-09-19 16:59:21 UTC

Description Mikhail 2018-09-19 16:56:12 UTC
Created attachment 1484877 [details]
screenshot

Description of problem:
gnome-control-center starts consume memory abnormally if I try to change the background or lock screen image.

For reproduction this issue you should have a lot of pictures in ~/Pictures directory.

$ find ~/Pictures -type f | wc -l
3313


Version-Release number of selected component (if applicable):

$ gnome-control-center --version
gnome-control-center 3.30.0

# rpm -q gnome-control-center
gnome-control-center-3.30.0-1.fc30.x86_64


Steps to Reproduce:
1. Move all your photo collection to ~/Pictures directory. (for better reproduction count of photos should be several thousands)
2. Open gnome control center and try change background or lock screen image.
3.

After it gnome control center stuck and starts consume memory abnormally


$ ps aux --sort -rss
USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
mikhail  19656  0.2 28.1 14598304 9249460 tty2 tl+  Sep14   3:14 gnome-control-center
mikhail  18409 21.8  5.8 21478115516 1918632 pts/6 Sl+ 19:05  22:01 /home/mikhail/Downloads/firefox/firefox -contentproc -childID 4 -isForBrowser -prefsLen 169 -prefMapSize 176110 -schedulerPrefs 0001,2 -parentB
mikhail  13667 22.4  4.8 21479429480 1597832 pts/6 Sl+ Sep14 330:45 /home/mikhail/Downloads/firefox/firefox
mikhail  18317 12.3  4.4 21477813636 1469784 pts/6 Sl+ 19:04  12:24 /home/mikhail/Downloads/firefox/firefox -contentproc -childID 2 -isForBrowser -prefsLen 79 -prefMapSize 176110 -schedulerPrefs 0001,2 -parentBu
qemu      3885  123  3.7 2894248 1242324 ?     Sl   Sep14 1844:21 /usr/bin/qemu-system-x86_64 -machine accel=kvm -name guest=win10,debug-threads=on -S -object secret,id=masterKey0,format=raw,file=/var/lib/libvir
mikhail  18417  4.0  3.6 21477767500 1185960 pts/6 Dl+ 19:05   4:06 /home/mikhail/Downloads/firefox/firefox -contentproc -childID 5 -isForBrowser -prefsLen 169 -prefMapSize 176110 -schedulerPrefs 0001,2 -parentB
mikhail  18353  1.3  2.4 21476988880 791300 pts/6 Dl+ 19:05   1:20 /home/mikhail/Downloads/firefox/firefox -contentproc -childID 3 -isForBrowser -prefsLen 79 -prefMapSize 176110 -schedulerPrefs 0001,2 -parentBui
mikhail  18267  2.7  2.2 21477346828 726004 pts/6 Dl+ 19:04   2:45 /home/mikhail/Downloads/firefox/firefox -contentproc -childID 1 -isForBrowser -prefsLen 1 -prefMapSize 176110 -schedulerPrefs 0001,2 -parentBuil
mikhail  20022 11.2  1.7 2372168 566648 pts/1  SLl+ 04:31 109:22 /opt/google/chrome-unstable/chrome
mikhail  20612  1.3  1.6 1836432 541132 pts/1  Sl+  04:31  13:02 /opt/google/chrome-unstable/chrome --type=renderer --field-trial-handle=6027522647588692822,15304814186233863498,131072 --service-pipe-token=85179
mikhail   7446 86.0  1.6 1087420 529172 pts/17 Rl+  20:45   0:10 gdb -p 19656
mikhail   4585  0.6  1.2 1397104 419836 pts/2  Sl+  Sep14   9:11 /usr/lib64/opera-developer/opera-developer --type=renderer --field-trial-handle=5442091857397404156,16833416997702991072,131072 --service-pipe-tok
mikhail   3090 14.1  1.1 2813932 362660 pts/2  SLl+ Sep14 211:12 /usr/lib64/opera-developer/opera-developer

Comment 1 Fedora Blocker Bugs Application 2018-09-19 17:02:58 UTC
Proposed as a Blocker and Freeze Exception for 29-final by Fedora user mikhail using the blocker tracking app because:

 because changing background  is a basic functionality of gnome-control center

Comment 2 Adam Williamson 2018-09-19 21:02:37 UTC
Can you check for errors in the system logs? Thanks.

Comment 3 Mikhail 2018-09-19 21:46:29 UTC
This messages appears in system log when I try change background:

Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: author
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: email
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: license
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: author
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: email
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: license
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: author
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: email
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: license
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: author
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: email
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: license
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: author
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: email
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: license
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: author
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: email
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: license
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: author
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: email
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: license
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: author
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: email
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: license
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: author
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: email
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: license
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: author
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: email
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: license
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: author
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: email
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: license
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: author
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: email
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: license
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: author
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: email
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: license
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: author
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: email
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: license
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: author
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: email
Sep 20 02:18:23 localhost.localdomain gnome-control-c[2958]: Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: license
Sep 20 02:18:29 localhost.localdomain org.gnome.Shell.desktop[1984]: Window manager warning: last_focus_time (2283959) is greater than comparison timestamp (2283783).  This most likely represents a buggy client>
Sep 20 02:18:29 localhost.localdomain org.gnome.Shell.desktop[1984]: Window manager warning: last_user_time (2283959) is greater than comparison timestamp (2283783).  This most likely represents a buggy client >
Sep 20 02:18:29 localhost.localdomain org.gnome.Shell.desktop[1984]: Window manager warning: W1 (mikhail@lo) appears to be one of the offending windows with a timestamp of 2283959.  Working around...
Sep 20 02:18:29 localhost.localdomain org.gnome.Shell.desktop[1984]: Window manager warning: W4 (Settings) appears to be one of the offending windows with a timestamp of 2283959.  Working around...
Sep 20 02:18:43 localhost.localdomain org.gnome.Shell.desktop[1984]: Window manager warning: last_user_time (2297711) is greater than comparison timestamp (2297679).  This most likely represents a buggy client >
Sep 20 02:18:43 localhost.localdomain org.gnome.Shell.desktop[1984]: Window manager warning: W1 (mikhail@lo) appears to be one of the offending windows with a timestamp of 2297711.  Working around...
Sep 20 02:18:43 localhost.localdomain org.gnome.Shell.desktop[1984]: Window manager warning: last_user_time (2297880) is greater than comparison timestamp (2297836).  This most likely represents a buggy client >
Sep 20 02:18:43 localhost.localdomain org.gnome.Shell.desktop[1984]: Window manager warning: W1 (mikhail@lo) appears to be one of the offending windows with a timestamp of 2297880.  Working around...
Sep 20 02:18:45 localhost.localdomain org.gnome.Shell.desktop[1984]: Window manager warning: last_user_time (2299816) is greater than comparison timestamp (2299779).  This most likely represents a buggy client >
Sep 20 02:18:45 localhost.localdomain org.gnome.Shell.desktop[1984]: Window manager warning: W1 (mikhail@lo) appears to be one of the offending windows with a timestamp of 2299816.  Working around...

Comment 4 Geoffrey Marr 2018-09-24 19:28:17 UTC
Discussed during the 2018-09-24 blocker review meeting: [1]

The decision to delay the classification of this as a blocker bug was made as we are unsure if this bug is bad enough to warrant blocker status. We will delay the decision to allow for more testing and data regarding this bug to come to surface.

[1] https://meetbot.fedoraproject.org/fedora-blocker-review/2018-09-24/f29-blocker-review.2018-09-24-16.05.txt

Comment 5 Geoffrey Marr 2018-10-01 19:44:01 UTC
Discussed during the 2018-10-01 blocker review meeting: [1]

The decision to classify this bug as a "RejectedBlocker" was made as jlanda was not able to reproduce this, and it does not seem a serious or commonly-encountered enough issue to constitute a violation of the 'basic functionality' criterion

[1] https://meetbot.fedoraproject.org/fedora-blocker-review/2018-10-01/f29-blocker-review.2018-10-01-16.00.txt

Comment 6 Julen Landa Alustiza 2018-10-01 21:33:55 UTC
I can reproduce it.

4 vCPU libvirt vm with 4GB ram, with 2500 copies of the same 6Mb jpg on Pictures/

gnome-control-center got stucked around 3 minutes with a memory usage aroung 2400 Mb. Once it finished loading i can choose the wallpaper correctly. Memory consume remains althought after cancelling the wallpaper choosing panel.

4 vCPU libvirt vm with 2GB ram, with 1000 copies of the same 6Mb jpg on Pictures/ had similar relative behaviour at the first tests, but after opening the wallpaper setting panel twice it crashed. gnome-control-center worked properly after relaunching it.

It's weird to get full gnome-control-center stucked processing photos from the non-active second tab of the wallpaper settings panel :S

Comment 7 Lukas Brabec 2018-10-02 07:37:03 UTC
I tried this on bare metal, with 3333 copies of same file (~7MB jpeg).

$ find ~/Pictures/ -type f | wc -l
3355

When I tried to change wallpaper, gnome-control-center froze and started hitting the limit of opened files:
...
Oct 02 09:21:38 t480s gnome-control-c[3625]: Failed to load picture '/home/lbrabec/Pictures/Screenshot from 2018-09-13 11-18-22.png': Error opening file /home/lbrabec/Pictures/Screenshot from 2018-09-13 11-18-22.png: Too many open files
Oct 02 09:21:38 t480s gnome-control-c[3625]: Failed to load picture '/home/lbrabec/Pictures/Screenshot from 2018-09-13 11-15-42.png': Error opening file /home/lbrabec/Pictures/Screenshot from 2018-09-13 11-15-42.png: Too many open files
Oct 02 09:21:38 t480s gnome-control-c[3625]: Failed to load picture '/home/lbrabec/Pictures/Screenshot from 2018-09-13 11-13-32.png': Error opening file /home/lbrabec/Pictures/Screenshot from 2018-09-13 11-13-32.png: Too many open files
Oct 02 09:21:38 t480s gnome-control-c[3625]: Failed to load picture '/home/lbrabec/Pictures/Screenshot from 2018-09-13 11-08-13.png': Error opening file /home/lbrabec/Pictures/Screenshot from 2018-09-13 11-08-13.png: Too many open files
...


$ prlimit --pid 3625 --nofile
RESOURCE DESCRIPTION              SOFT HARD UNITS
NOFILE   max number of open files 1024 4096 files

$ ls -1 /proc/3625/fd | wc -l
1023

With --nofile=100000, there were no such errors in journal, gnome-control-center was frozen during the loading of all the pictures, but after a while it loaded them all.

Comment 8 Adam Williamson 2018-10-02 15:42:03 UTC
Did you check memory usage while doing it?

Comment 9 Adam Williamson 2018-10-02 16:50:07 UTC
There is now an upstream MR for this:

https://gitlab.gnome.org/GNOME/gnome-control-center/merge_requests/214

Comment 10 Adam Williamson 2018-10-02 16:58:58 UTC
I'm running a scratch build with the proposed fix for this:

https://koji.fedoraproject.org/koji/taskinfo?taskID=30014224

can folks please test with that and report how well it addresses the problem? Thanks!

Comment 11 Julen Landa Alustiza 2018-10-03 04:14:33 UTC
Tested with Adam's build, same 4vcpu testing box with 1k ~6Mb photos.

Now I can choose a wallpaper from wallpaper tab one second after opening the wallpaper settings panel, much better. The memory consume doesn't go high either, arount 5% while I'm on the first tab.

When I change the tab to Pictures gnome-control-center starts to consume cpu due to photo processing, but memory consume is fixed. Now is possible to scroll while loading photos althrought it's not the best user experience but it works (it stucks for seconds)

Once finishes processing the 1k photos the panel is fluid again.

The main problem is addressed with this merge request

Comment 12 Lukas Brabec 2018-10-03 09:51:58 UTC
I have the same experience, the problem is solved with Adam's build.

Comment 13 Mikhail 2018-10-03 15:42:19 UTC
Created attachment 1490135 [details]
screenshot

Comment 14 Mikhail 2018-10-03 15:50:30 UTC
(In reply to Mikhail from comment #13)
> Created attachment 1490135 [details]
> screenshot

I confirm that the problem with memory consumption is solved, but the pictures appear very slowly.
Is possible accelerate appearing pictures? The pictures are downloaded from internet much faster than they appeared in picture picker. (And it on powerfull computer with 32GB RAM and 16 thread CPU)

Comment 15 František Zatloukal 2018-10-08 18:07:52 UTC
Discussed during the 2018-10-08 blocker review meeting: [1]

The decision to classify this bug as an AcceptedFreezeException was made:

"This is definitely a bad enough bug to be worth an FE to ensure it's fixed on live images and immediately after initial install or upgrade"

[1] https://meetbot-raw.fedoraproject.org/fedora-blocker-review/2018-10-08/f29-blocker-review.2018-10-08-16.00.log.txt

Comment 16 Fedora Update System 2018-10-10 11:26:08 UTC
gnome-control-center-3.30.1-3.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-275becdb8a

Comment 17 Fedora Update System 2018-10-10 15:50:25 UTC
gnome-control-center-3.30.1-3.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-275becdb8a

Comment 18 Fedora Update System 2018-10-10 17:41:15 UTC
gnome-control-center-3.30.1-3.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.