Bug 1631012 - Expose ironic::executor_thread_pool_size in puppet for undercloud tuning
Summary: Expose ironic::executor_thread_pool_size in puppet for undercloud tuning
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: puppet-ironic
Version: 13.0 (Queens)
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: Upstream M1
: ---
Assignee: Riccardo Pittau
QA Contact: mlammon
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-09-19 17:17 UTC by Andreas Karis
Modified: 2021-12-10 17:44 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1631009
Environment:
Last Closed: 2019-05-16 09:57:44 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
OpenStack gerrit 630712 0 None MERGED Expose executor_thread_pool_size 2021-01-29 13:35:13 UTC
OpenStack gerrit 630718 0 None MERGED Expose executor_thread_pool_size 2021-01-29 13:35:13 UTC
Red Hat Issue Tracker OSP-11653 0 None None None 2021-12-10 17:44:23 UTC

Description Andreas Karis 2018-09-19 17:17:10 UTC
Description of problem:
Requesting the following feature enhancement: implement ironic::rpc_thread_pool_size for undercloud tuning

The undercloud allows us to push custom hierdata to make configuration
persistent:
~~~
undercloud.conf:
hieradata_override = /home/stack/custom_hiera.yaml
~~~

However, for https://access.redhat.com/articles/3597351 , I need to modify a custom ironic parameter for which no
puppet manifest exists yet (at least by grepping, I cannot find it):
~~~
ironic::config::ironic_config:
  DEFAULT/rpc_thread_pool_size:
    value: 8
~~~


ironic::config is not included by instack-undercloud and I created BZ1631009 to include this. However, perhaps we can add the same parameter to the ironic class so that e.g. ironic::rpc_thread_pool_size: <x>  works?

Comment 1 Andreas Karis 2018-09-19 17:21:44 UTC
alternatively executor_thread_pool_size as I think that rpc_thread_pool_size is deprecated and superseded by executor_thread_pool_size

Comment 2 Dmitry Tantsur 2019-01-02 12:19:51 UTC
Low hanging fruit, but will need to be exposed in puppet-oslo first (https://github.com/openstack/puppet-oslo/blob/master/manifests/messaging/default.pp), since this option belongs to oslo.messaging, not ironic.


Note You need to log in before you can comment on or make changes to this bug.