Bug 1631025 - missing env python line from taskwarrior hook
Summary: missing env python line from taskwarrior hook
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: timew
Version: 30
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ankur Sinha (FranciscoD)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-09-19 19:06 UTC by Langdon White
Modified: 2019-10-26 17:21 UTC (History)
1 user (show)

Fixed In Version: timew-1.1.1-5.fc30 timew-1.1.1-5.fc31
Clone Of:
Environment:
Last Closed: 2019-10-09 16:53:26 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Langdon White 2018-09-19 19:06:36 UTC
Description of problem:
The hook for taskwarrior doesn't work out of the box because it doesn't have 

#!/usr/bin/env python

at the top. 

Weirdly, this is fixed upstream in the 1.1.1 tarball. However, in the rpm timew.x86_64 1.1.1-1.fc28 the file does not have this change. The file in question lands in /usr/share/doc/timew/ext/on-modify.timewarrior.

Did the update not actually go through? Is upstream changing the contents of a released version?

Comment 1 Ben Cotton 2019-05-02 20:52:40 UTC
This message is a reminder that Fedora 28 is nearing its end of life.
On 2019-May-28 Fedora will stop maintaining and issuing updates for
Fedora 28. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora 'version' of '28'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 28 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 2 Ankur Sinha (FranciscoD) 2019-05-04 07:19:47 UTC
Sorry---missed this one. I'll take a look this week.

Comment 3 Ankur Sinha (FranciscoD) 2019-05-27 16:04:55 UTC
(In reply to Langdon White from comment #0)
> Description of problem:
> The hook for taskwarrior doesn't work out of the box because it doesn't have 
> 
> #!/usr/bin/env python
> 
> at the top. 
> 
> Weirdly, this is fixed upstream in the 1.1.1 tarball. However, in the rpm
> timew.x86_64 1.1.1-1.fc28 the file does not have this change. The file in
> question lands in /usr/share/doc/timew/ext/on-modify.timewarrior.
> 
> Did the update not actually go through? Is upstream changing the contents of
> a released version?

I checked the spec, so I remember why this is. We remove the shebang in the package since the hook and other bits go into /usr/share/doc/. So they should not have the +x file mode or the shebang there---rpmlint must've pointed this out during the review.

https://src.fedoraproject.org/rpms/timew/blob/master/f/timew.spec#_21

If we want the shebang in there, it should be installed elsewhere---suggestions? I could add a Fedora.readme explaining that the shebangs need to be added in the meantime.

Cheers
Ankur

Comment 4 Ankur Sinha (FranciscoD) 2019-09-21 17:12:49 UTC
Hi Langdon,

Any thoughts on this?

Cheers,
Ankur

Comment 5 Fedora Update System 2019-10-01 14:01:21 UTC
FEDORA-2019-ba6f3e6c5d has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-ba6f3e6c5d

Comment 6 Fedora Update System 2019-10-01 14:01:21 UTC
FEDORA-2019-6b179aed5a has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-6b179aed5a

Comment 7 Fedora Update System 2019-10-02 15:41:56 UTC
timew-1.1.1-5.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-6b179aed5a

Comment 8 Fedora Update System 2019-10-02 15:53:23 UTC
timew-1.1.1-5.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-ba6f3e6c5d

Comment 9 Fedora Update System 2019-10-09 16:53:26 UTC
timew-1.1.1-5.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2019-10-26 17:21:01 UTC
timew-1.1.1-5.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.