RDO tickets are now tracked in Jira https://issues.redhat.com/projects/RDO/issues/
Bug 1631251 - Package Review: openstack-placement
Summary: Package Review: openstack-placement
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: RDO
Classification: Community
Component: Package Review
Version: trunk
Hardware: x86_64
OS: Linux
high
high
Target Milestone: ---
: trunk
Assignee: Alfredo Moralejo
QA Contact: hguemar
URL:
Whiteboard:
Depends On:
Blocks: 1625281 RDO-STEIN 1645178
TreeView+ depends on / blocked
 
Reported: 2018-09-20 10:05 UTC by Lee Yarwood
Modified: 2020-07-23 11:01 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-23 11:01:36 UTC
Embargoed:
amoralej: rdo-review+


Attachments (Terms of Use)

Description Lee Yarwood 2018-09-20 10:05:10 UTC
Description of problem:

OpenStack Placement provides an HTTP service for managing, selecting, and claiming providers of classes of inventory representing available resources in a cloud.

https://github.com/openstack/placement

A WIP dist-git repo can be found below:

https://gitlab.com/lyarwood/placement-distgit

Comment 1 Lee Yarwood 2018-09-20 10:27:43 UTC
# licensecheck -r .
./.coveragerc: *No copyright* UNKNOWN
./.gitreview: *No copyright* UNKNOWN
./.stestr.conf: *No copyright* UNKNOWN
./.zuul.yaml: *No copyright* UNKNOWN
./CONTRIBUTING.rst: *No copyright* UNKNOWN
./HACKING.rst: *No copyright* UNKNOWN
./LICENSE: *No copyright* Apache (v2.0)
./README.rst: *No copyright* UNKNOWN
./babel.cfg: *No copyright* UNKNOWN
./bindep.txt: *No copyright* UNKNOWN
./lower-constraints.txt: *No copyright* UNKNOWN
./requirements.txt: *No copyright* UNKNOWN
./setup.cfg: *No copyright* Apache
./setup.py: Apache (v2.0) GENERATED FILE
./test-requirements.txt: *No copyright* UNKNOWN
./tox.ini: *No copyright* UNKNOWN
./doc/README.rst: *No copyright* UNKNOWN
./doc/requirements.txt: *No copyright* UNKNOWN
./gate/README: *No copyright* UNKNOWN
./gate/post_test_hook.sh: *No copyright* UNKNOWN
./gate/post_test_perf_check.sh: *No copyright* UNKNOWN
./placement/auth.py: *No copyright* Apache (v2.0)
./placement/context.py: *No copyright* Apache (v2.0)
./placement/db_api.py: *No copyright* Apache (v2.0)
./placement/deploy.py: *No copyright* Apache (v2.0)
./placement/direct.py: *No copyright* Apache (v2.0)
./placement/errors.py: *No copyright* Apache (v2.0)
./placement/exception.py: *No copyright* Apache (v2.0)
./placement/fault_wrap.py: *No copyright* Apache (v2.0)
./placement/handler.py: *No copyright* Apache (v2.0)
./placement/i18n.py: Apache (v2.0)
./placement/lib.py: *No copyright* Apache (v2.0)
./placement/microversion.py: *No copyright* Apache (v2.0)
./placement/policy.py: *No copyright* Apache (v2.0)
./placement/rc_fields.py: *No copyright* Apache (v2.0)
./placement/requestlog.py: *No copyright* Apache (v2.0)
./placement/resource_class_cache.py: *No copyright* Apache (v2.0)
./placement/rest_api_version_history.rst: *No copyright* UNKNOWN
./placement/util.py: *No copyright* Apache (v2.0)
./placement/wsgi.py: *No copyright* Apache (v2.0)
./placement/wsgi_wrapper.py: *No copyright* Apache (v2.0)
./tools/flake8wrap.sh: *No copyright* UNKNOWN
./api-ref/ext/validator.py: *No copyright* Apache (v2.0)
./api-ref/source/aggregates.inc: *No copyright* UNKNOWN
./api-ref/source/allocation_candidates.inc: *No copyright* UNKNOWN
./api-ref/source/allocations.inc: *No copyright* UNKNOWN
./api-ref/source/conf.py: *No copyright* Apache (v2.0) GENERATED FILE
./api-ref/source/index.rst: *No copyright* UNKNOWN
./api-ref/source/inventories.inc: *No copyright* UNKNOWN
./api-ref/source/inventory.inc: *No copyright* UNKNOWN
./api-ref/source/parameters.yaml: *No copyright* UNKNOWN
./api-ref/source/request-ids.inc: *No copyright* GENERATED FILE
./api-ref/source/reshaper.inc: *No copyright* UNKNOWN
./api-ref/source/resource_class.inc: *No copyright* UNKNOWN
./api-ref/source/resource_classes.inc: *No copyright* UNKNOWN
./api-ref/source/resource_provider.inc: *No copyright* UNKNOWN
./api-ref/source/resource_provider_allocations.inc: *No copyright* UNKNOWN
./api-ref/source/resource_provider_traits.inc: *No copyright* UNKNOWN
./api-ref/source/resource_provider_usages.inc: *No copyright* UNKNOWN
./api-ref/source/resource_providers.inc: *No copyright* UNKNOWN
./api-ref/source/root.inc: *No copyright* UNKNOWN
./api-ref/source/traits.inc: *No copyright* UNKNOWN
./api-ref/source/usages.inc: *No copyright* UNKNOWN
./doc/source/conf.py: *No copyright* Apache (v2.0)
./doc/source/index.rst: *No copyright* Apache (v2.0)
./etc/placement/README-policy.yaml.txt: *No copyright* GENERATED FILE
./etc/placement/config-generator.conf: *No copyright* UNKNOWN
./etc/placement/policy-generator.conf: *No copyright* UNKNOWN
./placement/conf/__init__.py: Apache (v2.0)
./placement/conf/api.py: Apache (v2.0)
./placement/conf/base.py: Apache (v2.0) GENERATED FILE
./placement/conf/database.py: Apache (v2.0)
./placement/conf/keystone.py: *No copyright* Apache (v2.0)
./placement/conf/opts.py: Apache (v2.0)
./placement/conf/paths.py: Apache (v2.0)
./placement/conf/placement.py: *No copyright* Apache (v2.0)
./placement/conf/service.py: Apache (v2.0)
./placement/conf/service_token.py: *No copyright* Apache (v2.0)
./placement/conf/utils.py: Apache (v2.0)
./placement/conf/wsgi.py: Apache (v2.0)
./placement/db/base.py: Apache (v2.0)
./placement/db/constants.py: *No copyright* Apache (v2.0)
./placement/db/migration.py: Apache (v2.0)
./placement/handlers/aggregate.py: *No copyright* Apache (v2.0)
./placement/handlers/allocation.py: *No copyright* Apache (v2.0)
./placement/handlers/allocation_candidate.py: *No copyright* Apache (v2.0)
./placement/handlers/inventory.py: *No copyright* Apache (v2.0)
./placement/handlers/reshaper.py: *No copyright* Apache (v2.0)
./placement/handlers/resource_class.py: *No copyright* Apache (v2.0)
./placement/handlers/resource_provider.py: *No copyright* Apache (v2.0)
./placement/handlers/root.py: *No copyright* Apache (v2.0)
./placement/handlers/trait.py: *No copyright* Apache (v2.0)
./placement/handlers/usage.py: *No copyright* Apache (v2.0)
./placement/objects/consumer.py: *No copyright* Apache (v2.0)
./placement/objects/project.py: *No copyright* Apache (v2.0)
./placement/objects/resource_provider.py: *No copyright* Apache (v2.0)
./placement/objects/user.py: *No copyright* Apache (v2.0)
./placement/policies/__init__.py: *No copyright* Apache (v2.0)
./placement/policies/aggregate.py: *No copyright* Apache (v2.0)
./placement/policies/allocation.py: *No copyright* Apache (v2.0)
./placement/policies/allocation_candidate.py: *No copyright* Apache (v2.0)
./placement/policies/base.py: *No copyright* Apache (v2.0)
./placement/policies/inventory.py: *No copyright* Apache (v2.0)
./placement/policies/reshaper.py: *No copyright* Apache (v2.0)
./placement/policies/resource_class.py: *No copyright* Apache (v2.0)
./placement/policies/resource_provider.py: *No copyright* Apache (v2.0)
./placement/policies/trait.py: *No copyright* Apache (v2.0)
./placement/policies/usage.py: *No copyright* Apache (v2.0)
./placement/schemas/aggregate.py: *No copyright* Apache (v2.0)
./placement/schemas/allocation.py: *No copyright* Apache (v2.0)
./placement/schemas/allocation_candidate.py: *No copyright* Apache (v2.0)
./placement/schemas/common.py: *No copyright* Apache (v2.0)
./placement/schemas/inventory.py: *No copyright* Apache (v2.0)
./placement/schemas/reshaper.py: *No copyright* Apache (v2.0)
./placement/schemas/resource_class.py: *No copyright* Apache (v2.0)
./placement/schemas/resource_provider.py: *No copyright* Apache (v2.0)
./placement/schemas/trait.py: *No copyright* Apache (v2.0)
./placement/schemas/usage.py: *No copyright* Apache (v2.0)
./placement/tests/README.rst: *No copyright* UNKNOWN
./placement/tests/fixtures.py: Apache (v2.0)
./releasenotes/notes/allocation-candidates-limit-37fe5c2ce57daf7f.yaml: *No copyright* UNKNOWN
./releasenotes/notes/allocation-candidates-traits-1adf079ed0c6563c.yaml: *No copyright* UNKNOWN
./releasenotes/notes/allocation_candidates_support_member_of-92f7e1440ed63fe7.yaml: *No copyright* UNKNOWN
./releasenotes/notes/allow-reserved-equal-total-inventory-fe93584dd28c460d.yaml: *No copyright* UNKNOWN
./releasenotes/notes/bp-granular-placement-policy-65722fc6d7cb1359.yaml: *No copyright* UNKNOWN
./releasenotes/notes/bp-symmetric-allocations-6ff7b270c32dcb7d.yaml: *No copyright* UNKNOWN
./releasenotes/notes/bug-1732000-log-options-6db2cc8c747145ca.yaml: *No copyright* UNKNOWN
./releasenotes/notes/consumer_generation-f576ac2594b24e2e.yaml: *No copyright* UNKNOWN
./releasenotes/notes/delete-inventories-placement-api-13582910371308c4.yaml: *No copyright* UNKNOWN
./releasenotes/notes/idempotent-put-resource-class-dc7a267c823b7995.yaml: *No copyright* UNKNOWN
./releasenotes/notes/multi-member-of-4f9518a96652c0c6.yaml: *No copyright* UNKNOWN
./releasenotes/notes/nested-resource-providers-allocation-candidates-66c1c5b0a3e93513.yaml: *No copyright* UNKNOWN
./releasenotes/notes/placement-aggregate-generation-9dad79fb0356fcc0.yaml: *No copyright* UNKNOWN
./releasenotes/notes/placement-allocation-candidates-1114a843755b93c4.yaml: *No copyright* UNKNOWN
./releasenotes/notes/placement-allocations-link-in-get-resource-providers-0b1d26a264eceb4b.yaml: *No copyright* UNKNOWN
./releasenotes/notes/placement-api-endpoint-interface-set-29af8b9400ce7775.yaml: *No copyright* UNKNOWN
./releasenotes/notes/placement-api-member-of-d8a08d0d0c5700d7.yaml: *No copyright* UNKNOWN
./releasenotes/notes/placement-cors-c7a83e8c63787736.yaml: *No copyright* UNKNOWN
./releasenotes/notes/placement-database-2e087f379273535d.yaml: *No copyright* UNKNOWN
./releasenotes/notes/placement-error-code-fcbbf5d45560984e.yaml: *No copyright* UNKNOWN
./releasenotes/notes/placement-forbidden-traits-ace037856aa29a09.yaml: *No copyright* UNKNOWN
./releasenotes/notes/placement-generation-from-create-provider-203a0ac1ebfe64d9.yaml: *No copyright* UNKNOWN
./releasenotes/notes/placement-granular-resource-requests-944f9b73f306429f.yaml: *No copyright* UNKNOWN
./releasenotes/notes/placement-incomplete-consumer-configuration-b775dac1bcd34f9d.yaml: *No copyright* UNKNOWN
./releasenotes/notes/placement-last-modified-cf43aece4c54fc97.yaml: *No copyright* UNKNOWN
./releasenotes/notes/placement-required-traits-on-list-resource-providers-fab11cdb36cd3502.yaml: *No copyright* UNKNOWN
./releasenotes/notes/placement-rest-api-filter-providers-by-resources-0ab51c9766fe654f.yaml: *No copyright* UNKNOWN
./releasenotes/notes/placement-rest-api-nested-resource-providers-552a923a96d7adca.yaml: *No copyright* UNKNOWN
./releasenotes/notes/placement-rest-custom-resource-classes-a3f2175772983b0a.yaml: *No copyright* UNKNOWN
./releasenotes/notes/placement-return-all-resources-bfc7e3f8b5151e28.yaml: *No copyright* UNKNOWN
./releasenotes/notes/placement-traits-api-efa17d46ea1b616b.yaml: *No copyright* UNKNOWN
./releasenotes/notes/post-allocations-427581fa41671820.yaml: *No copyright* UNKNOWN
./doc/source/configuration/config.rst: *No copyright* UNKNOWN
./doc/source/configuration/index.rst: *No copyright* UNKNOWN
./doc/source/configuration/policy.rst: *No copyright* UNKNOWN
./doc/source/configuration/sample-config.rst: *No copyright* GENERATED FILE
./doc/source/configuration/sample-policy.rst: *No copyright* GENERATED FILE
./doc/source/contributor/api-ref-guideline.rst: *No copyright* UNKNOWN
./doc/source/contributor/index.rst: *No copyright* Apache (v2.0)
./doc/source/install/controller-install-obs.rst: *No copyright* UNKNOWN
./doc/source/install/controller-install-rdo.rst: *No copyright* UNKNOWN
./doc/source/install/controller-install-ubuntu.rst: *No copyright* UNKNOWN
./doc/source/install/note_configuration_vary_by_distribution.rst: *No copyright* UNKNOWN
./placement/db/sqlalchemy/api_models.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/migration.py: Apache (v2.0)
./placement/tests/functional/base.py: *No copyright* Apache (v2.0)
./placement/tests/functional/test_api.py: *No copyright* Apache (v2.0)
./placement/tests/functional/test_direct.py: *No copyright* Apache (v2.0)
./placement/tests/functional/test_verify_policy.py: *No copyright* Apache (v2.0)
./placement/tests/unit/policy_fixture.py: Apache (v2.0)
./placement/tests/unit/test_context.py: *No copyright* Apache (v2.0)
./placement/tests/unit/test_db_conf.py: *No copyright* Apache (v2.0)
./placement/tests/unit/test_deploy.py: *No copyright* Apache (v2.0)
./placement/tests/unit/test_fault_wrap.py: *No copyright* Apache (v2.0)
./placement/tests/unit/test_handler.py: *No copyright* Apache (v2.0)
./placement/tests/unit/test_microversion.py: *No copyright* Apache (v2.0)
./placement/tests/unit/test_policy.py: *No copyright* Apache (v2.0)
./placement/tests/unit/test_requestlog.py: *No copyright* Apache (v2.0)
./placement/tests/unit/test_util.py: *No copyright* Apache (v2.0)
./api-ref/source/samples/aggregates/get-aggregates-1.19.json: *No copyright* UNKNOWN
./api-ref/source/samples/aggregates/get-aggregates.json: *No copyright* UNKNOWN
./api-ref/source/samples/aggregates/update-aggregates-1.19.json: *No copyright* UNKNOWN
./api-ref/source/samples/aggregates/update-aggregates-request-1.19.json: *No copyright* UNKNOWN
./api-ref/source/samples/aggregates/update-aggregates-request.json: *No copyright* UNKNOWN
./api-ref/source/samples/aggregates/update-aggregates.json: *No copyright* UNKNOWN
./api-ref/source/samples/allocation_candidates/get-allocation_candidates-1.12.json: *No copyright* UNKNOWN
./api-ref/source/samples/allocation_candidates/get-allocation_candidates-1.17.json: *No copyright* UNKNOWN
./api-ref/source/samples/allocation_candidates/get-allocation_candidates-1.29.json: *No copyright* UNKNOWN
./api-ref/source/samples/allocation_candidates/get-allocation_candidates.json: *No copyright* UNKNOWN
./api-ref/source/samples/allocations/get-allocations-1.28.json: *No copyright* UNKNOWN
./api-ref/source/samples/allocations/get-allocations.json: *No copyright* UNKNOWN
./api-ref/source/samples/allocations/manage-allocations-request-1.28.json: *No copyright* UNKNOWN
./api-ref/source/samples/allocations/manage-allocations-request.json: *No copyright* UNKNOWN
./api-ref/source/samples/allocations/update-allocations-request-1.12.json: *No copyright* UNKNOWN
./api-ref/source/samples/allocations/update-allocations-request-1.28.json: *No copyright* UNKNOWN
./api-ref/source/samples/allocations/update-allocations-request.json: *No copyright* UNKNOWN
./api-ref/source/samples/inventories/get-inventories.json: *No copyright* UNKNOWN
./api-ref/source/samples/inventories/get-inventory.json: *No copyright* UNKNOWN
./api-ref/source/samples/inventories/update-inventories-request.json: *No copyright* UNKNOWN
./api-ref/source/samples/inventories/update-inventories.json: *No copyright* UNKNOWN
./api-ref/source/samples/inventories/update-inventory-request.json: *No copyright* UNKNOWN
./api-ref/source/samples/inventories/update-inventory.json: *No copyright* UNKNOWN
./api-ref/source/samples/reshaper/post-reshaper-1.30.json: *No copyright* UNKNOWN
./api-ref/source/samples/resource_classes/create-resource_classes-request.json: *No copyright* UNKNOWN
./api-ref/source/samples/resource_classes/get-resource_class.json: *No copyright* UNKNOWN
./api-ref/source/samples/resource_classes/get-resource_classes.json: *No copyright* UNKNOWN
./api-ref/source/samples/resource_classes/update-resource_class-request.json: *No copyright* UNKNOWN
./api-ref/source/samples/resource_classes/update-resource_class.json: *No copyright* UNKNOWN
./api-ref/source/samples/resource_provider_allocations/get-resource_provider_allocations.json: *No copyright* UNKNOWN
./api-ref/source/samples/resource_provider_traits/get-resource_provider-traits.json: *No copyright* UNKNOWN
./api-ref/source/samples/resource_provider_traits/update-resource_provider-traits-request.json: *No copyright* UNKNOWN
./api-ref/source/samples/resource_provider_traits/update-resource_provider-traits.json: *No copyright* UNKNOWN
./api-ref/source/samples/resource_provider_usages/get-resource_provider_usages.json: *No copyright* UNKNOWN
./api-ref/source/samples/resource_providers/create-resource_provider.json: *No copyright* UNKNOWN
./api-ref/source/samples/resource_providers/create-resource_providers-request.json: *No copyright* UNKNOWN
./api-ref/source/samples/resource_providers/get-resource_provider.json: *No copyright* UNKNOWN
./api-ref/source/samples/resource_providers/get-resource_providers.json: *No copyright* UNKNOWN
./api-ref/source/samples/resource_providers/update-resource_provider-request.json: *No copyright* UNKNOWN
./api-ref/source/samples/resource_providers/update-resource_provider.json: *No copyright* UNKNOWN
./api-ref/source/samples/root/get-root.json: *No copyright* UNKNOWN
./api-ref/source/samples/traits/get-traits.json: *No copyright* UNKNOWN
./api-ref/source/samples/usages/get-usages.json: *No copyright* UNKNOWN
./placement/tests/functional/db/test_allocation_candidates.py: *No copyright* Apache (v2.0)
./placement/tests/functional/db/test_base.py: *No copyright* Apache (v2.0)
./placement/tests/functional/db/test_consumer.py: *No copyright* Apache (v2.0)
./placement/tests/functional/db/test_project.py: *No copyright* Apache (v2.0)
./placement/tests/functional/db/test_reshape.py: *No copyright* Apache (v2.0)
./placement/tests/functional/db/test_resource_class_cache.py: *No copyright* Apache (v2.0)
./placement/tests/functional/db/test_resource_provider.py: *No copyright* Apache (v2.0)
./placement/tests/functional/db/test_user.py: *No copyright* Apache (v2.0)
./placement/tests/functional/fixtures/capture.py: *No copyright* Apache (v2.0)
./placement/tests/functional/fixtures/gabbits.py: *No copyright* Apache (v2.0)
./placement/tests/functional/fixtures/placement.py: *No copyright* Apache (v2.0)
./placement/tests/functional/gabbits/aggregate-policy.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/aggregate.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/allocation-bad-class.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/allocation-candidates-member-of.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/allocation-candidates-policy.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/allocation-candidates.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/allocations-1-12.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/allocations-1-8.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/allocations-1.28.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/allocations-bug-1714072.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/allocations-bug-1778591.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/allocations-bug-1778743.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/allocations-bug-1779717.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/allocations-policy.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/allocations-post.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/allocations.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/basic-http.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/bug-1674694.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/confirm-auth.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/cors.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/ensure-consumer.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/granular.yaml: *No copyright* Apache (v2.0)
./placement/tests/functional/gabbits/inventory-policy.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/inventory.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/microversion-bug-1724065.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/microversion.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/non-cors.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/reshaper-policy.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/reshaper.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/resource-class-in-use.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/resource-classes-1-6.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/resource-classes-1-7.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/resource-classes-last-modified.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/resource-classes-policy.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/resource-classes.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/resource-provider-aggregates.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/resource-provider-bug-1779818.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/resource-provider-duplication.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/resource-provider-links.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/resource-provider-policy.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/resource-provider-resources-query.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/resource-provider.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/shared-resources.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/traits-policy.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/traits.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/unicode.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/usage-policy.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/usage.yaml: *No copyright* UNKNOWN
./placement/tests/functional/gabbits/with-allocations.yaml: *No copyright* UNKNOWN
./placement/tests/unit/handlers/test_aggregate.py: *No copyright* Apache (v2.0)
./placement/tests/unit/objects/test_resource_provider.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/README: *No copyright* UNKNOWN
./placement/db/sqlalchemy/api_migrations/migrate_repo/migrate.cfg: *No copyright* UNKNOWN
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/001_cell_mapping.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/002_instance_mapping.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/003_host_mapping.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/004_add_request_spec.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/005_flavors.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/006_build_request.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/007_instance_mapping_nullable_cellid.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/008_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/009_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/010_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/011_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/012_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/013_build_request_extended_attrs.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/014_keypairs.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/015_build_request_nullable_columns.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/016_resource_providers.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/017_aggregates.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/018_instance_groups.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/019_build_request_add_block_device_mapping.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/020_block_device_mappings_mediumtext.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/021_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/022_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/023_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/024_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/025_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/026_add_resource_classes.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/027_quotas.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/028_build_requests_instance_mediumtext.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/029_aggregates.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/030_require_cell_setup.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/031_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/032_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/033_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/034_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/035_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/036_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/037_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/038_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/039_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/040_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/041_resource_provider_traits.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/042_build_requests_add_tags.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/043_consumers.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/044_add_projects_users.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/045_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/046_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/047_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/048_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/049_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/050_flavors_add_description.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/051_nested_resource_providers.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/052_request_specs_spec_mediumtext.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/053_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/054_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/055_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/056_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/057_placeholder.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/058_cell_mapping_add_disabled.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/059_add_consumer_generation.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/060_instance_group_policy_add_rules.py: *No copyright* Apache (v2.0)
./placement/db/sqlalchemy/api_migrations/migrate_repo/versions/061_instance_mapping_add_queued_for_delete.py: *No copyright* Apache (v2.0)

Comment 2 Lee Yarwood 2018-09-20 11:55:10 UTC
fedora-review output below, this isn't a formal review comment just a note as the spec is still WIP, I'll work through the issues highlighted here now:

https://paste.fedoraproject.org/paste/onVCcTuKSgynbFbTK44CMA

Comment 3 Alfredo Moralejo 2018-11-13 17:22:44 UTC
official package review.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file license.png is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "*No copyright* Apache", "Unknown or
     generated", "*No copyright* Apache (v2.0)". 195 files have unknown
     license. Detailed output of licensecheck in /tmp/openstack-
     placement/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /etc/logrotate.d
[x]: Package contains no bundled libraries without FPC exception.
[-]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     openstack-placement-common , openstack-placement-api , openstack-
     placement-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define upstream_version
     0.0.1.dev10817
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint


Installation errors
-------------------
INFO: mock.py version 1.4.13 starting (python version = 3.6.6)...
Start: init plugins
INFO: selinux disabled
Finish: init plugins
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled yum cache
Start: cleaning yum metadata
Finish: cleaning yum metadata
INFO: enabled HW Info plugin
Mock Version: 1.4.13
INFO: Mock Version: 1.4.13
Finish: chroot init
INFO: installing package(s): /tmp/openstack-placement/results/openstack-placement-common-0.0.1-0.20181113082814.6bb6c0b.el7.noarch.rpm /tmp/openstack-placement/results/openstack-placement-doc-0.0.1-0.20181113082814.6bb6c0b.el7.noarch.rpm /tmp/openstack-placement/results/openstack-placement-api-0.0.1-0.20181113082814.6bb6c0b.el7.noarch.rpm
ERROR: Command failed: 
 # /usr/bin/yum-deprecated --installroot /var/lib/mock/dlrn-centos-master-x86_64-1/root/ --releasever 7 install /tmp/openstack-placement/results/openstack-placement-common-0.0.1-0.20181113082814.6bb6c0b.el7.noarch.rpm /tmp/openstack-placement/results/openstack-placement-doc-0.0.1-0.20181113082814.6bb6c0b.el7.noarch.rpm /tmp/openstack-placement/results/openstack-placement-api-0.0.1-0.20181113082814.6bb6c0b.el7.noarch.rpm



Rpmlint
-------
Checking: openstack-placement-common-0.0.1-0.20181113082814.6bb6c0b.el7.noarch.rpm
          openstack-placement-api-0.0.1-0.20181113082814.6bb6c0b.el7.noarch.rpm
          openstack-placement-doc-0.0.1-0.20181113082814.6bb6c0b.el7.noarch.rpm
          openstack-placement-0.0.1-0.20181113082814.6bb6c0b.el7.src.rpm
openstack-placement-common.noarch: E: no-changelogname-tag
openstack-placement-common.noarch: E: incoherent-logrotate-file /etc/logrotate.d/openstack-placement
openstack-placement-common.noarch: W: non-standard-gid /etc/placement/placement.conf placement
openstack-placement-common.noarch: E: non-readable /etc/placement/placement.conf 640
openstack-placement-common.noarch: W: non-standard-gid /etc/placement/policy.json placement
openstack-placement-common.noarch: E: non-readable /etc/placement/policy.json 640
openstack-placement-common.noarch: W: non-standard-gid /usr/share/placement/placement-dist.conf placement
openstack-placement-common.noarch: E: non-readable /usr/share/placement/placement-dist.conf 640
openstack-placement-common.noarch: W: non-standard-uid /var/log/placement placement
openstack-placement-common.noarch: E: non-standard-dir-perm /var/log/placement 750
openstack-placement-api.noarch: E: no-changelogname-tag
openstack-placement-api.noarch: W: no-documentation
openstack-placement-api.noarch: E: non-readable /etc/httpd/conf.d/00-placement-api.conf 640
openstack-placement-api.noarch: W: no-manual-page-for-binary placement-api
openstack-placement-doc.noarch: E: no-changelogname-tag
openstack-placement.src: E: no-changelogname-tag
openstack-placement.src: W: strange-permission placement-api.conf 666
openstack-placement.src: W: strange-permission placement-dist.conf 666
openstack-placement.src: W: strange-permission placement.logrotate 666
openstack-placement.src: W: strange-permission policy.json 666
openstack-placement.src: W: invalid-url Source0: openstack-placement-0.0.1.dev10817-0.20181113082814.6bb6c0b.tar.gz
4 packages and 0 specfiles checked; 10 errors, 11 warnings.




Requires
--------
openstack-placement-common (rpmlib, GLIBC filtered):
    /bin/sh
    config(openstack-placement-common)
    python2-placement

openstack-placement-doc (rpmlib, GLIBC filtered):

openstack-placement-api (rpmlib, GLIBC filtered):
    /usr/bin/python2
    config(openstack-placement-api)
    httpd
    mod_wsgi
    openstack-placement-common



Provides
--------
openstack-placement-common:
    config(openstack-placement-common)
    openstack-placement-common

openstack-placement-doc:
    openstack-placement-doc

openstack-placement-api:
    config(openstack-placement-api)
    openstack-placement-api



Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m dlrn-master -rn openstack-placement-0.0.1-0.20181113082814.6bb6c0b.fc28.src.rpm
Buildroot used: dlrn-centos-master-x86_64-1
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6


Some notes:

- Error installing packages is because of fedora-review issue.
- changelog is not used in DLRN specs.

Package is APPROVED

Comment 4 Yatin Karel 2020-07-23 11:01:36 UTC
Package available since stein, closing.


Note You need to log in before you can comment on or make changes to this bug.