Bug 163151 - RPM scripts fail on cygwin (a.ka. psm->sq.reaper = 0 doesn't work)
RPM scripts fail on cygwin (a.ka. psm->sq.reaper = 0 doesn't work)
Status: CLOSED UPSTREAM
Product: Fedora
Classification: Fedora
Component: rpm (Show other bugs)
4
other Linux
medium Severity medium
: ---
: ---
Assigned To: Paul Nasrat
Mike McLean
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2005-07-13 11:10 EDT by Mark Hatle
Modified: 2007-11-30 17:11 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2006-07-07 00:21:20 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Enable waitpid for cygwin (3.68 KB, patch)
2005-07-13 11:10 EDT, Mark Hatle
no flags Details | Diff

  None (edit)
Description Mark Hatle 2005-07-13 11:10:20 EDT
Description of problem:
RPM scripts fail on cygwin due to bugs in cygwin's signal handling.  To work
around this issue, I set the psm->sq.reaper = 0 for cygwin.  This should envoke
the waitpid handler instead of the numerous threaded voodoo.

Version-Release number of selected component (if applicable):
RPM 4.3+

How reproducible:
In lib/psm.c change psm->sq.reaper = 0.  Scripts will no longer run properly.

Additional info:

The problem was determined to be that "rpmsqInsert" normally resets all of the
"sq" values.  However, when the reaper = 0, rpmsqInsert is never called, so they
have to be manually reset.

Also the sq->pipes only get setup if the reaper = 1.  So the closing/monitoring
of these needs to be avoided when reaper = 0.

I have attached a patch that we used to work around this.  Unfortunatly it won't
cleanly apply to anything but RPM's HEAD branch.  (It works with James Olin
Oden's dead lock patch.. see rpm-devel mailing list, 1/28/05.)
Comment 1 Mark Hatle 2005-07-13 11:10:20 EDT
Created attachment 116711 [details]
Enable waitpid for cygwin
Comment 2 Jeff Johnson 2006-07-07 00:21:20 EDT
Most of the patch was long since incorporated into rpm-4.4.3 (iirc).

Meanwhile, this patch avoids blocking the child on the parent's pipe close if waitpid
(i.e. sq->reaper = 0) is compiled in:
Index: rpmsq.c
===============================================================
====
RCS file: /cvs/devel/rpm/rpmio/rpmsq.c,v
retrieving revision 1.17.2.6
diff -u -b -B -w -p -r1.17.2.6 rpmsq.c
--- rpmsq.c     16 Nov 2005 13:59:38 -0000      1.17.2.6
+++ rpmsq.c     7 Jul 2006 04:26:54 -0000
@@ -449,6 +449,7 @@ fprintf(stderr, "    Enable(%p): %p\n", 
        /* Block to permit parent time to wait. */
 /*@-bounds@*/
        xx = close(sq->pipes[1]);
+       if (sq->reaper)
        xx = read(sq->pipes[0], &yy, sizeof(yy));
        xx = close(sq->pipes[0]);
        sq->pipes[0] = sq->pipes[1] = -1;

Note You need to log in before you can comment on or make changes to this bug.