Bug 1631814

Description of problem:
We discovered issue in bug #1569466, which uses this macro. If selinux-policy-targeted is not (yet) installed, it would emit tracebacks from semanage. Because that fail happens inside for, any failures are not reported to rpm. It just emits errors to stderr and would not set the variable.


Version-Release number of selected component (if applicable):
selinux-policy-3.13.1-166.el7.noarch

How reproducible:
always

Steps to Reproduce:
1. yum remove selinux-policy-targeted
2. yum install bind
3.

Actual results:
Traceback (most recent call last):
  File "/usr/sbin/semanage", line 32, in <module>
    import seobject
  File "/usr/lib64/python2.7/site-packages/seobject/__init__.py", line 36, in <module>
    import sepolicy
  File "/usr/lib64/python2.7/site-packages/sepolicy/__init__.py", line 930, in <module>
    raise e
ValueError: No SELinux Policy installed
Traceback (most recent call last):
  File "/usr/sbin/semanage", line 32, in <module>
    import seobject
  File "/usr/lib64/python2.7/site-packages/seobject/__init__.py", line 36, in <module>
    import sepolicy
  File "/usr/lib64/python2.7/site-packages/sepolicy/__init__.py", line 930, in <module>
    raise e
ValueError: No SELinux Policy installed
Traceback (most recent call last):
  File "/usr/sbin/semanage", line 32, in <module>
    import seobject
  File "/usr/lib64/python2.7/site-packages/seobject/__init__.py", line 36, in <module>
    import sepolicy
  File "/usr/lib64/python2.7/site-packages/sepolicy/__init__.py", line 930, in <module>
    raise e
ValueError: No SELinux Policy installed


Expected results:


Additional info:
Second problem with this macro was found. It relies on text output, but that output is locale dependent. When testing it in 1minutetip with different locale, I found it is not set back to original value on uninstallation. It has different output and output does not contain on and off.

# cat /etc/selinux/targeted/rpmbooleans.custom 
# This file is managed by macros.selinux-policy. Do not edit it manually
boolean -m --named_write_master_zones       (vypnout,vypnout)  Allow named to write master zones named_write_master_zones

That comes from LANG=cs_CZ.UTF-8