Description of problem:

unpackaged reports false positives
unpackaged crashes if no unpackaged (or false positives) file found

Version-Release number of selected component (if applicable):

sos-3.6-7.el7.noarch

How reproducible:

Always

Steps to Reproduce:

1. # sosreport --batch --build -o unpackaged


Actual results:

false positives are found

sort -u /var/tmp/sosreport-.../sos_strings/unpackaged/unpackaged|wc -l
10

Expected results:

no false positives are found on clean install

Additional info:

some rpms doesn't list paths without '/usr' (notice to maintainers needed?)

skip_paths = ["/bin/rpm", "/bin/mailx"] in redhat.py:mangle_package_path() is not complete

proof-of-concept patch

--- sos/plugins/unpackaged.py.orig	2018-09-24 08:13:07.047477426 -0400
+++ sos/plugins/unpackaged.py	2018-09-24 08:51:41.899477426 -0400
@@ -74,7 +74,8 @@ class Unpackaged(Plugin, RedHatPlugin):
 
         for d in get_env_path_list():
             all_fsystem += all_files_system(d)
-        not_packaged = [x for x in all_fsystem if x not in all_frpm]
+        not_packaged = [x for x in all_fsystem
+            if x not in all_frpm and "/usr" + x not in all_frpm]
         not_packaged_expanded = format_output(not_packaged)
         self.add_string_as_file('\n'.join(not_packaged_expanded), 'unpackaged')

prevents false positives

if the list is empty (expected on clean install) plugin crashes with

Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/sos/sosreport.py", line 1116, in collect_plugin
    plug.collect()
  File "/usr/lib/python2.7/site-packages/sos/plugins/__init__.py", line 949, in collect
    self._collect_strings()
  File "/usr/lib/python2.7/site-packages/sos/plugins/__init__.py", line 930, in _collect_strings
    content = string.splitlines()[0]
IndexError: list index out of range

this can be fixed with

--- sos/plugins/__init__.py.orig	2018-09-24 08:51:07.598477426 -0400
+++ sos/plugins/__init__.py	2018-09-24 08:51:30.877477426 -0400
@@ -725,7 +725,8 @@ class Plugin(object):
     def add_string_as_file(self, content, filename):
         """Add a string to the archive as a file named `filename`"""
         self.copy_strings.append((content, filename))
-        content = content.splitlines()[0]
+        # empty content has no first line
+        if content: content = content.splitlines()[0]
         if not isinstance(content, six.string_types):
             content = content.decode('utf8', 'ignore')
         self._log_debug("added string ...'%s' as '%s'" % (content, filename))
@@ -927,7 +928,8 @@ class Plugin(object):
 
     def _collect_strings(self):
         for string, file_name in self.copy_strings:
-            content = string.splitlines()[0]
+            # empty string has no first line
+            content = string.splitlines()[0] if string else string
             if not isinstance(content, six.string_types):
                 content = content.decode('utf8', 'ignore')
             self._log_info("collecting string ...'%s' as '%s'"