Bug 1632789
| Summary: | nbdkit fails to build: TLS handshake failed: The TLS connection was non-properly terminated. [rhel-7.6.z] | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Oneata Mircea Teodor <toneata> |
| Component: | nbdkit | Assignee: | Richard W.M. Jones <rjones> |
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 7.6 | CC: | jherrman, juzhou, mtessun, mxie, mzhan, ptoscano, rjones, tzheng, xiaodwan, zili |
| Target Milestone: | rc | Keywords: | ZStream |
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | nbdkit-1.2.6-1.el7_6.1 | Doc Type: | Bug Fix |
| Doc Text: |
Previously, the nbdkit package was configured with an incorrect priority for the TLS protocol. As a consequence, TLS connections connections to the NBD server did not work. This update fixes the TLS priority in nbdkit, which ensures proper functionality of TLS connections.
|
Story Points: | --- |
| Clone Of: | 1632220 | Environment: | |
| Last Closed: | 2018-11-27 01:19:19 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1632220 | ||
| Bug Blocks: | |||
|
Description
Oneata Mircea Teodor
2018-09-25 14:30:59 UTC
This is a one line change to the spec file: -%configure --disable-static --with-tls-priority=@NBDKIT,SYSTEM \ +%configure --disable-static --with-tls-priority=NORMAL \ This change is required in RHEL 7 only (both Fedora and RHEL 8 supports the @-syntax). Verify the bug with below builds: nbdkit-1.2.6-1.el7_6.1.src.rpm libguestfs-devel-1.38.2-12.el7_6.1.x86_64 libvirt-4.5.0-10.el7_6.2.x86_64 qemu-kvm-rhev-2.12.0-18.el7_6.1.x86_64 kernel-3.10.0-957.el7.x86_64 Steps: 1.Download nbdkit src.rpm package to local server and copy to /home 2.log into server with regular user and create .rpmmacros file containing: $ cat .rpmmacros %_topdir %(echo $HOME)/rpmbuild %_smp_mflags -j5 3.Resolve the dependence problem before rebuilding,then build nbdkit package from src package but the result is failed which has bug 1632231 to track $rpmbuild --rebuild nbdkit-1.2.6-1.el7.src.rpm .... Try running qemu directly without libvirt using this environment variable: export LIBGUESTFS_BACKEND=direct Original error from libvirt: internal error: process exited while connecting to monitor: 2018-10-17T07:36:51.288253Z qemu-kvm: -drive file=nbd:unix:/home/mxie/rpmbuild/BUILD/nbdkit-1.2.6/tests/cow.sock,format=raw,if=none,id=drive-scsi0-0-0-0,cache=writeback: Failed to connect socket /home/mxie/rpmbuild/BUILD/nbdkit-1.2.6/tests/cow.sock: Permission denied [code=1 int1=-1] ..... 4.Set environment variable and rebuild nbdkit package from src package again $ export LIBGUESTFS_BACKEND=direct $ rpmbuild --rebuild nbdkit-1.2.6-1.el7_6.1.src.rpm .... PASS: test-help.sh PASS: test-version.sh PASS: test-dump-config.sh PASS: test-help-plugin.sh PASS: test-version-plugin.sh PASS: test-version-filter.sh PASS: test-dump-plugin.sh PASS: test-start.sh PASS: test-single.sh PASS: test-captive.sh PASS: test-random-sock.sh PASS: test-tls.sh PASS: test-ipv4.sh PASS: test-socket-activation PASS: test-foreground.sh PASS: test-exit-with-parent PASS: test-parallel-file.sh PASS: test-parallel-nbd.sh PASS: test-vddk.sh PASS: test-python-exception.sh PASS: test-shebang-python.sh PASS: test-cache.sh PASS: test-cow.sh make[4]: Entering directory `/home/mxie/rpmbuild/BUILD/nbdkit-1.2.6/tests' make[4]: Nothing to be done for `all'. make[4]: Leaving directory `/home/mxie/rpmbuild/BUILD/nbdkit-1.2.6/tests' ============================================================================ Testsuite summary for nbdkit 1.2.6 ============================================================================ # TOTAL: 23 # PASS: 23 # SKIP: 0 # XFAIL: 0 # FAIL: 0 # XPASS: 0 # ERROR: 0 ============================================================================ .... 5.Can find below nbdkit packages in path /home/mxie/rpmbuild/RPMS/x86_64 $ ls /home/mxie/rpmbuild/RPMS/x86_64 nbdkit-1.2.6-1.el7.1.x86_64.rpm nbdkit-example-plugins-1.2.6-1.el7.1.x86_64.rpm nbdkit-basic-plugins-1.2.6-1.el7.1.x86_64.rpm nbdkit-plugin-python2-1.2.6-1.el7.1.x86_64.rpm nbdkit-debuginfo-1.2.6-1.el7.1.x86_64.rpm nbdkit-plugin-python-common-1.2.6-1.el7.1.x86_64.rpm nbdkit-devel-1.2.6-1.el7.1.x86_64.rpm nbdkit-plugin-vddk-1.2.6-1.el7.1.x86_64.rpm Hi rjones, Can build nbdkit packages from src package after setting environment variable, but the version of nbdkit packages is wrong, pls help to check this problem,thanks! The important thing is: > PASS: test-tls.sh I believe the version is wrong because when we build the real z-stream package something (Brew?) overrides the %dist tag to set it to %el7_1 or whatever. Because your local build doesn't override the %dist tag you get a different version (see https://mojo.redhat.com/docs/DOC-1052647). Thanks rjones, according to comment5,the version of nbdkit packages built from src package is correct, continue to test the function of nbdkit with below builds: virt-v2v-1.38.2-12.el7_6.1.x86_64 libguestfs-1.38.2-12.el7_6.1.x86_64 libvirt-4.5.0-10.el7_6.2.x86_64 qemu-kvm-rhev-2.12.0-18.el7_6.1.x86_64 1.Install ndbkit packages which are built from src package # rpm -qa |grep nbdkit nbdkit-example-plugins-1.2.6-1.el7.1.x86_64 nbdkit-plugin-python2-1.2.6-1.el7.1.x86_64 nbdkit-plugin-vddk-1.2.6-1.el7.1.x86_64 nbdkit-basic-plugins-1.2.6-1.el7.1.x86_64 nbdkit-1.2.6-1.el7.1.x86_64 nbdkit-debuginfo-1.2.6-1.el7.1.x86_64 nbdkit-devel-1.2.6-1.el7.1.x86_64 nbdkit-plugin-python-common-1.2.6-1.el7.1.x86_64 2.Convert a guest from VMware using vddk to rhv data domain by virt-v2v # virt-v2v -ic vpx://root.73.141/data/10.73.75.219/?no_verify=1 -it vddk -io vddk-libdir=/home/vmware-vix-disklib-distrib -io vddk-thumbprint=1F:97:34:5F:B6:C2:BA:66:46:CB:1A:71:76:7D:6B:50:1E:03:00:EA -o rhv-upload -oo rhv-cafile=/home/ca.pem -oo rhv-direct -oc https://ibm-x3250m5-03.rhts.eng.pek2.redhat.com/ovirt-engine/api -op /tmp/rhvpasswd --password-file /tmp/passwd -os nfs_data -b ovirtmgmt esx6.7-win2008r2-x86_64 -on esx6.7-win2008r2-nbdkit-src [ 0.3] Opening the source -i libvirt -ic vpx://root.73.141/data/10.73.75.219/?no_verify=1 esx6.7-win2008r2-x86_64 -it vddk -io vddk-libdir=/home/vmware-vix-disklib-distrib -io vddk-thumbprint=1F:97:34:5F:B6:C2:BA:66:46:CB:1A:71:76:7D:6B:50:1E:03:00:EA [ 2.1] Creating an overlay to protect the source from being modified [ 5.2] Initializing the target -o rhv-upload -oc https://ibm-x3250m5-03.rhts.eng.pek2.redhat.com/ovirt-engine/api -op /tmp/rhvpasswd -os nfs_data [ 6.6] Opening the overlay [ 11.4] Inspecting the overlay [ 13.6] Checking for sufficient free disk space in the guest [ 13.6] Estimating space required on target for each disk [ 13.6] Converting Windows Server 2008 R2 Standard to run on KVM virt-v2v: warning: /usr/share/virt-tools/pnp_wait.exe is missing. Firstboot scripts may conflict with PnP. virt-v2v: This guest has virtio drivers installed. [ 19.8] Mapping filesystem data to avoid copying unused and blank areas [ 20.5] Closing the overlay [ 20.7] Checking if the guest needs BIOS or UEFI to boot [ 20.7] Assigning disks to buses [ 20.7] Copying disk 1/1 to qemu URI json:{ "file.driver": "nbd", "file.path": "/var/tmp/rhvupload.WvsnqL/nbdkit1.sock", "file.export": "/" } (raw) (100.00/100%) [ 817.7] Creating output metadata [ 834.4] Finishing off Result: Virt-v2v can convert guest with nbdkit packages which are built from src package successfully, plus commnet5 and comment6, move the bug from ON_QA to VERIFIED Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:3658 |