Hide Forgot
Spec URL: https://sgallagh.fedorapeople.org/packagereview/python-ModulemdTranslationHelpers/python-ModulemdTranslationHelpers.spec SRPM URL: https://sgallagh.fedorapeople.org/packagereview/python-ModulemdTranslationHelpers/python-ModulemdTranslationHelpers-0.3-1.fc29.src.rpm Description: Provides a library and tools for dealing with translatable strings in modulemd documents. Fedora Account System Username: sgallagh COPR Build: https://copr.fedorainfracloud.org/coprs/sgallagh/mmdzanata/build/802691/ Note: This is a rename of the python-mmdzanata package, since it has been rewritten upstream to be more generic and not rely upon Zanata.
* Fedora.py, Utils.py and cli.py say they're part of modulemd-zanata. __init__.py is fine. Not going to block on this. * The SPEC URL also points to modulemd-zanata. * The Source URL returns HTTP 404. * __init__.py includes a shebang. It probably shouldn't. * The package obsoletes python*-mmdzanata but doesn't provide it. Is that correct and desired?
Also the changelog entry is older than the upstream project.
(In reply to Petr Šabata from comment #1) > * Fedora.py, Utils.py and cli.py say they're part of modulemd-zanata. > __init__.py is fine. > Not going to block on this. I'll fix that upstream for the next release. > > * The SPEC URL also points to modulemd-zanata. Oops, yeah, that's a mistake. > > * The Source URL returns HTTP 404. Same problem. > > * __init__.py includes a shebang. It probably shouldn't. > Hmm, I don't remember adding that. > * The package obsoletes python*-mmdzanata but doesn't provide it. > Is that correct and desired? Yes, it's not a drop-in replacement. Fixes will come shortly.
Spec URL: https://sgallagh.fedorapeople.org/packagereview/python-ModulemdTranslationHelpers/python-ModulemdTranslationHelpers.spec SRPM URL: https://sgallagh.fedorapeople.org/packagereview/python-ModulemdTranslationHelpers/python-ModulemdTranslationHelpers-0.5-1.fc29.src.rpm COPR Build: https://copr.fedorainfracloud.org/coprs/sgallagh/mmdzanata/build/802716/
* Bogus date in %changelog, line 106; it's not Friday yet ;) I'm going to approve this but fix that bit before pushing.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-ModulemdTranslationHelpers
python-ModulemdTranslationHelpers-0.5-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-fb406b54fc
python-ModulemdTranslationHelpers-0.5-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-48dc6606b9
python-ModulemdTranslationHelpers-0.5-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-4db20d042e
python-ModulemdTranslationHelpers-0.5-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-4db20d042e
python-ModulemdTranslationHelpers-0.5-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-48dc6606b9
python-ModulemdTranslationHelpers-0.5-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-fb406b54fc
This package requires a deprecated package (python2) and should not have been approved. Please stop adding python2 cruft to the distribution while we are trying to get rid of it. Stephen, Petr you are both in FESCo and should be well aware of this :(
It produces both py2 and py3 subpackages. I thought we were only disallowing py2-exclusive packages. I can drop the py2 build if needed.
We are disallowing anything new that depends on python2. We are removing py2 subpackages from packages that produce both py2 and py3 subpackages. We are retiring py2 only packages. > I can drop the py2 build if needed. Please do.
You're right, Miro, it totally slipped my mind during the review. Apologies!
Thank You. Sorry if my tone was a bit unfriendly, but it feel very frustrating to monitor how the py2 packages go away (very very slowly) and suddenly see some fresh ones.
python-ModulemdTranslationHelpers-0.5-3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-48dc6606b9
python-ModulemdTranslationHelpers-0.5-3.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-fb406b54fc
python-ModulemdTranslationHelpers-0.5-3.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-4db20d042e
python-ModulemdTranslationHelpers-0.5-3.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-4db20d042e
python-ModulemdTranslationHelpers-0.5-3.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-48dc6606b9
python-ModulemdTranslationHelpers-0.5-3.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-fb406b54fc
python-ModulemdTranslationHelpers-0.5-3.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.